From: Greg KH <gregkh@linuxfoundation.org>
To: Danilo Krummrich <dakr@kernel.org>
Cc: Alice Ryhl <aliceryhl@google.com>,
kernel@dakr.org, a.hindborg@kernel.org, alex.gaynor@gmail.com,
benno.lossin@proton.me, bjorn3_gh@protonmail.com,
boqun.feng@gmail.com, gary@garyguo.net,
linux-kernel@vger.kernel.org, lyude@redhat.com,
mairacanal@riseup.net, ojeda@kernel.org, rafael@kernel.org,
rust-for-linux@vger.kernel.org, tmgross@umich.edu
Subject: Re: [PATCH 2/2] rust/faux: Add missing parent argument to Registration::new()
Date: Wed, 26 Feb 2025 12:01:38 +0100 [thread overview]
Message-ID: <2025022609-hamper-paging-8761@gregkh> (raw)
In-Reply-To: <Z77vYxUYVyFtW2lG@cassiopeiae>
On Wed, Feb 26, 2025 at 11:39:31AM +0100, Danilo Krummrich wrote:
> > > I think if we want to add something to the safety comment, it should be somthing
> > > along the line of "the type of `parent` implies that for the duration of this
> > > call `parent` is a valid device with a non-zero reference count".
> >
> > I don't understand the need for any safety comment about the parent
> > here. Again, as long as it is valid when the call is made, that is all
> > that is needed.
>
> Right, and we could mention that in the safety comment that something of the
> type `&device::Device` is indeed valid by definition and hence fullfills the
> requirement of faux_device_create() to get a valid pointer (or NULL).
Agreed. I'll go apply patch 1 of the series now and wait for a new
version of 2/2.
thanks!
greg k-h
next prev parent reply other threads:[~2025-02-26 11:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 21:28 [PATCH 0/2] rust/faux: Minor binding fixes Lyude Paul
2025-02-25 21:29 ` [PATCH 1/2] rust/faux: Drop #[repr(transparent)] from faux::Registration Lyude Paul
2025-02-25 22:07 ` Danilo Krummrich
2025-02-26 8:39 ` Alice Ryhl
2025-02-26 12:59 ` Fiona Behrens
2025-02-25 21:29 ` [PATCH 2/2] rust/faux: Add missing parent argument to Registration::new() Lyude Paul
2025-02-25 22:07 ` Danilo Krummrich
2025-02-26 8:38 ` Alice Ryhl
2025-02-26 9:05 ` kernel
2025-02-26 9:03 ` kernel
2025-02-26 9:23 ` Alice Ryhl
2025-02-26 9:42 ` Danilo Krummrich
2025-02-26 9:51 ` Alice Ryhl
2025-02-26 9:58 ` Greg KH
2025-02-26 10:39 ` Danilo Krummrich
2025-02-26 11:01 ` Greg KH [this message]
2025-02-26 10:01 ` Greg Kroah-Hartman
2025-02-26 16:51 ` Lyude Paul
2025-02-26 19:31 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025022609-hamper-paging-8761@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=kernel@dakr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=mairacanal@riseup.net \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).