From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FE5724DFFC; Wed, 26 Feb 2025 10:30:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740565856; cv=none; b=dP41ai0jeDahIdNATMEZ2dZlXYdTVHhlOG1byLy/tlEdbkUW/gghBVjBTyaP8toVSziAA6iahv7a3PD0d7ofACczi6M66hkmc1sK6A+2ftZVVvPpFmfCmnTSCgWuJYPIftWEBsBSDpqGm8cE9+XHqfKMPQrK99EVXnheWPHCVAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740565856; c=relaxed/simple; bh=kBUtFhM8QF9lXl5OpGbCyIrYvEiAU3LRgYh6moTbcNk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LIPQbe/ydLSYJpjxLISiYyQUPl0zGtYKbMqJDQRAWPBFIRHPC8AtMWMCD+rAKoMs41vA1o6xNOyqnHaYXZaVZeGdksvGkwjUjMnsnTTpA9aweEugoWJpVx83zdeKdo1t7TQ1ERXIM9iGPIR711p57zQmaVo4hm0sC+RllZYO+R4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=x/z/PNKy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="x/z/PNKy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7C58C4CEE2; Wed, 26 Feb 2025 10:30:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1740565855; bh=kBUtFhM8QF9lXl5OpGbCyIrYvEiAU3LRgYh6moTbcNk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=x/z/PNKyqA4PfaRNvSey27ZTn7J05bWCh1y6AuSHXaKbsuIZbgCgF5SfXl9GxP2Z7 065ngG6haLk6ln7TkkSlWws7pfkhzxlXfPzhpjuytZpJR0F//RpCQLnhkfNJrpJhQK HRhuiH2KFKxSftKP77aaZn3LBM5y0sTRshzg8quY= Date: Wed, 26 Feb 2025 11:07:11 +0100 From: Greg Kroah-Hartman To: Louis Chauvet Cc: Thomas Zimmermann , linux-kernel@vger.kernel.org, Lyude Paul , "Rafael J. Wysocki" , Danilo Krummrich , Alexander Lobakin , Andy Shevchenko , Bjorn Helgaas , Jonathan Cameron , Liam Girdwood , Lukas Wunner , Mark Brown , =?iso-8859-1?Q?Ma=EDra?= Canal , Robin Murphy , Simona Vetter , Zijun Hu , linux-usb@vger.kernel.org, rust-for-linux@vger.kernel.org, Haneen Mohammed , Simona Vetter , Melissa Wen , Maarten Lankhorst , Maxime Ripard , David Airlie , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 9/9] drm/vkms: convert to use faux_device Message-ID: <2025022643-scouting-petticoat-492b@gregkh> References: <2025021023-sandstorm-precise-9f5d@gregkh> <2025021029-snout-swivel-9a45@gregkh> <49cd8502-f11e-4ade-a3a0-b16ce0c6282f@bootlin.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <49cd8502-f11e-4ade-a3a0-b16ce0c6282f@bootlin.com> On Tue, Feb 25, 2025 at 02:51:40PM +0100, Louis Chauvet wrote: > > > Le 25/02/2025 à 12:41, Thomas Zimmermann a écrit : > > Hi > > > > Am 10.02.25 um 15:37 schrieb Louis Chauvet: > > > On 10/02/25 - 13:30, Greg Kroah-Hartman wrote: > > > > The vkms driver does not need to create a platform device, as there is > > > > no real platform resources associated it, it only did so because it was > > > > simple to do that in order to get a device to use for resource > > > > management of drm resources. Change the driver to use the faux device > > > > instead as this is NOT a real platform device. > > > > > > > > Cc: Louis Chauvet > > > > Cc: Haneen Mohammed > > > > Cc: Simona Vetter > > > > Cc: Melissa Wen > > > > Cc: Maarten Lankhorst > > > > Cc: Maxime Ripard > > > > Cc: Thomas Zimmermann > > > > Cc: David Airlie > > > > Cc: dri-devel@lists.freedesktop.org > > > > Reviewed-by: Lyude Paul > > > > Signed-off-by: Greg Kroah-Hartman > > > > Reviewed-by: Thomas Zimmermann > > > > > Tested-by: Louis Chauvet > > > Reviewed-by: Louis Chauvet > > > > > > Thanks for the modification, it seems to work. > > > > Should this patch be merged through DRM trees? drm-misc-next is at > > v6.14-rc4 and has struct faux_device. > > Hi, > > I was not aware the faux-device was merged, as it is a new feature, I > expected it to reach drm-misc-next on 6.15-rc1. I added it to Linus's tree just so that DRM could get these changes into their tree now :) > I plan to merge [1] today/tomorrow (well tested with platform_device), and > then I will submit an updated version of this patch (only trivial conflicts, > but never tested with multiple VKMS devices). > > [1]:https://lore.kernel.org/all/20250218101214.5790-1-jose.exposito89@gmail.com/ Great, thanks! greg k-h