From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83749281346 for ; Thu, 27 Feb 2025 22:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740694925; cv=none; b=I0BD1L6R8c0wW4Ulw6MzDIpbi3EkPnpuoBY8sDKg+4AzjA3cgeFca8kxsB8GI6ZIuzzPFMqCRxDHa3vNe5hLbJdkdXMeddE1oKne23Efn3rtmZN6gU99KTMvY6rPZJb/vLkg8YHua+pzr4fIH4Zz+AFTQOlnQaWewGyCtXFurCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740694925; c=relaxed/simple; bh=Bjlh6f2h0agBH/X5+BSZSaxb5OWC0yikWYM7fvxP5A0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vCDW2pH+VZ1h8aEfgTEqrB9w9+1gP+HD7Qzq8qNn/Uh/IdytmzrA+2DYVWIOltuyX0dIBH0xHDaWf65e7WzntIhXlOwE6IMn1nZ2AG70FddMDg96VArm/SjMWUi/FGHLfEkhAu48J310QFWZD5wDXk8TtSIMXrchmL/4pyJN5fw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Vr85M3Vz; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Vr85M3Vz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740694922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DBmwa/9zDxm/5fPjgaaosFv6cMSWcpF0vesBiqkaxE8=; b=Vr85M3VzWEnf3phij0cxHz6iFVtFv6EZJBTICdwr4rpaJ9lcSRbmuUE5P7mjYmBZggs5PC nAMXVn7yttXreQujQhICmmDoxENcse23z40NqVjCJilrCpbonuQmJZxn9jdnOCN3tGWtqg 5N1eZmItKIo/9DYTe8rA/mYvr7r79Pw= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-E4-AZAfVPRyalTKtIx5CFA-1; Thu, 27 Feb 2025 17:21:57 -0500 X-MC-Unique: E4-AZAfVPRyalTKtIx5CFA-1 X-Mimecast-MFC-AGG-ID: E4-AZAfVPRyalTKtIx5CFA_1740694915 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 07DEB1954B23; Thu, 27 Feb 2025 22:21:55 +0000 (UTC) Received: from chopper.lyude.net (unknown [10.22.89.128]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3A5321944D02; Thu, 27 Feb 2025 22:21:52 +0000 (UTC) From: Lyude Paul To: rust-for-linux@vger.kernel.org, Thomas Gleixner Cc: Boqun Feng , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Miguel Ojeda , Alex Gaynor , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , linux-kernel@vger.kernel.org (open list:LOCKING PRIMITIVES) Subject: [PATCH v9 8/9] rust: sync: lock: Add `Backend::BackendInContext` Date: Thu, 27 Feb 2025 17:10:19 -0500 Message-ID: <20250227221924.265259-9-lyude@redhat.com> In-Reply-To: <20250227221924.265259-1-lyude@redhat.com> References: <20250227221924.265259-1-lyude@redhat.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 From: Boqun Feng `SpinLock`'s backend can be used for `SpinLockIrq`, if the interrupts are disabled. And it actually provides performance gains since interrupts are not needed to be disabled anymore. So add `Backend::BackendInContext` to describe the case where one backend can be used for another. Use the it to implement the `lock_with()` so that `SpinLockIrq` can avoid disabling interrupts by using `SpinLock`'s backend. Signed-off-by: Boqun Feng Signed-off-by: Lyude Paul --- rust/kernel/sync/lock.rs | 26 ++++++++++++++++++-- rust/kernel/sync/lock/mutex.rs | 1 + rust/kernel/sync/lock/spinlock.rs | 41 +++++++++++++++++++++++++++++++ 3 files changed, 66 insertions(+), 2 deletions(-) diff --git a/rust/kernel/sync/lock.rs b/rust/kernel/sync/lock.rs index e7c1fd028435e..54c77972c83f8 100644 --- a/rust/kernel/sync/lock.rs +++ b/rust/kernel/sync/lock.rs @@ -32,10 +32,15 @@ /// is owned, that is, between calls to [`lock`] and [`unlock`]. /// - Implementers must also ensure that [`relock`] uses the same locking method as the original /// lock operation. +/// - Implementers must ensure if [`BackendInContext`] is a [`Backend`], it's safe to acquire lock +/// under the [`Context`], the [`State`] of two backends must be the same. /// /// [`lock`]: Backend::lock /// [`unlock`]: Backend::unlock /// [`relock`]: Backend::relock +/// [`BackendInContext`]: Backend::BackendInContext +/// [`Context`]: Backend::Context +/// [`State`]: Backend::State pub unsafe trait Backend { /// The state required by the lock. type State; @@ -49,6 +54,9 @@ pub unsafe trait Backend { /// The context which can be provided to acquire the lock with a different backend. type Context<'a>; + /// The alternative backend we can use if a [`Context`](Backend::Context) is provided. + type BackendInContext: Sized; + /// Initialises the lock. /// /// # Safety @@ -170,8 +178,22 @@ pub unsafe fn from_raw<'a>(ptr: *mut B::State) -> &'a Self { impl Lock { /// Acquires the lock with the given context and gives the caller access to the data protected /// by it. - pub fn lock_with<'a>(&'a self, _context: B::Context<'a>) -> Guard<'a, T, B> { - todo!() + pub fn lock_with<'a>(&'a self, _context: B::Context<'a>) -> Guard<'a, T, B::BackendInContext> + where + B::BackendInContext: Backend, + { + // SAFETY: Per the safety guarantee of `Backend`, if `B::BackendIncontext` and `B` should + // have the same state, therefore the layout of the lock is the same so it's safe the + // convert one to another. + let lock = unsafe { &*(self as *const _ as *const Lock) }; + // SAFETY: The constructor of the type calls `init`, so the existence of the object proves + // that `init` was called. Plus the safety guarantee of `Backend` guarantees that `B::state` + // is the same as `B::BackendInContext::state`, also it's safe to call another backend + // because there is `B::Context<'a>`. + let state = unsafe { B::BackendInContext::lock(lock.state.get()) }; + + // SAFETY: The lock was just acquired. + unsafe { Guard::new(lock, state) } } /// Acquires the lock and gives the caller access to the data protected by it. diff --git a/rust/kernel/sync/lock/mutex.rs b/rust/kernel/sync/lock/mutex.rs index 53c8e8b90b85c..f15406ce82e51 100644 --- a/rust/kernel/sync/lock/mutex.rs +++ b/rust/kernel/sync/lock/mutex.rs @@ -102,6 +102,7 @@ unsafe impl super::Backend for MutexBackend { type State = bindings::mutex; type GuardState = (); type Context<'a> = (); + type BackendInContext = (); unsafe fn init( ptr: *mut Self::State, diff --git a/rust/kernel/sync/lock/spinlock.rs b/rust/kernel/sync/lock/spinlock.rs index 6b355887bd3ea..6c76f5c25036f 100644 --- a/rust/kernel/sync/lock/spinlock.rs +++ b/rust/kernel/sync/lock/spinlock.rs @@ -102,6 +102,7 @@ unsafe impl super::Backend for SpinLockBackend { type State = bindings::spinlock_t; type GuardState = (); type Context<'a> = (); + type BackendInContext = (); unsafe fn init( ptr: *mut Self::State, @@ -220,6 +221,45 @@ macro_rules! new_spinlock_irq { /// # Ok::<(), Error>(()) /// ``` /// +/// The next example demonstrates locking a [`SpinLockIrq`] using [`lock_with()`] in a function +/// which can only be called when local processor interrupts are already disabled. +/// +/// ``` +/// use kernel::sync::{new_spinlock_irq, SpinLockIrq}; +/// use kernel::interrupt::*; +/// +/// struct Inner { +/// a: u32, +/// } +/// +/// #[pin_data] +/// struct Example { +/// #[pin] +/// inner: SpinLockIrq, +/// } +/// +/// impl Example { +/// fn new() -> impl PinInit { +/// pin_init!(Self { +/// inner <- new_spinlock_irq!(Inner { a: 20 }), +/// }) +/// } +/// } +/// +/// // Accessing an `Example` from a function that can only be called in no-interrupt contexts. +/// fn noirq_work(e: &Example, interrupt_disabled: &LocalInterruptDisabled) { +/// // Because we know interrupts are disabled from interrupt_disable, we can skip toggling +/// // interrupt state using lock_with() and the provided token +/// assert_eq!(e.inner.lock_with(interrupt_disabled).a, 20); +/// } +/// +/// # let e = KBox::pin_init(Example::new(), GFP_KERNEL)?; +/// # let interrupt_guard = local_interrupt_disable(); +/// # noirq_work(&e, &interrupt_guard); +/// # +/// # Ok::<(), Error>(()) +/// ``` +/// /// [`lock()`]: SpinLockIrq::lock /// [`lock_with()`]: SpinLockIrq::lock_with pub type SpinLockIrq = super::Lock; @@ -244,6 +284,7 @@ unsafe impl super::Backend for SpinLockIrqBackend { type State = bindings::spinlock_t; type GuardState = (); type Context<'a> = &'a LocalInterruptDisabled; + type BackendInContext = SpinLockBackend; unsafe fn init( ptr: *mut Self::State, -- 2.48.1