From: Miguel Ojeda <ojeda@kernel.org>
To: aliceryhl@google.com
Cc: a.hindborg@kernel.org, alex.gaynor@gmail.com,
benno.lossin@proton.me, bjorn3_gh@protonmail.com,
boqun.feng@gmail.com, gary@garyguo.net, lina@asahilina.net,
linux-kernel@vger.kernel.org, miguel.ojeda.sandonis@gmail.com,
ojeda@kernel.org, oliver.mangold@pm.me,
rust-for-linux@vger.kernel.org, tmgross@umich.edu,
patches@lists.linux.dev
Subject: [PATCH] rust: kbuild: provide `RUSTC_HAS_DO_NOT_RECOMMEND` symbol
Date: Sun, 9 Mar 2025 22:48:57 +0100 [thread overview]
Message-ID: <20250309214857.1559606-1-ojeda@kernel.org> (raw)
In-Reply-To: <Z8sXqXgfhHbNpG6B@google.com>
Rust 1.85.0 (current stable version) stabilized [1]
`#[diagnostic::do_not_recommend]` [2].
In order to use it across all supported Rust versions, introduce a new
Kconfig symbol for it.
This allows to perform conditional compilation based on it, e.g. on the
use site to enable the attribute:
#[cfg_attr(RUSTC_HAS_DO_NOT_RECOMMEND, diagnostic::do_not_recommend)]
impl A for i32 {}
An alternative would have been to `allow` the following warning:
#![allow(unknown_or_malformed_diagnostic_attributes)]
However, that would lose the checking for typos across all versions,
which we do not want to lose.
One can also use the Kconfig symbol to allow the warning in older
compilers instead, to avoid repeating the `cfg_attr` line above in all
use sites:
#![cfg_attr(
not(RUSTC_HAS_DO_NOT_RECOMMEND),
expect(unknown_or_malformed_diagnostic_attributes)
)]
That still loses the checking for typos in older versions, but we still
keep it in newer ones, thus we should still catch mistakes eventually.
In this case we can promote it to `expect` as shown above, so that we do
not forget to remove these lines if we stop using the attribute somewhere.
Link: https://github.com/rust-lang/rust/pull/132056 [1]
Link: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-diagnosticdo_not_recommend-attribute [2]
Link: https://lore.kernel.org/rust-for-linux/CANiq72mYfhuRWkjomb1vOMMPOaxvdS6qjfVLAwxUw6ecdqyh2A@mail.gmail.com/
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
init/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/init/Kconfig b/init/Kconfig
index d0d021b3fa3b..213b4cc9310a 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -132,6 +132,9 @@ config CC_HAS_COUNTED_BY
config RUSTC_HAS_COERCE_POINTEE
def_bool RUSTC_VERSION >= 108400
+config RUSTC_HAS_DO_NOT_RECOMMEND
+ def_bool RUSTC_VERSION >= 108500
+
config PAHOLE_VERSION
int
default $(shell,$(srctree)/scripts/pahole-version.sh $(PAHOLE))
base-commit: 7eb172143d5508b4da468ed59ee857c6e5e01da6
--
2.48.1
next prev parent reply other threads:[~2025-03-09 21:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 10:04 [PATCH v5 0/4] New trait OwnableRefCounted for ARef<->Owned conversion Oliver Mangold
2025-03-07 10:04 ` [PATCH v5 1/4] rust: types: Add Ownable/Owned types Oliver Mangold
2025-03-07 10:04 ` [PATCH v5 2/4] rust: make Owned::into_raw() and Owned::from_raw() public Oliver Mangold
2025-03-07 13:17 ` Miguel Ojeda
2025-03-07 10:04 ` [PATCH v5 3/4] rust: rename AlwaysRefCounted to RefCounted Oliver Mangold
2025-03-07 10:04 ` [PATCH v5 4/4] rust: adding OwnableRefCounted and SimpleOwnableRefCounted Oliver Mangold
2025-03-07 13:16 ` Miguel Ojeda
2025-03-07 13:28 ` Alice Ryhl
2025-03-07 13:53 ` Miguel Ojeda
2025-03-07 15:58 ` Alice Ryhl
2025-03-09 21:47 ` Miguel Ojeda
2025-03-09 21:48 ` Miguel Ojeda [this message]
2025-03-09 21:55 ` [PATCH] rust: kbuild: provide `RUSTC_HAS_DO_NOT_RECOMMEND` symbol Miguel Ojeda
2025-03-10 7:08 ` [PATCH v5 4/4] rust: adding OwnableRefCounted and SimpleOwnableRefCounted Oliver Mangold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250309214857.1559606-1-ojeda@kernel.org \
--to=ojeda@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=oliver.mangold@pm.me \
--cc=patches@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).