From: Oliver Mangold <oliver.mangold@pm.me>
To: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Asahi Lina" <lina@asahilina.net>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Oliver Mangold <oliver.mangold@pm.me>
Subject: [PATCH v6 2/5] rust: make Owned::into_raw() and Owned::from_raw() public
Date: Mon, 10 Mar 2025 08:49:50 +0000 [thread overview]
Message-ID: <20250310-unique-ref-v6-2-1ff53558617e@pm.me> (raw)
In-Reply-To: <20250310-unique-ref-v6-0-1ff53558617e@pm.me>
It might be necessary to be used from some drivers containing C code like,
e.g. binder. It basically is needed for every implementation of an Ownable
outside of the kernel crate. Also the examples for OwnableRefCounted need
it.
Signed-off-by: Oliver Mangold <oliver.mangold@pm.me>
---
rust/kernel/types.rs | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/rust/kernel/types.rs b/rust/kernel/types.rs
index 0cae5ba6607f0a86d2f0e3494f956f6daad78067..e0ce3646a4d3b70c069322a9b0f25c00265a2af8 100644
--- a/rust/kernel/types.rs
+++ b/rust/kernel/types.rs
@@ -616,7 +616,7 @@ impl<T: Ownable> Owned<T> {
///
/// Callers must ensure that the underlying object is acquired and can be considered owned by
/// Rust.
- pub(crate) unsafe fn from_raw(ptr: NonNull<T>) -> Self {
+ pub unsafe fn from_raw(ptr: NonNull<T>) -> Self {
// INVARIANT: The safety requirements guarantee that the new instance now owns the
// reference.
Self {
@@ -630,8 +630,7 @@ pub(crate) unsafe fn from_raw(ptr: NonNull<T>) -> Self {
/// This function does not actually relinquish ownership of the object.
/// After calling this function, the caller is responsible for ownership previously managed
/// by the `Owned`.
- #[allow(dead_code)]
- pub(crate) fn into_raw(me: Self) -> NonNull<T> {
+ pub fn into_raw(me: Self) -> NonNull<T> {
ManuallyDrop::new(me).ptr
}
}
--
2.48.1
next prev parent reply other threads:[~2025-03-10 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 8:49 [PATCH v6 0/5] New trait OwnableRefCounted for ARef<->Owned conversion Oliver Mangold
2025-03-10 8:49 ` [PATCH v6 1/5] rust: types: Add Ownable/Owned types Oliver Mangold
2025-03-10 9:50 ` Alice Ryhl
2025-03-10 8:49 ` Oliver Mangold [this message]
2025-03-10 9:50 ` [PATCH v6 2/5] rust: make Owned::into_raw() and Owned::from_raw() public Alice Ryhl
2025-03-10 10:00 ` Oliver Mangold
2025-03-10 10:32 ` Danilo Krummrich
2025-03-10 10:44 ` Oliver Mangold
2025-03-10 8:49 ` [PATCH v6 3/5] rust: rename AlwaysRefCounted to RefCounted Oliver Mangold
2025-03-10 8:50 ` [PATCH v6 4/5] rust: kbuild: provide `RUSTC_HAS_DO_NOT_RECOMMEND` symbol Oliver Mangold
2025-03-10 8:50 ` [PATCH v6 5/5] rust: adding OwnableRefCounted and SimpleOwnableRefCounted Oliver Mangold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310-unique-ref-v6-2-1ff53558617e@pm.me \
--to=oliver.mangold@pm.me \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).