From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DE8025FA0E; Wed, 26 Mar 2025 21:33:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743024834; cv=none; b=sMOmlSZGoPXGmtQ7qhp87TjMGhI+x85iwy7GzhPdVKjCxopJA7WlxGyGz24umhCW7blBxtIWoyQREUNUphCYEKq+FMKY7XGlU7nptUy6D/TlsBYJzRgf9/l3MgJIXG6njJ3/AdV27bX/kUURO+iS2Dw0sNbmnyIUG+WpwB25i38= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743024834; c=relaxed/simple; bh=8xEA2OShHhaqsNPdu0wc3xsXBHIf6cUYnQTL28FkuQo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iDIsnteM3YASXaKrhYIWbBjuKBr/rBAka0/vnVEcK0r3fxQkTNjC6StLnpLlAKOoJT3J7zxZwddbRpkZyoTQkzKaaWugHiHQDVQ6vttZKqIa2mGsrBCV4Ked7twZFHLXb6Ky4CaP7YSOPmvY0tMNZvgn+qY9S0rOWUhnn8glK9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dhAVbwjG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dhAVbwjG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9089C4CEE2; Wed, 26 Mar 2025 21:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743024834; bh=8xEA2OShHhaqsNPdu0wc3xsXBHIf6cUYnQTL28FkuQo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dhAVbwjGxcVI4N1P+u2VZxME5ITtTdoATVxDGXuNIGhzYLSXLUupbew6JtLQiy+Oz S0M0jCCdqgGJEa0ty3M+4fRxsacBZovUTb5eRNQ4oQki34V674R8AxRP6ezTiJJYHI 0vXrDJHT5OEn7WVz0K14znjoraVTYZGuXcNXwQ8ADex0XMprh2YcS8LhsFDRSWFcyw 54oOjbi1A1VAK/4fOLQNvd/N4Cek4qeFUxlAcz7gslyloRb3kvKWDYCXpAwklI8Kc7 UmFRdtl74tMdQh0CJYSgS5MTnnPxW9SH/KxiFGycrZCA2TaS1AVA39oxoKLpyj38Il F5XQkCvqyS05g== Date: Wed, 26 Mar 2025 16:33:52 -0500 From: Rob Herring To: Remo Senekowitsch Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Dirk Behme , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Saravana Kannan , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH 05/10] rust: Read properties via single generic method Message-ID: <20250326213352.GB2844851-robh@kernel.org> References: <20250326171411.590681-1-remo@buenzli.dev> <20250326171411.590681-6-remo@buenzli.dev> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250326171411.590681-6-remo@buenzli.dev> On Wed, Mar 26, 2025 at 06:13:44PM +0100, Remo Senekowitsch wrote: > This can probably be squashed into its parent. I haven't done that > yet in case there is something wrong with the generic approach and the > previous one is preferred. Looks good to me other than the returning of strings issue. And yes it should be squashed. (Really, it should have been in this series so reviewers aren't reviewing code you delete in the next patch). > > Signed-off-by: Remo Senekowitsch > --- > rust/kernel/property.rs | 171 +++++++++++++++++++++++----------------- > 1 file changed, 99 insertions(+), 72 deletions(-)