rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Almeida <daniel.almeida@collabora.com>
To: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	 Daniel Almeida <daniel.almeida@collabora.com>
Subject: [PATCH v3 0/2] rust: add support for request_irq
Date: Wed, 14 May 2025 16:20:50 -0300	[thread overview]
Message-ID: <20250514-topics-tyr-request_irq-v3-0-d6fcc2591a88@collabora.com> (raw)


---
Changes in v3:
- Rebased on driver-core-next
- Added patch to get the irq numbers from a platform device (thanks,
  Christian!)
- Split flags into its own file.
- Change iff to "if and only if"
- Implement PartialEq and Eq for Flags
- Fix some broken docs/markdown
- Reexport most things so users can elide ::request from the path
- Add a blanket implementation of ThreadedHandler and Handler for
  Arc/Box<T: Handler> that just forwards the call to the T. This lets us
  have Arc<Foo> and Box<Foo> as handlers if Foo: Handler.
- Rework the examples a bit.
- Remove "as _" casts in favor of "as u64" for flags. This is needed to
  cast the individual flags into u64.
- Use #[repr(u32)] for ThreadedIrqReturn and IrqReturn.
- Wrapped commit messages to < 75 characters

- Link to v2: https://lore.kernel.org/r/20250122163932.46697-1-daniel.almeida@collabora.com

Changes in v2:
- Added Co-developed-by tag to account for the work that Alice did in order to
figure out how to do this without Opaque<T> (Thanks!)
- Removed Opaque<T> in favor of plain T
- Fixed the examples
- Made sure that the invariants sections are the last entry in the docs
- Switched to slot.cast() where applicable,
- Mentioned in the safety comments that we require that T: Sync,
- Removed ThreadedFnReturn in favor of IrqReturn,
- Improved the commit message

Link to v1: https://lore.kernel.org/rust-for-linux/20241024-topic-panthor-rs-request_irq-v1-1-7cbc51c182ca@collabora.com/

---
Daniel Almeida (2):
      rust: irq: add support for request_irq()
      rust: platform: add irq accessors

 rust/bindings/bindings_helper.h |   1 +
 rust/helpers/helpers.c          |   1 +
 rust/helpers/irq.c              |   9 +
 rust/kernel/irq.rs              |  24 +++
 rust/kernel/irq/flags.rs        | 102 +++++++++
 rust/kernel/irq/request.rs      | 455 ++++++++++++++++++++++++++++++++++++++++
 rust/kernel/lib.rs              |   1 +
 rust/kernel/platform.rs         |  52 +++++
 8 files changed, 645 insertions(+)
---
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
change-id: 20250514-topics-tyr-request_irq-4f6a30837ea8

Best regards,
-- 
Daniel Almeida <daniel.almeida@collabora.com>


             reply	other threads:[~2025-05-14 19:21 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-14 19:20 Daniel Almeida [this message]
2025-05-14 19:20 ` [PATCH v3 1/2] rust: irq: add support for request_irq() Daniel Almeida
2025-05-14 20:04   ` Benno Lossin
2025-05-14 20:58     ` Daniel Almeida
2025-05-14 21:03       ` Daniel Almeida
2025-05-15  8:46       ` Benno Lossin
2025-05-15 12:06         ` Daniel Almeida
2025-05-15 12:44           ` Benno Lossin
2025-06-02 15:20     ` Alice Ryhl
2025-06-04  7:36       ` Benno Lossin
2025-06-04  7:48         ` Alice Ryhl
2025-06-04  9:43           ` Benno Lossin
2025-05-14 21:53   ` Danilo Krummrich
2025-05-15 11:54     ` Daniel Almeida
2025-05-15 12:04       ` Danilo Krummrich
2025-05-15 12:27         ` Daniel Almeida
2025-05-15 12:45           ` Danilo Krummrich
2025-05-15 13:16             ` Daniel Almeida
2025-05-15 13:45               ` Danilo Krummrich
2025-05-15 13:52                 ` Danilo Krummrich
2025-06-02 14:40                   ` Daniel Almeida
2025-06-02 17:35                     ` Danilo Krummrich
2025-06-02 16:02                   ` Alice Ryhl
2025-05-15 13:28             ` Benno Lossin
2025-06-02 16:19     ` Alice Ryhl
2025-06-02 17:31       ` Danilo Krummrich
2025-06-03  8:28         ` Alice Ryhl
2025-06-03  8:46           ` Danilo Krummrich
2025-06-03  8:54             ` Alice Ryhl
2025-06-03  9:10               ` Danilo Krummrich
2025-06-03  9:18                 ` Alice Ryhl
2025-06-03  9:43                   ` Danilo Krummrich
2025-06-03  9:57                     ` Alice Ryhl
2025-06-03 10:08                       ` Danilo Krummrich
2025-06-03 10:16                         ` Danilo Krummrich
2025-06-04 18:32                           ` Daniel Almeida
2025-06-04 18:57                             ` Danilo Krummrich
2025-05-18 13:24   ` Alexandre Courbot
2025-05-18 14:07     ` Benno Lossin
2025-05-14 19:20 ` [PATCH v3 2/2] rust: platform: add irq accessors Daniel Almeida
2025-05-14 20:06   ` Benno Lossin
2025-05-19 10:41   ` Danilo Krummrich
2025-06-02 14:56     ` Daniel Almeida
2025-06-02 17:45       ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250514-topics-tyr-request_irq-v3-0-d6fcc2591a88@collabora.com \
    --to=daniel.almeida@collabora.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).