From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Petr Tesařík" <petr@tesarici.cz>
Cc: "Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
acourbot@nvidia.com, dakr@kernel.org, lyude@redhat.com,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Valentin Obst" <kernel@valentinobst.de>,
"open list" <linux-kernel@vger.kernel.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Robin Murphy" <robin.murphy@arm.com>,
airlied@redhat.com, rust-for-linux@vger.kernel.org,
"open list:DMA MAPPING HELPERS" <iommu@lists.linux.dev>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Sui Jingfeng" <sui.jingfeng@linux.dev>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Michael Kelley" <mhklinux@outlook.com>
Subject: Re: [PATCH 1/2] rust: add initial scatterlist bindings
Date: Thu, 29 May 2025 11:36:34 -0300 [thread overview]
Message-ID: <20250529143634.GD192517@ziepe.ca> (raw)
In-Reply-To: <20250529161424.5cd95308@meshulam.tesarici.cz>
On Thu, May 29, 2025 at 04:14:24PM +0200, Petr Tesařík wrote:
> Thank you, Jason. You already made this suggestion for the RFC version,
> and it begs the question if perhaps the underlying C API should also be
> deprecated and eventually removed from the kernel.
It is not "broken", it is just complicated to use right and doesn't
fit the sematics rust would expect.
Yes, it would be nice if more places used sgtable and append instead
but there are so many places and many weird special cases.
scatterlist is so widely used and in so many bonkers ways it is felt
to be unchangable.
My advice is that rust should not just have a thin wrapper around
scatterlist but actually provide a sane correct higher level API and
wall off more of the difficult choices (like set_page)
Arguably Rust shouldn't have scatterlist at all, but only sgtable
which is the higher level and easier to use interface.
We also just merged a non-scatterlist DMA mapping API, maybe rust
shouldn't have scatterlist at all. IDK.
Jason
next prev parent reply other threads:[~2025-05-29 14:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 22:14 [PATCH 0/2] rust: add initial scatterlist abstraction Abdiel Janulgue
2025-05-28 22:14 ` [PATCH 1/2] rust: add initial scatterlist bindings Abdiel Janulgue
2025-05-29 0:45 ` Jason Gunthorpe
2025-05-29 14:14 ` Petr Tesařík
2025-05-29 14:36 ` Jason Gunthorpe [this message]
2025-05-30 14:02 ` Alexandre Courbot
2025-05-30 14:14 ` Jason Gunthorpe
2025-05-30 14:44 ` Alexandre Courbot
2025-05-30 14:50 ` Jason Gunthorpe
2025-05-30 15:18 ` Danilo Krummrich
2025-05-31 12:54 ` Alexandre Courbot
2025-06-02 11:40 ` Jason Gunthorpe
2025-06-02 12:25 ` Abdiel Janulgue
2025-06-02 12:41 ` Alexandre Courbot
2025-06-04 18:21 ` Lyude Paul
2025-06-05 5:51 ` Alexandre Courbot
2025-06-05 13:30 ` Abdiel Janulgue
2025-06-05 13:56 ` Alexandre Courbot
2025-06-09 17:44 ` Lyude Paul
2025-06-18 1:03 ` Alexandre Courbot
2025-06-26 20:31 ` Abdiel Janulgue
2025-06-26 22:43 ` Jason Gunthorpe
2025-06-26 23:44 ` Danilo Krummrich
2025-06-28 11:07 ` Alexandre Courbot
2025-06-05 13:22 ` Abdiel Janulgue
2025-06-28 11:18 ` Alexandre Courbot
2025-06-30 7:11 ` Abdiel Janulgue
2025-06-05 15:35 ` Boqun Feng
2025-06-05 16:02 ` Jason Gunthorpe
2025-06-05 16:18 ` Boqun Feng
2025-05-30 11:04 ` Alexandre Courbot
2025-05-28 22:14 ` [PATCH 2/2] samples: rust: add sample code for " Abdiel Janulgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250529143634.GD192517@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=acourbot@nvidia.com \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=herbert@gondor.apana.org.au \
--cc=iommu@lists.linux.dev \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=m.szyprowski@samsung.com \
--cc=mhklinux@outlook.com \
--cc=ojeda@kernel.org \
--cc=petr@tesarici.cz \
--cc=rdunlap@infradead.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=sui.jingfeng@linux.dev \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).