From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A0142904; Sat, 31 May 2025 05:49:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748670590; cv=none; b=YoHzGebxMORwJF+V1il/7lDfi39OxW5lcywerg4wF4/cssNP6CPwfnmNgh4vKUhqAIgMAC+//0JcJPost4ML1ejqWUb13LGhaOmxSSpWYxIPCodhsn/OAOj241We/XGDFwM6taQI6VyrvrhxJBb0tRpYWn/+uiSm1nUVI/WHalY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748670590; c=relaxed/simple; bh=3rztAwoj/CLKv7pyv7i7aukmruToEE0/FZ2bxxCzmxM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bZ9suoUQYFmcCERD9urgiopEh14unKFNdMDhphxJdhDQ3ASW2kJeJ7KbLibQlLQbnVIdbm1jS+tqgDFwnkQ3jZBASIOUI9lTrwR8ipcveUuz4bNdui5UMNSteTAIj+exg6O+81K1vODuji//oL0aJ9jPAe/10dnEaNKSAI+eEcc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0CctRSZB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0CctRSZB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20D5AC4CEE3; Sat, 31 May 2025 05:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1748670589; bh=3rztAwoj/CLKv7pyv7i7aukmruToEE0/FZ2bxxCzmxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0CctRSZBzVq5upNYar9hc5fdQL8nvDgDWnSOyL1X08oXi0XwwRaCBpORb0c2y5wv9 iGJenbHnFR6gCzQJ2FckQORDSqiyQKGOAlIYhmn0379UZM22QS2bYnpoaG5XEHNJIq KpJof6NBRpvxT4wBPVoEKkyO5cvqiRRLxM+fw3Nw= Date: Sat, 31 May 2025 07:49:46 +0200 From: Greg KH To: Igor Korotin Cc: Danilo Krummrich , "Rafael J . Wysocki" , Len Brown , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , linux-acpi@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rust: acpi: add `acpi::DeviceId` abstraction Message-ID: <2025053111-anteater-balsamic-8d01@gregkh> References: <20250530123815.1766726-1-igor.korotin.linux@gmail.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, May 30, 2025 at 05:11:29PM +0100, Igor Korotin wrote: > On Fri, May 30, 2025 at 3:43 PM Danilo Krummrich wrote: > > > > On Fri, May 30, 2025 at 01:38:06PM +0100, Igor Korotin wrote: > > > `acpi::DeviceId` is an abstraction around `struct acpi_device_id`. > > > > > > This is used by subsequent patches, in particular the i2c driver > > > abstractions, to create ACPI device ID tables. > > > > > > Signed-off-by: Igor Korotin > > > > As Greg mentioned it would be nice to see the subsequent patches. > > Ok. There's a little misunderstanding from my side. I'm in the > progress of implementation > of I2C driver abstractions. I2C drivers can use either "of" or "acpi". > The idea was to push this > change first, because: > - It's quite standalone one. > - I'm not sure how much time it will take me to finalize I2C drivers > abstractions. If you don't need it now, then there's no rush to get it merged now :) > If it is not appropriate way of commits, I'll then keep it until all is done. We would like to see it be used first, to ensure that the code is actually correct. thanks, greg k-h