From: Greg KH <gregkh@linuxfoundation.org>
To: Sai Vishnu M <saivishnu725@gmail.com>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
dakr@kernel.org, daniel.almeida@collabora.com, me@kloenk.dev
Subject: Re: [PATCH v3] rust: doc: Clean up formatting in io.rs
Date: Mon, 2 Jun 2025 11:34:18 +0200 [thread overview]
Message-ID: <2025060244-dragster-unknowing-23f0@gregkh> (raw)
In-Reply-To: <20250602083119.17752-2-saivishnu725@gmail.com>
On Mon, Jun 02, 2025 at 02:01:20PM +0530, Sai Vishnu M wrote:
> From: Sai Vishnu M <saivishnu725@gmail.com>
>
> Removed reference to internal variables in the comment of `IoMem`
> This avoids using private variable names in public documentation.
>
> Reported-by: Miguel Ojeda <ojeda@kernel.org>
> Closes: https://github.com/Rust-for-Linux/linux/issues/1167
>
> Signed-off-by: Sai Vishnu M <saivishnu725@gmail.com>
> ---
> rust/kernel/io.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/io.rs b/rust/kernel/io.rs
> index 72d80a6f131e..41404c1e17b3 100644
> --- a/rust/kernel/io.rs
> +++ b/rust/kernel/io.rs
> @@ -43,7 +43,7 @@ pub fn maxsize(&self) -> usize {
> }
> }
>
> -/// IO-mapped memory, starting at the base address @addr and spanning @maxlen bytes.
> +/// IO-mapped memory region.
> ///
> /// The creator (usually a subsystem / bus such as PCI) is responsible for creating the
> /// mapping, performing an additional region request etc.
>
> v1: Used backticks instead of `@` for parameters
> link: https://lore.kernel.org/rust-for-linux/20250530123129.31505-2-saivishnu725@gmail.com/
>
> v2: removed reference to the variable entirely.
> link: https://lore.kernel.org/rust-for-linux/20250601164939.5306-2-saivishnu725@gmail.com/
>
> v3: Moved changelog to commit message. Used the proper parent commit.
All of this "version" text needs to below the first --- line, as the
kernel documentation describes. Putting it down here makes it so the
patch will not apply at all :(
thanks,
greg k-h
next prev parent reply other threads:[~2025-06-02 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 8:31 [PATCH v3] rust: doc: Clean up formatting in io.rs Sai Vishnu M
2025-06-02 9:34 ` Greg KH [this message]
2025-06-02 11:11 ` Sai Vishnu
2025-06-02 11:59 ` Greg KH
2025-06-02 14:18 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025060244-dragster-unknowing-23f0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=me@kloenk.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=saivishnu725@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).