Re: [PATCH] rust: introduce sfile macro for easier code tracing

["gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>]

On Thu, Jun 05, 2025 at 03:02:03PM +0000, Timur Tabi wrote:
> On Thu, 2025-06-05 at 08:07 +0200, Greg KH wrote:
> > > Maybe dbs!(), or just d!() ?
> > 
> > Wait, why are we trying to reimplement the existing pr_dbg() code in a
> > non-standard-way?
> 
> pr_dbg() is not changing.  We're talking about the standard Rust macro dbg!()
> 
> 	https://doc.rust-lang.org/std/macro.dbg.html
> 
> the "problem" with dbg! is that it uses file!(), which outputs the full relative path of the
> source file, which can be quite lengthy.  IOW, I think dbg!() is often too noisy.

And I'm saying "don't use dbg!()" :)

Or, better yet, have it do exactly what pr_dbg() does, as we don't seem
to _have_ to have dbg!() follow anything other than whatever we want it
to follow.

> And we're not talking about changing dbg!() either.  In cases where a given Rust driver has
> multiple source files of the same name but in different paths, you probably want dbg!() to use
> file!().

Again, just do what pr_dbg() does, nothing more and nothing less.

> But in situations where you don't have that file layout, maybe you would prefer the output of my
> sfile!() macro.

Nope, use what pr_dbg() does please.  It will provide the needed file
info if the user asks for it through the standard user/kernel api that
we all know and "love".

thanks,

greg k-h