From: Alexandre Courbot <acourbot@nvidia.com>
To: "Danilo Krummrich" <dakr@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>
Subject: [PATCH v4 0/7] rust: a few common Borrow/BorrowMut implementations
Date: Mon, 16 Jun 2025 12:34:04 +0900 [thread overview]
Message-ID: <20250616-borrow_impls-v4-0-36f9beb3fe6a@nvidia.com> (raw)
The Borrow trait has multiple uses, one of them being to store either an
owned value or a reference to it inside a generic container. This series
adds these implementations for `Box`, `Arc`, `Vec`, and `CString`. I
came across the need for this while experimenting with the scatterlist
abstraction series [1].
In order to avoid an unsightly unsafe block in the doctest, this also
implements `from_bytes_with_nul_mut`. `from_bytes_with_nul` and
`from_bytes_with_nul_unchecked_mut` already exist, so it looked strange
to not have it anyway.
While doing this, I noticed that `from_bytes_with_nul_unchecked_mut` was
not const and not using `transmute`, which I attributed to the absence
of the `const_mut_refs` feature at the time the code was written. I've
tentatively fixed that, but my assumption for doing this might be wrong
so a double-check from someone more familiar with the timeline of this
code would be appreciated.
[1] https://lore.kernel.org/rust-for-linux/DA9JTYA0EQU8.26M0ZX80FOBWY@nvidia.com/
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
Changes in v4:
- Implement `from_bytes_with_nul_mut` to avoid unsafe block in doctest.
- Make `from_bytes_with_nul_unchecked_mut` const and use transmute.
- Use more explicit names for variables in doctests.
- Link to v3: https://lore.kernel.org/r/20250615-borrow_impls-v3-0-621736de7f29@nvidia.com
Changes in v3:
- Remove undeeded first line of doccomments.
- Link to v2: https://lore.kernel.org/r/20250613-borrow_impls-v2-0-6120e1958199@nvidia.com
Changes in v2:
- Rebase on top of v6.16-rc1.
- Improve commit messages. (thanks Benno!)
- Add examples on each impl block.
- Link to v1: https://lore.kernel.org/r/20250601-borrow_impls-v1-0-e1caeb428db4@nvidia.com
---
Alexandre Courbot (7):
rust: alloc: implement `Borrow` and `BorrowMut` for `Vec`
rust: sync: implement `Borrow` and `BorrowMut` for `Arc` types
rust: alloc: implement `Borrow` and `BorrowMut` for `KBox`
rust: str: make `from_bytes_with_nul_unchecked_mut` const
rust: str: use transmute in `from_bytes_with_nul_unchecked_mut`
rust: str: implement `from_bytes_with_nul_mut`
rust: str: implement `Borrow` and `BorrowMut` for `CString`
rust/kernel/alloc/kbox.rs | 57 +++++++++++++++++++++++++++++++
rust/kernel/alloc/kvec.rs | 53 +++++++++++++++++++++++++++++
rust/kernel/str.rs | 86 ++++++++++++++++++++++++++++++++++++++++++-----
rust/kernel/sync/arc.rs | 78 +++++++++++++++++++++++++++++++++++++++++-
4 files changed, 265 insertions(+), 9 deletions(-)
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250531-borrow_impls-8dfef3fcee93
Best regards,
--
Alexandre Courbot <acourbot@nvidia.com>
next reply other threads:[~2025-06-16 3:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 3:34 Alexandre Courbot [this message]
2025-06-16 3:34 ` [PATCH v4 1/7] rust: alloc: implement `Borrow` and `BorrowMut` for `Vec` Alexandre Courbot
2025-06-18 21:45 ` Danilo Krummrich
2025-06-16 3:34 ` [PATCH v4 2/7] rust: sync: implement `Borrow` and `BorrowMut` for `Arc` types Alexandre Courbot
2025-06-29 19:31 ` Miguel Ojeda
2025-06-16 3:34 ` [PATCH v4 3/7] rust: alloc: implement `Borrow` and `BorrowMut` for `KBox` Alexandre Courbot
2025-06-18 21:46 ` Danilo Krummrich
2025-06-16 3:34 ` [PATCH v4 4/7] rust: str: make `from_bytes_with_nul_unchecked_mut` const Alexandre Courbot
2025-06-18 21:08 ` Benno Lossin
2025-06-18 21:16 ` Benno Lossin
2025-06-19 2:32 ` Alexandre Courbot
2025-06-16 3:34 ` [PATCH v4 5/7] rust: str: use transmute in `from_bytes_with_nul_unchecked_mut` Alexandre Courbot
2025-06-16 3:34 ` [PATCH v4 6/7] rust: str: implement `from_bytes_with_nul_mut` Alexandre Courbot
2025-06-16 3:34 ` [PATCH v4 7/7] rust: str: implement `Borrow` and `BorrowMut` for `CString` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616-borrow_impls-v4-0-36f9beb3fe6a@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).