From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tamir Duberstein <tamird@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: miscdevice: remove unnecessary import
Date: Sat, 5 Jul 2025 18:02:34 +0200 [thread overview]
Message-ID: <2025070514-fled-spooky-1d1d@gregkh> (raw)
In-Reply-To: <CAJ-ks9nJhBDQtVUGNJVPmtrK6M8S9_Q+vpVGeSLtspJNaaX+nw@mail.gmail.com>
On Sat, Jul 05, 2025 at 11:56:19AM -0400, Tamir Duberstein wrote:
> On Fri, Jul 4, 2025 at 3:50 PM Tamir Duberstein <tamird@gmail.com> wrote:
> >
> > `kernel::str::CStr` is included in the prelude.
> >
> > Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> > ---
> > rust/kernel/miscdevice.rs | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
> > index 288f40e79906..8309d656088a 100644
> > --- a/rust/kernel/miscdevice.rs
> > +++ b/rust/kernel/miscdevice.rs
> > @@ -17,7 +17,6 @@
> > mm::virt::VmaNew,
> > prelude::*,
> > seq_file::SeqFile,
> > - str::CStr,
> > types::{ForeignOwnable, Opaque},
> > };
> > use core::{marker::PhantomData, mem::MaybeUninit, pin::Pin};
> >
> > ---
> > base-commit: 769e324b66b0d92d04f315d0c45a0f72737c7494
> > change-id: 20250704-cstr-include-miscdevice-4c5cb26a0ece
> >
> > Best regards,
> > --
> > Tamir Duberstein <tamird@gmail.com>
> >
>
> Oops, should have sent this to Greg. Sent
> https://lore.kernel.org/all/20250705-miscdevice-maintainers-v1-1-9a6b67f7602f@gmail.com/
> to make this easier in the future.
Thanks, I just noticed this as well. I'll queue up this, and the
MAINTAINERS update when I get a chance tomorrow or so.
greg k-h
next prev parent reply other threads:[~2025-07-05 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 19:50 [PATCH] rust: miscdevice: remove unnecessary import Tamir Duberstein
2025-07-05 15:56 ` Tamir Duberstein
2025-07-05 16:02 ` Greg Kroah-Hartman [this message]
2025-07-07 7:23 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025070514-fled-spooky-1d1d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).