* [PATCH] rust: miscdevice: remove unnecessary import
@ 2025-07-04 19:50 Tamir Duberstein
2025-07-05 15:56 ` Tamir Duberstein
2025-07-07 7:23 ` Alice Ryhl
0 siblings, 2 replies; 4+ messages in thread
From: Tamir Duberstein @ 2025-07-04 19:50 UTC (permalink / raw)
To: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, Danilo Krummrich
Cc: rust-for-linux, linux-kernel, Tamir Duberstein
`kernel::str::CStr` is included in the prelude.
Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
rust/kernel/miscdevice.rs | 1 -
1 file changed, 1 deletion(-)
diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
index 288f40e79906..8309d656088a 100644
--- a/rust/kernel/miscdevice.rs
+++ b/rust/kernel/miscdevice.rs
@@ -17,7 +17,6 @@
mm::virt::VmaNew,
prelude::*,
seq_file::SeqFile,
- str::CStr,
types::{ForeignOwnable, Opaque},
};
use core::{marker::PhantomData, mem::MaybeUninit, pin::Pin};
---
base-commit: 769e324b66b0d92d04f315d0c45a0f72737c7494
change-id: 20250704-cstr-include-miscdevice-4c5cb26a0ece
Best regards,
--
Tamir Duberstein <tamird@gmail.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rust: miscdevice: remove unnecessary import
2025-07-04 19:50 [PATCH] rust: miscdevice: remove unnecessary import Tamir Duberstein
@ 2025-07-05 15:56 ` Tamir Duberstein
2025-07-05 16:02 ` Greg Kroah-Hartman
2025-07-07 7:23 ` Alice Ryhl
1 sibling, 1 reply; 4+ messages in thread
From: Tamir Duberstein @ 2025-07-05 15:56 UTC (permalink / raw)
To: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, Danilo Krummrich, Greg Kroah-Hartman
Cc: rust-for-linux, linux-kernel
On Fri, Jul 4, 2025 at 3:50 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> `kernel::str::CStr` is included in the prelude.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> ---
> rust/kernel/miscdevice.rs | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
> index 288f40e79906..8309d656088a 100644
> --- a/rust/kernel/miscdevice.rs
> +++ b/rust/kernel/miscdevice.rs
> @@ -17,7 +17,6 @@
> mm::virt::VmaNew,
> prelude::*,
> seq_file::SeqFile,
> - str::CStr,
> types::{ForeignOwnable, Opaque},
> };
> use core::{marker::PhantomData, mem::MaybeUninit, pin::Pin};
>
> ---
> base-commit: 769e324b66b0d92d04f315d0c45a0f72737c7494
> change-id: 20250704-cstr-include-miscdevice-4c5cb26a0ece
>
> Best regards,
> --
> Tamir Duberstein <tamird@gmail.com>
>
Oops, should have sent this to Greg. Sent
https://lore.kernel.org/all/20250705-miscdevice-maintainers-v1-1-9a6b67f7602f@gmail.com/
to make this easier in the future.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rust: miscdevice: remove unnecessary import
2025-07-05 15:56 ` Tamir Duberstein
@ 2025-07-05 16:02 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2025-07-05 16:02 UTC (permalink / raw)
To: Tamir Duberstein
Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, Danilo Krummrich, rust-for-linux, linux-kernel
On Sat, Jul 05, 2025 at 11:56:19AM -0400, Tamir Duberstein wrote:
> On Fri, Jul 4, 2025 at 3:50 PM Tamir Duberstein <tamird@gmail.com> wrote:
> >
> > `kernel::str::CStr` is included in the prelude.
> >
> > Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> > ---
> > rust/kernel/miscdevice.rs | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
> > index 288f40e79906..8309d656088a 100644
> > --- a/rust/kernel/miscdevice.rs
> > +++ b/rust/kernel/miscdevice.rs
> > @@ -17,7 +17,6 @@
> > mm::virt::VmaNew,
> > prelude::*,
> > seq_file::SeqFile,
> > - str::CStr,
> > types::{ForeignOwnable, Opaque},
> > };
> > use core::{marker::PhantomData, mem::MaybeUninit, pin::Pin};
> >
> > ---
> > base-commit: 769e324b66b0d92d04f315d0c45a0f72737c7494
> > change-id: 20250704-cstr-include-miscdevice-4c5cb26a0ece
> >
> > Best regards,
> > --
> > Tamir Duberstein <tamird@gmail.com>
> >
>
> Oops, should have sent this to Greg. Sent
> https://lore.kernel.org/all/20250705-miscdevice-maintainers-v1-1-9a6b67f7602f@gmail.com/
> to make this easier in the future.
Thanks, I just noticed this as well. I'll queue up this, and the
MAINTAINERS update when I get a chance tomorrow or so.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rust: miscdevice: remove unnecessary import
2025-07-04 19:50 [PATCH] rust: miscdevice: remove unnecessary import Tamir Duberstein
2025-07-05 15:56 ` Tamir Duberstein
@ 2025-07-07 7:23 ` Alice Ryhl
1 sibling, 0 replies; 4+ messages in thread
From: Alice Ryhl @ 2025-07-07 7:23 UTC (permalink / raw)
To: Tamir Duberstein
Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Trevor Gross, Danilo Krummrich, rust-for-linux, linux-kernel
On Fri, Jul 04, 2025 at 03:50:11PM -0400, Tamir Duberstein wrote:
> `kernel::str::CStr` is included in the prelude.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-07 7:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-04 19:50 [PATCH] rust: miscdevice: remove unnecessary import Tamir Duberstein
2025-07-05 15:56 ` Tamir Duberstein
2025-07-05 16:02 ` Greg Kroah-Hartman
2025-07-07 7:23 ` Alice Ryhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).