[PATCH 4/7] rust: fs: update ARef and AlwaysRefCounted imports from sync::aref

[PATCH 4/7] rust: fs: update ARef and AlwaysRefCounted imports from sync::aref

[Shankari Anand]

Update call sites in the fs subsystem to import `ARef` and
`AlwaysRefCounted` from `sync::aref` instead of `types`.

This aligns with the ongoing effort to move `ARef` and
`AlwaysRefCounted` to sync.

Suggested-by: Benno Lossin <lossin@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1173
Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
---
It part of a subsystem-wise split series, as suggested in:
https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u
This split series is intended to ease review and subsystem-level maintenance.

The original moving patch is here:
https://lore.kernel.org/rust-for-linux/20250625111133.698481-1-shankari.ak0208@gmail.com/

Gradually the re-export from types.rs will be eliminated in the
future cycle.
---
 rust/kernel/fs/file.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/rust/kernel/fs/file.rs b/rust/kernel/fs/file.rs
index 35fd5db35c46..18cf579d3312 100644
--- a/rust/kernel/fs/file.rs
+++ b/rust/kernel/fs/file.rs
@@ -11,7 +11,8 @@
     bindings,
     cred::Credential,
     error::{code::*, Error, Result},
-    types::{ARef, AlwaysRefCounted, NotThreadSafe, Opaque},
+    sync::aref::{ARef, AlwaysRefCounted},
+    types::{NotThreadSafe, Opaque},
 };
 use core::ptr;
 
-- 
2.34.1

Re: [PATCH 4/7] rust: fs: update ARef and AlwaysRefCounted imports from sync::aref

[Shankari Anand]

On Wed, Jul 16, 2025 at 02:48:27PM +0530, Shankari Anand wrote:
> Update call sites in the fs subsystem to import `ARef` and
> `AlwaysRefCounted` from `sync::aref` instead of `types`.
> 
> This aligns with the ongoing effort to move `ARef` and
> `AlwaysRefCounted` to sync.
> 
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1173
> Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
> ---
> It part of a subsystem-wise split series, as suggested in:
> https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u
> This split series is intended to ease review and subsystem-level maintenance.
> 
> The original moving patch is here:
> https://lore.kernel.org/rust-for-linux/20250625111133.698481-1-shankari.ak0208@gmail.com/
> 
> Gradually the re-export from types.rs will be eliminated in the
> future cycle.
> ---
>  rust/kernel/fs/file.rs | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/rust/kernel/fs/file.rs b/rust/kernel/fs/file.rs
> index 35fd5db35c46..18cf579d3312 100644
> --- a/rust/kernel/fs/file.rs
> +++ b/rust/kernel/fs/file.rs
> @@ -11,7 +11,8 @@
>      bindings,
>      cred::Credential,
>      error::{code::*, Error, Result},
> -    types::{ARef, AlwaysRefCounted, NotThreadSafe, Opaque},
> +    sync::aref::{ARef, AlwaysRefCounted},
> +    types::{NotThreadSafe, Opaque},
>  };
>  use core::ptr;
>  
> -- 
> 2.34.1
> 

Hello, can this be picked for review?

The initial patch which moves ARef and AlwaysRefCounted to sync/aref.rs is upstream (commit 07dad44aa9a93) [1]

Thanks,
Shankari

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440

Re: [PATCH 4/7] rust: fs: update ARef and AlwaysRefCounted imports from sync::aref

[Alice Ryhl]

On Thu, Aug 14, 2025 at 12:56:21AM +0530, Shankari Anand wrote:
> On Wed, Jul 16, 2025 at 02:48:27PM +0530, Shankari Anand wrote:
> > Update call sites in the fs subsystem to import `ARef` and
> > `AlwaysRefCounted` from `sync::aref` instead of `types`.
> > 
> > This aligns with the ongoing effort to move `ARef` and
> > `AlwaysRefCounted` to sync.
> > 
> > Suggested-by: Benno Lossin <lossin@kernel.org>
> > Link: https://github.com/Rust-for-Linux/linux/issues/1173
> > Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
> > ---
> > It part of a subsystem-wise split series, as suggested in:
> > https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u
> > This split series is intended to ease review and subsystem-level maintenance.
> > 
> > The original moving patch is here:
> > https://lore.kernel.org/rust-for-linux/20250625111133.698481-1-shankari.ak0208@gmail.com/
> > 
> > Gradually the re-export from types.rs will be eliminated in the
> > future cycle.
> > ---
> >  rust/kernel/fs/file.rs | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/rust/kernel/fs/file.rs b/rust/kernel/fs/file.rs
> > index 35fd5db35c46..18cf579d3312 100644
> > --- a/rust/kernel/fs/file.rs
> > +++ b/rust/kernel/fs/file.rs
> > @@ -11,7 +11,8 @@
> >      bindings,
> >      cred::Credential,
> >      error::{code::*, Error, Result},
> > -    types::{ARef, AlwaysRefCounted, NotThreadSafe, Opaque},
> > +    sync::aref::{ARef, AlwaysRefCounted},
> > +    types::{NotThreadSafe, Opaque},
> >  };
> >  use core::ptr;
> >  
> > -- 
> > 2.34.1
> > 
> 
> Hello, can this be picked for review?
> 
> The initial patch which moves ARef and AlwaysRefCounted to sync/aref.rs is upstream (commit 07dad44aa9a93) [1]
> 
> Thanks,
> Shankari
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440

Christian maintains rust/kernel/fs, so could you resend this patch with

	Christian Brauner <brauner@kernel.org>

as a recipient?

Feel free to add this when you resend:
Acked-by: Alice Ryhl <aliceryhl@google.com>

Re: [PATCH 4/7] rust: fs: update ARef and AlwaysRefCounted imports from sync::aref

[Shankari Anand]

On Thu, Aug 14, 2025 at 08:12:03AM +0000, Alice Ryhl wrote:
> On Thu, Aug 14, 2025 at 12:56:21AM +0530, Shankari Anand wrote:
> > 
> > Hello, can this be picked for review?
> > 
> > The initial patch which moves ARef and AlwaysRefCounted to sync/aref.rs is upstream (commit 07dad44aa9a93) [1]
> > 
> > Thanks,
> > Shankari
> > 
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440
> 
> Christian maintains rust/kernel/fs, so could you resend this patch with
> 
> 	Christian Brauner <brauner@kernel.org>
> 
> as a recipient?
> 
> Feel free to add this when you resend:
> Acked-by: Alice Ryhl <aliceryhl@google.com>
> 

Done, its here [1]

Thanks,
Shankari

[1] https://lore.kernel.org/rust-for-linux/20250814100101.304408-1-shankari.ak0208@gmail.com/T/#u