From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67960157493; Wed, 16 Jul 2025 09:16:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752657393; cv=none; b=HkWCOWgzAfQiOc1lW1fcsPOpDejQ8g7k2UYBYbZ8+0D88BBjzfCw9vICDCnHo/hL89cyv0DQJERrIuMHcheKToiPy5yYkulgLnpmKt7msLPdzKfbGOOPjDGAmsKQS7NYCTw3YtfRgxdxdtEGwtEDt37E2cpV9h54mwzj1uwfoI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752657393; c=relaxed/simple; bh=Hfea+Wf59XZhqO9zfMH1UF/iDdhqNgx3KK5CietkH3k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QA4hQdiZehtAxLvgCgMMzbVmTBy3yIYKaiPV1TOZDGow/p7Ms0HqierLsNRvOBo4XCsyXffvWJvf8VG/EYDBVMpx61G8jkZ8jmUWhzEcRYOX3W8oT3ikWspo8h4WjuVGlWd6kCKb+Qatc0feiFRW9MuFurIt5CQyZHHINoypXGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=y56dsiQ1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="y56dsiQ1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EEDFC4CEF0; Wed, 16 Jul 2025 09:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752657393; bh=Hfea+Wf59XZhqO9zfMH1UF/iDdhqNgx3KK5CietkH3k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=y56dsiQ1PjVkVp1XJED61755uulFZ4+msW57aAe4eHvbg/nbszwlABUifs2B5Bb+8 Kym9V/L7DI+8IZKY0ud0kFnECSsJpabjgBuXJRe18zsopmP8z9ALihS03C+rVaoqJu BtBw3HNu3r8//9sAlIvmBxfsKQIIpVhM/OF5cimw= Date: Wed, 16 Jul 2025 11:16:30 +0200 From: Greg Kroah-Hartman To: Alice Ryhl Cc: Danilo Krummrich , Dave Ertman , Ira Weiny , Leon Romanovsky , Miguel Ojeda , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , Thomas Gleixner , Peter Zijlstra , "Rafael J. Wysocki" , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , FUJITA Tomonori , Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v2 1/2] device: rust: rename Device::as_ref() to Device::from_raw() Message-ID: <2025071622-recast-posing-ce98@gregkh> References: <20250711-device-as-ref-v2-0-1b16ab6402d7@google.com> <20250711-device-as-ref-v2-1-1b16ab6402d7@google.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250711-device-as-ref-v2-1-1b16ab6402d7@google.com> On Fri, Jul 11, 2025 at 08:04:37AM +0000, Alice Ryhl wrote: > The prefix as_* should not be used for a constructor. Constructors > usually use the prefix from_* instead. > > Some prior art in the stdlib: Box::from_raw, CString::from_raw, > Rc::from_raw, Arc::from_raw, Waker::from_raw, File::from_raw_fd. > > There is also prior art in the kernel crate: cpufreq::Policy::from_raw, > fs::File::from_raw_file, Kuid::from_raw, ARef::from_raw, > SeqFile::from_raw, VmaNew::from_raw, Io::from_raw. > > Link: https://lore.kernel.org/r/aCd8D5IA0RXZvtcv@pollux > Signed-off-by: Alice Ryhl Reviewed-by: Greg Kroah-Hartman