From: Lyude Paul <lyude@redhat.com>
To: rust-for-linux@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Boqun Feng <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org,
Andreas Hindborg <a.hindborg@kernel.org>,
FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: "Frederic Weisbecker" <frederic@kernel.org>,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
"John Stultz" <jstultz@google.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Subject: [PATCH v6 1/7] rust: hrtimer: Document the return value for HrTimerHandle::cancel()
Date: Thu, 24 Jul 2025 14:49:27 -0400 [thread overview]
Message-ID: <20250724185236.556482-2-lyude@redhat.com> (raw)
In-Reply-To: <20250724185236.556482-1-lyude@redhat.com>
Just a drive-by fix I noticed: we don't actually document what the return
value from cancel() does, so do that.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Andreas Hindborg <a.hindborg@kernel.org>
---
V4:
* Reword to "Returns `true` if the timer was running."
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
rust/kernel/time/hrtimer.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/rust/kernel/time/hrtimer.rs b/rust/kernel/time/hrtimer.rs
index 144e3b57cc780..6bfc0223f4f57 100644
--- a/rust/kernel/time/hrtimer.rs
+++ b/rust/kernel/time/hrtimer.rs
@@ -324,6 +324,8 @@ pub unsafe trait HrTimerHandle {
/// Note that the timer might be started by a concurrent start operation. If
/// so, the timer might not be in the **stopped** state when this function
/// returns.
+ ///
+ /// Returns `true` if the timer was running.
fn cancel(&mut self) -> bool;
}
--
2.50.0
next prev parent reply other threads:[~2025-07-24 18:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9bH1XUWr5rhB6Ke8MMK7YgWFGkRpE1LlW65AAIBFM3aTmjQgRgZq76rrlhRxLc65lzsr-yAHGZMum9kee-165w==@protonmail.internalid>
2025-07-24 18:49 ` [PATCH v6 0/7] rust/hrtimer: Various hrtimer + time additions Lyude Paul
2025-07-24 18:49 ` Lyude Paul [this message]
2025-07-24 18:49 ` [PATCH v6 2/7] rust: hrtimer: Add HrTimerInstant Lyude Paul
2025-07-24 18:49 ` [PATCH v6 3/7] rust: hrtimer: Add HrTimer::raw_forward() and forward() Lyude Paul
2025-07-25 14:16 ` Daniel Almeida
2025-08-07 13:01 ` Andreas Hindborg
2025-08-07 18:39 ` Andreas Hindborg
2025-07-24 18:49 ` [PATCH v6 4/7] rust: hrtimer: Add HrTimerCallbackContext and ::forward() Lyude Paul
2025-08-08 8:07 ` Andreas Hindborg
2025-07-24 18:49 ` [PATCH v6 5/7] rust: hrtimer: Add forward_now() to HrTimer and HrTimerCallbackContext Lyude Paul
2025-07-25 14:25 ` Daniel Almeida
2025-07-25 20:03 ` Lyude Paul
2025-08-08 8:14 ` Andreas Hindborg
2025-07-24 18:49 ` [PATCH v6 6/7] rust: time: Add Instant::from_nanos() Lyude Paul
2025-07-25 14:12 ` Daniel Almeida
2025-07-28 19:07 ` Lyude Paul
2025-08-08 8:19 ` Andreas Hindborg
2025-07-24 18:49 ` [PATCH v6 7/7] rust: hrtimer: Add HrTimer::expires() Lyude Paul
2025-08-08 8:24 ` Andreas Hindborg
2025-07-25 14:11 ` [PATCH v6 0/7] rust/hrtimer: Various hrtimer + time additions Daniel Almeida
2025-08-08 8:26 ` Andreas Hindborg
2025-08-13 19:01 ` Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724185236.556482-2-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).