From: Lyude Paul <lyude@redhat.com>
To: rust-for-linux@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Boqun Feng <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org,
Andreas Hindborg <a.hindborg@kernel.org>,
FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: "Frederic Weisbecker" <frederic@kernel.org>,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
"John Stultz" <jstultz@google.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Subject: [PATCH v6 7/7] rust: hrtimer: Add HrTimer::expires()
Date: Thu, 24 Jul 2025 14:49:33 -0400 [thread overview]
Message-ID: <20250724185236.556482-8-lyude@redhat.com> (raw)
In-Reply-To: <20250724185236.556482-1-lyude@redhat.com>
Add a simple callback for retrieving the current expiry time for an
HrTimer. In rvkms, we use the HrTimer expiry value in order to calculate
the approximate vblank timestamp during each emulated vblank interrupt.
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
rust/kernel/time.rs | 1 -
rust/kernel/time/hrtimer.rs | 23 +++++++++++++++++++++++
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/rust/kernel/time.rs b/rust/kernel/time.rs
index 75088d080b834..6d6e71710ebdc 100644
--- a/rust/kernel/time.rs
+++ b/rust/kernel/time.rs
@@ -211,7 +211,6 @@ pub(crate) fn as_nanos(&self) -> i64 {
/// # Safety
///
/// The caller promises that `nanos` is in the range from 0 to `KTIME_MAX`.
- #[expect(unused)]
#[inline]
pub(crate) unsafe fn from_nanos(nanos: i64) -> Self {
debug_assert!(nanos >= 0);
diff --git a/rust/kernel/time/hrtimer.rs b/rust/kernel/time/hrtimer.rs
index fa5a3ae81723b..2d52a1b3b39a0 100644
--- a/rust/kernel/time/hrtimer.rs
+++ b/rust/kernel/time/hrtimer.rs
@@ -223,6 +223,29 @@ pub fn forward_now(self: Pin<&mut Self>, interval: Delta) -> u64
{
self.forward(HrTimerInstant::<T>::now(), interval)
}
+
+ /// Return the time expiry for this [`HrTimer`].
+ ///
+ /// This value should only be used as a snapshot, as the actual expiry time could change after
+ /// this function is called.
+ pub fn expires(&self) -> HrTimerInstant<T>
+ where
+ T: HasHrTimer<T>,
+ {
+ // SAFETY: `self` is an immutable reference and thus always points to a valid `HrTimer`.
+ let c_timer_ptr = unsafe { HrTimer::raw_get(self) };
+
+ // SAFETY:
+ // - `node.expires` is a ktime_t, so it must be within the range of `0` to `KTIME_MAX`.
+ // - There's no actual locking here, a racy read is fine and expected
+ unsafe {
+ Instant::from_nanos(
+ // This `read_volatile` is intended to correspond to a READ_ONCE call.
+ // FIXME(read_once): Replace with `read_once` when available on the Rust side.
+ core::ptr::read_volatile(&raw const ((*c_timer_ptr).node.expires)),
+ )
+ }
+ }
}
/// Implemented by pointer types that point to structs that contain a [`HrTimer`].
--
2.50.0
next prev parent reply other threads:[~2025-07-24 18:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9bH1XUWr5rhB6Ke8MMK7YgWFGkRpE1LlW65AAIBFM3aTmjQgRgZq76rrlhRxLc65lzsr-yAHGZMum9kee-165w==@protonmail.internalid>
2025-07-24 18:49 ` [PATCH v6 0/7] rust/hrtimer: Various hrtimer + time additions Lyude Paul
2025-07-24 18:49 ` [PATCH v6 1/7] rust: hrtimer: Document the return value for HrTimerHandle::cancel() Lyude Paul
2025-07-24 18:49 ` [PATCH v6 2/7] rust: hrtimer: Add HrTimerInstant Lyude Paul
2025-07-24 18:49 ` [PATCH v6 3/7] rust: hrtimer: Add HrTimer::raw_forward() and forward() Lyude Paul
2025-07-25 14:16 ` Daniel Almeida
2025-08-07 13:01 ` Andreas Hindborg
2025-08-07 18:39 ` Andreas Hindborg
2025-07-24 18:49 ` [PATCH v6 4/7] rust: hrtimer: Add HrTimerCallbackContext and ::forward() Lyude Paul
2025-08-08 8:07 ` Andreas Hindborg
2025-07-24 18:49 ` [PATCH v6 5/7] rust: hrtimer: Add forward_now() to HrTimer and HrTimerCallbackContext Lyude Paul
2025-07-25 14:25 ` Daniel Almeida
2025-07-25 20:03 ` Lyude Paul
2025-08-08 8:14 ` Andreas Hindborg
2025-07-24 18:49 ` [PATCH v6 6/7] rust: time: Add Instant::from_nanos() Lyude Paul
2025-07-25 14:12 ` Daniel Almeida
2025-07-28 19:07 ` Lyude Paul
2025-08-08 8:19 ` Andreas Hindborg
2025-07-24 18:49 ` Lyude Paul [this message]
2025-08-08 8:24 ` [PATCH v6 7/7] rust: hrtimer: Add HrTimer::expires() Andreas Hindborg
2025-07-25 14:11 ` [PATCH v6 0/7] rust/hrtimer: Various hrtimer + time additions Daniel Almeida
2025-08-08 8:26 ` Andreas Hindborg
2025-08-13 19:01 ` Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724185236.556482-8-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).