From: Greg KH <gregkh@linuxfoundation.org>
To: trev <trev@trevrosa.dev>
Cc: alex.gaynor@gmail.com, ojeda@kernel.org, rafael@kernel.org,
dakr@kernel.org, arlied@gmail.com,
"simona@ffwll.ch" <simona@ffwll.ch>,
"aliceryhl@google.com" <aliceryhl@google.com>,
vireshk@kernel.org, nm@ti.com, sboyd@kernel.org,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
brauner@kernel.org, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, tmgross@umich.edu,
rust-for-linux@vger.kernel.org, david.m.ertman@intel.com,
ira.weiny@intel.com, leon@kernel.org, lorenzo.stoakes@oracle.com,
Liam.Howlett@oracle.com,
"bhelgaas@google.com" <bhelgaas@google.com>,
"kwilczynski@kernel.org" <kwilczynski@kernel.org>,
jack@suse.cz
Subject: Re: [PATCH] rust: aref: make `AlwaysRefCounted::inc_ref` an associated function
Date: Tue, 12 Aug 2025 14:43:35 +0200 [thread overview]
Message-ID: <2025081204-cheesy-scariness-0074@gregkh> (raw)
In-Reply-To: <CACvsgUDP8rX4evCbaNC1MTy56qWH655Cc2bOLuryUxfP-o4_4g@mail.gmail.com>
On Tue, Aug 12, 2025 at 08:24:19PM +0800, trev wrote:
> On Tue, Aug 12, 2025 at 7:56 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Aug 12, 2025 at 07:09:11PM +0800, trev wrote:
> > > `AlwaysRefCounted::inc_ref` is a function that shouldn't be called lightly.
> > >
> > > To prevent accidentally calling it, `inc_ref` is now changed to be an
> > > associated function.
> > >
> > > Modifies all `AlwaysRefCounted` implementors to work with this change.
> > >
> > > Suggested-by: Benno Lossin <lossin@kernel.org>
> > > Closes: https://github.com/Rust-for-Linux/linux/issues/1177
> > > Signed-off-by: Trevor Chan <trev@trevrosa.dev>
> >
> > This doesn't match up with your "From:" line :(
>
> Sorry, my bad, what should I do to fix it?
>
Fix your email client or whatever tool you used to send this and send a
version 2 patch in a few days after others have had a bit of time to
also review it.
thanks,
greg k-h
next prev parent reply other threads:[~2025-08-12 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 11:09 [PATCH] rust: aref: make `AlwaysRefCounted::inc_ref` an associated function trev
2025-08-12 11:56 ` Greg KH
2025-08-12 12:24 ` trev
2025-08-12 12:43 ` Greg KH [this message]
2025-08-12 12:49 ` Miguel Ojeda
2025-08-12 12:58 ` Trevor Chan
2025-08-12 17:00 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025081204-cheesy-scariness-0074@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=arlied@gmail.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brauner@kernel.org \
--cc=dakr@kernel.org \
--cc=david.m.ertman@intel.com \
--cc=gary@garyguo.net \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=kwilczynski@kernel.org \
--cc=leon@kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=nm@ti.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=trev@trevrosa.dev \
--cc=vireshk@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox