From: Greg KH <gregkh@linuxfoundation.org>
To: Abhinav Ananthu <abhinav.ogl@gmail.com>
Cc: david.m.ertman@intel.com, ira.weiny@intel.com, leon@kernel.org,
ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
dakr@kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: auxiliary: Use `c_` types from prelude instead of
Date: Tue, 12 Aug 2025 10:27:57 +0200 [thread overview]
Message-ID: <2025081245-chubby-strep-1181@gregkh> (raw)
In-Reply-To: <20250812075109.4099-1-abhinav.ogl@gmail.com>
On Tue, Aug 12, 2025 at 01:21:10PM +0530, Abhinav Ananthu wrote:
> Update auxiliary FFI callback signatures to reference the `c_` types
> provided by the kernel prelude, rather than accessing them via
> `kernel::ffi::`.
>
> Signed-off-by: Abhinav Ananthu <abhinav.ogl@gmail.com>
> ---
> rust/kernel/auxiliary.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/auxiliary.rs b/rust/kernel/auxiliary.rs
> index d2cfe1eeefb6..030e31333689 100644
> --- a/rust/kernel/auxiliary.rs
> +++ b/rust/kernel/auxiliary.rs
> @@ -56,7 +56,7 @@ impl<T: Driver + 'static> Adapter<T> {
> extern "C" fn probe_callback(
> adev: *mut bindings::auxiliary_device,
> id: *const bindings::auxiliary_device_id,
> - ) -> kernel::ffi::c_int {
> + ) -> c_int {
> // SAFETY: The auxiliary bus only ever calls the probe callback with a valid pointer to a
> // `struct auxiliary_device`.
> //
> --
> 2.34.1
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2025-08-12 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 7:51 [PATCH] rust: auxiliary: Use `c_` types from prelude instead of Abhinav Ananthu
2025-08-12 8:27 ` Greg KH [this message]
2025-08-12 17:21 ` Danilo Krummrich
2025-08-15 18:08 ` Danilo Krummrich
-- strict thread matches above, loose matches on Subject: below --
2025-08-12 3:54 herculoxz
2025-08-12 6:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025081245-chubby-strep-1181@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@kernel.org \
--cc=abhinav.ogl@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=david.m.ertman@intel.com \
--cc=gary@garyguo.net \
--cc=ira.weiny@intel.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).