From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Areej <areejhamid8560@gmail.com>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Tamir Duberstein" <tamird@gmail.com>,
"Xiangfei Ding" <dingxiangfei2009@gmail.com>
Subject: Re: [PATCH] rust: lib: add if_cfg! macro for conditional compilation
Date: Thu, 14 Aug 2025 07:55:46 +0200 [thread overview]
Message-ID: <2025081411-skimming-roundworm-dc2b@gregkh> (raw)
In-Reply-To: <20250813203826.3145553-1-areejhamid8560@gmail.com>
On Thu, Aug 14, 2025 at 01:38:26AM +0500, Areej wrote:
> Add a new if_cfg! macro to simplify conditional compilation using
> cfg attributes. This macro expands to paired #[cfg(cond)] and
> #[cfg(not(cond))] blocks, allowing compile-time selection between
> code branches in both expression and statement contexts.
Nit, trailing whitespace in your text :(
>
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1183
> Signed-off-by: Areej Hamid <areejhamid8560@gmail.com>
From: line does not match up with this text :(
thanks,
greg k-h
next prev parent reply other threads:[~2025-08-14 5:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 20:38 [PATCH] rust: lib: add if_cfg! macro for conditional compilation Areej
2025-08-13 20:59 ` Thomas Weißschuh
[not found] ` <CAMjM9+b60ate7cpHfm6uPHFauuYyPA1KcukqMgLjCQcC_zak+A@mail.gmail.com>
2025-08-14 5:07 ` Thomas Weißschuh
2025-08-14 16:22 ` [PATCH v2] " Areej Hamid
2025-08-14 18:49 ` Miguel Ojeda
2025-08-14 18:54 ` Miguel Ojeda
2025-08-15 8:16 ` Benno Lossin
2025-08-14 5:55 ` Greg Kroah-Hartman [this message]
[not found] <CAMjM9+aqeh4iEyfAKidYig_5zEV-CMZuJpmtzhqjKHiVTiBpYA@mail.gmail.com>
2025-08-12 21:37 ` [PATCH] " Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025081411-skimming-roundworm-dc2b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=areejhamid8560@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dingxiangfei2009@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).