rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] pin-init sync v6.18
@ 2025-09-05 13:33 Benno Lossin
  2025-09-05 13:33 ` [PATCH 1/2] rust: pin-init: examples: error: use `Error` in `fn main()` Benno Lossin
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Benno Lossin @ 2025-09-05 13:33 UTC (permalink / raw)
  To: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
	Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
	Trevor Gross, Danilo Krummrich
  Cc: rust-for-linux

Some very small changes coming from CI fixes & a readme update. These
changes are already merged upstream & originate from these pull
requests:

* https://github.com/Rust-for-Linux/pin-init/pull/79
* https://github.com/Rust-for-Linux/pin-init/pull/80
* https://github.com/Rust-for-Linux/pin-init/pull/81
* https://github.com/Rust-for-Linux/pin-init/pull/82

Note that 80 & 82 only changed CI, test & cargo files that aren't
included in the kernel tree.

Benno Lossin (2):
  rust: pin-init: examples: error: use `Error` in `fn main()`
  rust: pin-init: README: add information banner on the rename to
    `pin-init`

 rust/pin-init/README.md         | 12 ++++++++++++
 rust/pin-init/examples/error.rs |  4 +++-
 2 files changed, 15 insertions(+), 1 deletion(-)


base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
-- 
2.50.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] rust: pin-init: examples: error: use `Error` in `fn main()`
  2025-09-05 13:33 [PATCH 0/2] pin-init sync v6.18 Benno Lossin
@ 2025-09-05 13:33 ` Benno Lossin
  2025-09-05 13:33 ` [PATCH 2/2] rust: pin-init: README: add information banner on the rename to `pin-init` Benno Lossin
  2025-09-11 21:34 ` [PATCH 0/2] pin-init sync v6.18 Benno Lossin
  2 siblings, 0 replies; 5+ messages in thread
From: Benno Lossin @ 2025-09-05 13:33 UTC (permalink / raw)
  To: Benno Lossin, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
	Björn Roy Baron, Andreas Hindborg, Alice Ryhl, Trevor Gross,
	Danilo Krummrich, Fiona Behrens
  Cc: rust-for-linux, linux-kernel

When running this example with no cargo features enabled, the compiler
warns on 1.89:

  error: struct `Error` is never constructed
    --> examples/error.rs:11:12
     |
  11 | pub struct Error;
     |            ^^^^^
     |
     = note: `-D dead-code` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(dead_code)]`

Thus use the error in the main function to avoid this warning.

Link: https://github.com/Rust-for-Linux/pin-init/pull/79/commits/1f4f749b5b151d0dfdf9672af323e39a33e920fd
Signed-off-by: Benno Lossin <lossin@kernel.org>
---
 rust/pin-init/examples/error.rs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/rust/pin-init/examples/error.rs b/rust/pin-init/examples/error.rs
index e0cc258746ce..8f4e135eb8ba 100644
--- a/rust/pin-init/examples/error.rs
+++ b/rust/pin-init/examples/error.rs
@@ -24,4 +24,6 @@ fn from(_: AllocError) -> Self {
 }
 
 #[allow(dead_code)]
-fn main() {}
+fn main() {
+    let _ = Error;
+}

base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] rust: pin-init: README: add information banner on the rename to `pin-init`
  2025-09-05 13:33 [PATCH 0/2] pin-init sync v6.18 Benno Lossin
  2025-09-05 13:33 ` [PATCH 1/2] rust: pin-init: examples: error: use `Error` in `fn main()` Benno Lossin
@ 2025-09-05 13:33 ` Benno Lossin
  2025-09-05 13:40   ` Alice Ryhl
  2025-09-11 21:34 ` [PATCH 0/2] pin-init sync v6.18 Benno Lossin
  2 siblings, 1 reply; 5+ messages in thread
From: Benno Lossin @ 2025-09-05 13:33 UTC (permalink / raw)
  To: Benno Lossin, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
	Björn Roy Baron, Andreas Hindborg, Alice Ryhl, Trevor Gross,
	Danilo Krummrich
  Cc: rust-for-linux, linux-kernel

Link: https://github.com/Rust-for-Linux/pin-init/pull/81/commits/3cf4658e2db96b4a6b26db9478250de2ffcfa1fe
Signed-off-by: Benno Lossin <lossin@kernel.org>
---
 rust/pin-init/README.md | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/rust/pin-init/README.md b/rust/pin-init/README.md
index a4c01a8d78b2..723e275445d4 100644
--- a/rust/pin-init/README.md
+++ b/rust/pin-init/README.md
@@ -6,6 +6,18 @@
 ![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/Rust-for-Linux/pin-init/test.yml)
 # `pin-init`
 
+> [!NOTE]
+> 
+> This crate was originally named [`pinned-init`], but the migration to
+> `pin-init` is not yet complete. The `legcay` branch contains the current
+> version of the `pinned-init` crate & the `main` branch already incorporates
+> the rename to `pin-init`.
+>
+> There are still some changes needed on the kernel side before the migration
+> can be completed.
+
+[`pinned-init`]: https://crates.io/crates/pinned-init
+
 <!-- cargo-rdme start -->
 
 Library to safely and fallibly initialize pinned `struct`s using in-place constructors.
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] rust: pin-init: README: add information banner on the rename to `pin-init`
  2025-09-05 13:33 ` [PATCH 2/2] rust: pin-init: README: add information banner on the rename to `pin-init` Benno Lossin
@ 2025-09-05 13:40   ` Alice Ryhl
  0 siblings, 0 replies; 5+ messages in thread
From: Alice Ryhl @ 2025-09-05 13:40 UTC (permalink / raw)
  To: Benno Lossin
  Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
	Björn Roy Baron, Andreas Hindborg, Trevor Gross,
	Danilo Krummrich, rust-for-linux, linux-kernel

On Fri, Sep 5, 2025 at 3:34 PM Benno Lossin <lossin@kernel.org> wrote:
>
> Link: https://github.com/Rust-for-Linux/pin-init/pull/81/commits/3cf4658e2db96b4a6b26db9478250de2ffcfa1fe
> Signed-off-by: Benno Lossin <lossin@kernel.org>
> ---
>  rust/pin-init/README.md | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/rust/pin-init/README.md b/rust/pin-init/README.md
> index a4c01a8d78b2..723e275445d4 100644
> --- a/rust/pin-init/README.md
> +++ b/rust/pin-init/README.md
> @@ -6,6 +6,18 @@
>  ![GitHub Workflow Status](https://img.shields.io/github/actions/workflow/status/Rust-for-Linux/pin-init/test.yml)
>  # `pin-init`
>
> +> [!NOTE]
> +>
> +> This crate was originally named [`pinned-init`], but the migration to
> +> `pin-init` is not yet complete. The `legcay` branch contains the current

typo

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] pin-init sync v6.18
  2025-09-05 13:33 [PATCH 0/2] pin-init sync v6.18 Benno Lossin
  2025-09-05 13:33 ` [PATCH 1/2] rust: pin-init: examples: error: use `Error` in `fn main()` Benno Lossin
  2025-09-05 13:33 ` [PATCH 2/2] rust: pin-init: README: add information banner on the rename to `pin-init` Benno Lossin
@ 2025-09-11 21:34 ` Benno Lossin
  2 siblings, 0 replies; 5+ messages in thread
From: Benno Lossin @ 2025-09-11 21:34 UTC (permalink / raw)
  To: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
	Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
	Trevor Gross, Danilo Krummrich
  Cc: rust-for-linux

On Fri Sep 5, 2025 at 3:33 PM CEST, Benno Lossin wrote:
> Some very small changes coming from CI fixes & a readme update. These
> changes are already merged upstream & originate from these pull
> requests:
>
> * https://github.com/Rust-for-Linux/pin-init/pull/79
> * https://github.com/Rust-for-Linux/pin-init/pull/80
> * https://github.com/Rust-for-Linux/pin-init/pull/81
> * https://github.com/Rust-for-Linux/pin-init/pull/82
>
> Note that 80 & 82 only changed CI, test & cargo files that aren't
> included in the kernel tree.
>
> Benno Lossin (2):
>   rust: pin-init: examples: error: use `Error` in `fn main()`
>   rust: pin-init: README: add information banner on the rename to
>     `pin-init`
>
>  rust/pin-init/README.md         | 12 ++++++++++++
>  rust/pin-init/examples/error.rs |  4 +++-
>  2 files changed, 15 insertions(+), 1 deletion(-)
>
>
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585

Applied to pin-init-next, thanks everyone!

I left the typo in, since I will need to fix that upstream next cycle.
The banner might also be gone next cycle, so I don't think it matters
too much.

---
Cheers,
Benno

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-09-11 21:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-05 13:33 [PATCH 0/2] pin-init sync v6.18 Benno Lossin
2025-09-05 13:33 ` [PATCH 1/2] rust: pin-init: examples: error: use `Error` in `fn main()` Benno Lossin
2025-09-05 13:33 ` [PATCH 2/2] rust: pin-init: README: add information banner on the rename to `pin-init` Benno Lossin
2025-09-05 13:40   ` Alice Ryhl
2025-09-11 21:34 ` [PATCH 0/2] pin-init sync v6.18 Benno Lossin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).