From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] samples: rust: add a USB driver sample
Date: Sat, 6 Sep 2025 14:10:01 +0200 [thread overview]
Message-ID: <2025090601-iron-glitter-c77d@gregkh> (raw)
In-Reply-To: <D8EAF874-4FED-42EE-8FD8-E89B6CB0086A@collabora.com>
On Sat, Sep 06, 2025 at 09:04:04AM -0300, Daniel Almeida wrote:
> Hi Greg,
>
> […]
>
> >
> > Sorry for the delay.
> >
> > But these bindings really are only for a usb interface probe/disconnect
> > sequence, right? no real data flow at all?
> >
> > I recommend looking at the usb-skeleton.c driver, and implementing that
> > as your sample driver for rust. That will ensure that you actually have
> > the correct apis implemented and the reference count logic working
> > properly. You have urb anchors and callbacks and other stuff as well to
> > ensure that you get right. That driver pretty much should handle
> > everything that you need to do to write a usb driver for any type of
> > "real" device.
> >
> > thanks,
> >
> > greg k-h
>
>
> I thought that an iterative approach would work here, i.e.: merge this, then
> URBs, then more stuff, etc.
Ah, that makes sense, I didn't realize you want that here. What USB
device do you want to write a rust driver for? Are you going to need
bindings to the usb major number, or is it going to talk to some other
subsystem instead?
Right now, these bindings don't really do anything USB specific at all
except allow a driver to bind to a device.
thanks,
greg k-h
next prev parent reply other threads:[~2025-09-06 12:10 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 18:18 [PATCH 0/2] rust: usb: add initial USB abstractions Daniel Almeida
2025-08-25 18:18 ` [PATCH 1/2] rust: usb: add basic " Daniel Almeida
2025-08-25 20:49 ` Benno Lossin
2025-08-25 21:03 ` Daniel Almeida
2025-09-23 13:21 ` Danilo Krummrich
2025-09-23 13:31 ` Daniel Almeida
2025-09-23 14:03 ` Danilo Krummrich
2025-09-23 14:30 ` Greg Kroah-Hartman
2025-09-23 14:38 ` Danilo Krummrich
2025-09-23 14:52 ` Greg Kroah-Hartman
2025-09-23 15:06 ` Danilo Krummrich
2025-09-23 14:58 ` Alan Stern
2025-09-23 14:13 ` Greg Kroah-Hartman
2025-09-23 14:16 ` Oliver Neukum
2025-09-23 14:22 ` Greg Kroah-Hartman
2025-09-23 14:25 ` Danilo Krummrich
2025-09-23 14:37 ` Greg Kroah-Hartman
2025-09-23 14:42 ` Danilo Krummrich
2025-09-23 14:49 ` Greg Kroah-Hartman
2025-09-23 15:46 ` Danilo Krummrich
2025-09-23 14:18 ` Danilo Krummrich
2025-08-25 18:18 ` [PATCH 2/2] samples: rust: add a USB driver sample Daniel Almeida
2025-09-06 11:14 ` Greg Kroah-Hartman
2025-09-06 12:04 ` Daniel Almeida
2025-09-06 12:10 ` Greg Kroah-Hartman [this message]
2025-09-06 12:41 ` Daniel Almeida
2025-09-06 13:07 ` Greg Kroah-Hartman
2025-09-06 14:49 ` Alan Stern
2025-09-06 14:56 ` Daniel Almeida
2025-09-06 13:22 ` Danilo Krummrich
2025-09-06 14:50 ` Daniel Almeida
2025-09-06 15:22 ` Danilo Krummrich
2025-09-06 15:46 ` Daniel Almeida
2025-09-06 15:48 ` Danilo Krummrich
2025-09-09 11:19 ` Simon Neuenhausen
2025-09-09 12:12 ` Daniel Almeida
2025-09-09 13:25 ` Greg Kroah-Hartman
2025-09-09 12:14 ` Greg Kroah-Hartman
2025-09-09 13:05 ` Simon Neuenhausen
2025-08-25 20:32 ` [PATCH 0/2] rust: usb: add initial USB abstractions Greg Kroah-Hartman
2025-09-23 12:05 ` Greg Kroah-Hartman
2025-09-23 12:29 ` Alice Ryhl
2025-09-23 12:31 ` Greg Kroah-Hartman
2025-09-23 12:34 ` Daniel Almeida
2025-09-23 12:41 ` Greg Kroah-Hartman
2025-09-23 12:55 ` Miguel Ojeda
2025-09-23 12:56 ` Miguel Ojeda
2025-09-23 13:24 ` Daniel Almeida
2025-09-23 21:29 ` Miguel Ojeda
2025-09-25 12:52 ` Greg Kroah-Hartman
2025-09-25 12:58 ` Daniel Almeida
2025-09-25 13:29 ` Danilo Krummrich
2025-09-25 17:38 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025090601-iron-glitter-c77d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).