rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tong <djfkvcing117@gmail.com>
Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	onur-ozkan <work@onurozkan.dev>
Subject: Re: [PATCH] rust/fs: use intra-doc link for `EBADF` in `BadFdError` docs
Date: Tue, 16 Sep 2025 20:30:09 +0200	[thread overview]
Message-ID: <2025091624-mud-scotch-4c1a@gregkh> (raw)
In-Reply-To: <CAMfjjQ1Gtjg4iG8L6Xdm1HP6FmoVgDHC6QhtMEGbA6_y-_6SXA@mail.gmail.com>

On Wed, Sep 17, 2025 at 01:13:38AM +0800, Tong wrote:
> >From af7f05e99ed67f57c83e51ca3a1b3010e3e87762 Mon Sep 17 00:00:00 2001
> From: tong <djfkvcing117@gmail.com>
> Date: Wed, 17 Sep 2025 00:25:44 +0800
> Subject: [PATCH] rust/fs: use intra-doc link for `EBADF` in `BadFdError` docs
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit

Perhaps try using git send-email?  That way this will not show up in the
body of the message.

> In rust/kernel/fs/file.rs, replace plain-text `EBADF` in the doc
> comment for BadFdError with an intra-doc link [`EBADF`].
> 
> This improves the generated documentation (so the `EBADF` constant is
> linked), and helps tools such as rust-analyzer to resolve such
> references from the docs.
> 
> Suggested-by: Onur Özkan <work@onurozkan.dev>
> Link: https://github.com/Rust-for-Linux/linux/issues/1186
> Signed-off-by: tong <djfkvcing117@gmail.com>

We need a full name please.

thanks,

greg k-h

  reply	other threads:[~2025-09-16 18:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 17:13 [PATCH] rust/fs: use intra-doc link for `EBADF` in `BadFdError` docs Tong
2025-09-16 18:30 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-09-17  3:38 djfkvcing117
2025-09-17 12:42 ` Onur Özkan
2025-09-16 15:07 Tong
2025-09-16 15:17 ` Greg KH
     [not found] <CAMfjjQ18NYsQh7CVzRs=+sYwve4T5y-vf=zMNLyxQvgYE4+mMA@mail.gmail.com>
2025-09-16 14:37 ` Greg KH
2025-09-16 14:40 ` Onur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025091624-mud-scotch-4c1a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=djfkvcing117@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).