From: "Onur Özkan" <work@onurozkan.dev>
To: djfkvcing117@gmail.com
Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
gregkh <gregkh@linuxfoundation.org>,
lossin@kernel.org, gary@garyguo.net
Subject: Re: [PATCH v4] rust/fs: use intra-doc link for `EBADF` in `BadFdError` docs
Date: Wed, 17 Sep 2025 20:41:35 +0300 [thread overview]
Message-ID: <20250917204135.7a796dd3@nimda.home> (raw)
In-Reply-To: <20250917165106.22262-1-djfkvcing117@gmail.com>
On Thu, 18 Sep 2025 00:50:59 +0800
djfkvcing117@gmail.com wrote:
> From: Tong Li <djfkvcing117@gmail.com>
>
> In rust/kernel/fs/file.rs, replace `EBADF` with [`EBADF`].
>
> This helps rust-analyzer to resolve such references.
>
> Suggested-by: Onur Özkan <work@onurozkan.dev>
> Link: https://github.com/Rust-for-Linux/linux/issues/1186
> Signed-off-by: Tong Li <djfkvcing117@gmail.com>
> ---
> rust/kernel/fs/file.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/rust/kernel/fs/file.rs b/rust/kernel/fs/file.rs
> index 67a3654f0fd3..f3153f4c8560 100644
> --- a/rust/kernel/fs/file.rs
> +++ b/rust/kernel/fs/file.rs
> @@ -448,9 +448,9 @@ fn drop(&mut self) {
> }
> }
>
> -/// Represents the `EBADF` error code.
> +/// Represents the [`EBADF`] error code.
> ///
> -/// Used for methods that can only fail with `EBADF`.
> +/// Used for methods that can only fail with [`EBADF`].
> #[derive(Copy, Clone, Eq, PartialEq)]
> pub struct BadFdError;
>
Reviewed-by: Onur Özkan <work@onurozkan.dev>
next prev parent reply other threads:[~2025-09-17 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 16:50 [PATCH v4] rust/fs: use intra-doc link for `EBADF` in `BadFdError` docs djfkvcing117
2025-09-17 17:41 ` Onur Özkan [this message]
2025-09-29 19:10 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917204135.7a796dd3@nimda.home \
--to=work@onurozkan.dev \
--cc=djfkvcing117@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).