From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04CB430CB36; Thu, 18 Sep 2025 15:01:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758207690; cv=none; b=JOnyknRM9gLjgOrULvNERCFpM1wWoRh589bpEOPoUh44hgRY2PRBSfaT/U8E53AcI3A2E9zk4eJF3iYAzPtBMSFoKuS5EbI85vJrcrUX1U66fieZ5I4v1UtP/eCryZaAnJ4ZDe8BgucfYJHucwiA9FDuBggcVtoManqT4DPWQiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758207690; c=relaxed/simple; bh=YkUhrdJ77qxCz0LRTerH2THmYwSvWHK0xjh4fDRXL9c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mfy048nUjmBbunUy4Pg5Nza9LcDBLlJMAquAeKHT9ZaZYJ8McsryJIKcj3xo5zjmvdlTNN/o2mStCqGObXqc3xfXPehcMpW2I39+q/PAw6ZRta3mHgx0Ow4CNakvxSGK6+wHrdMzVMEQrtgD1Jm4MZUXpDWVth+GHduxskujMic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PaWxf3se; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PaWxf3se" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B63CC4CEE7; Thu, 18 Sep 2025 15:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1758207689; bh=YkUhrdJ77qxCz0LRTerH2THmYwSvWHK0xjh4fDRXL9c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PaWxf3se0dIvqb+7AeF0vK9lNeEWQikgoNUdodIzWcvmwp/nWek7ZVPjnaU0bJCBo 5J9xZuryhX9T/jXhlCQyuhkfHQycpR7cUYEYhiunQks/4g8PQkDtIHa8DFQSqByldD ShmLuQUXZmsRASFktaEgsl/rV4t8RpaoED4eHWgs= Date: Thu, 18 Sep 2025 17:01:26 +0200 From: "gregkh@linuxfoundation.org" To: ManeraKai Cc: "aliceryhl@google.com" , "arnd@arndb.de" , "rust-for-linux@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/3] samples: rust: Updated the example using the Rust MiscDevice abstraction Message-ID: <2025091850-brownnose-applause-1dac@gregkh> References: <20250918144356.28585-1-manerakai@protonmail.com> <20250918144356.28585-4-manerakai@protonmail.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250918144356.28585-4-manerakai@protonmail.com> On Thu, Sep 18, 2025 at 02:45:44PM +0000, ManeraKai wrote: > This sample driver will now: > - use the new general `FileOperations` abstraction. > - have `read` and `write` methods, that use a persistent kernel buffer to > store data. > > Signed-off-by: ManeraKai > --- > samples/rust/rust_misc_device.rs | 283 +++++++++++++++++++++---------- > 1 file changed, 195 insertions(+), 88 deletions(-) > > diff --git a/samples/rust/rust_misc_device.rs b/samples/rust/rust_misc_device.rs > index d052294cebb8..c8e90eb9b9ad 100644 > --- a/samples/rust/rust_misc_device.rs > +++ b/samples/rust/rust_misc_device.rs > @@ -7,92 +7,139 @@ > //! Below is an example userspace C program that exercises this sample's functionality. > //! > //! ```c > -//! #include You seem to have dropped the leading ' ' character, which makes this diff almost impossible to review :( Please fix that up and only change the modified files, not all of them, in the example. thanks, greg k-h