From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 0/2] rust: usb: add initial USB abstractions
Date: Tue, 23 Sep 2025 14:05:06 +0200 [thread overview]
Message-ID: <2025092338-elbow-dash-373d@gregkh> (raw)
In-Reply-To: <20250825-b4-usb-v1-0-7aa024de7ae8@collabora.com>
On Mon, Aug 25, 2025 at 03:18:04PM -0300, Daniel Almeida wrote:
> This adds initial support for USB Rust drivers, not only because I see a
> widespread use of module_usb_driver() in media (which is a subsystem I
> aim to support) but also because I want to learn about USB in general
> and this is a nice opportunity to start doing so.
>
> I tried to keep things as consistent with pci.rs and platform.rs as
> possible and tested it by manually binding a device (i.e.: my Logitech
> mouse) to the sample driver via:
>
> /sys/bus/usb/drivers/rust_driver_usb/new_id
>
> This initial patch is therefore comprised of the same patterns that are
> known to work for pci and platform already.
>
> Physically disconnecting the device also worked, i.e.: nothing bad
> showed up in dmesg.
>
> Note that I did not touch MAINTAINERS at all. The objective is to
> kickstart the discussion of what to do there here in v1.
I tried to apply these, but I get the following build error when adding
to the char-misc-testing tree:
ld.lld: error: undefined symbol: usb_get_intf
>>> referenced by kernel.1a949e63ee2acc6a-cgu.0
>>> rust/kernel.o:(<kernel::usb::Interface as kernel::sync::aref::AlwaysRefCounted>::inc_ref) in archive vmlinux.a
>>> referenced by kernel.1a949e63ee2acc6a-cgu.0
>>> rust/kernel.o:(<kernel::sync::aref::ARef<kernel::usb::Interface> as core::convert::From<&kernel::usb::Interface<kernel::device::CoreInternal>>>::from) in archive vmlinux.a
ld.lld: error: undefined symbol: usb_put_intf
>>> referenced by kernel.1a949e63ee2acc6a-cgu.0
>>> rust/kernel.o:(<kernel::usb::Interface as kernel::sync::aref::AlwaysRefCounted>::dec_ref) in archive vmlinux.a
ld.lld: error: undefined symbol: usb_get_dev
>>> referenced by kernel.1a949e63ee2acc6a-cgu.0
>>> rust/kernel.o:(<kernel::usb::Device as kernel::sync::aref::AlwaysRefCounted>::inc_ref) in archive vmlinux.a
>>> referenced by kernel.1a949e63ee2acc6a-cgu.0
>>> rust/kernel.o:(<kernel::sync::aref::ARef<kernel::usb::Device> as core::convert::From<&kernel::usb::Device<kernel::device::CoreInternal>>>::from) in archive vmlinux.a
ld.lld: error: undefined symbol: usb_put_dev
>>> referenced by kernel.1a949e63ee2acc6a-cgu.0
>>> rust/kernel.o:(<kernel::usb::Device as kernel::sync::aref::AlwaysRefCounted>::dec_ref) in archive vmlinux.a
Any hints?
thanks,
greg k-h
next prev parent reply other threads:[~2025-09-23 12:05 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 18:18 [PATCH 0/2] rust: usb: add initial USB abstractions Daniel Almeida
2025-08-25 18:18 ` [PATCH 1/2] rust: usb: add basic " Daniel Almeida
2025-08-25 20:49 ` Benno Lossin
2025-08-25 21:03 ` Daniel Almeida
2025-09-23 13:21 ` Danilo Krummrich
2025-09-23 13:31 ` Daniel Almeida
2025-09-23 14:03 ` Danilo Krummrich
2025-09-23 14:30 ` Greg Kroah-Hartman
2025-09-23 14:38 ` Danilo Krummrich
2025-09-23 14:52 ` Greg Kroah-Hartman
2025-09-23 15:06 ` Danilo Krummrich
2025-09-23 14:58 ` Alan Stern
2025-09-23 14:13 ` Greg Kroah-Hartman
2025-09-23 14:16 ` Oliver Neukum
2025-09-23 14:22 ` Greg Kroah-Hartman
2025-09-23 14:25 ` Danilo Krummrich
2025-09-23 14:37 ` Greg Kroah-Hartman
2025-09-23 14:42 ` Danilo Krummrich
2025-09-23 14:49 ` Greg Kroah-Hartman
2025-09-23 15:46 ` Danilo Krummrich
2025-09-23 14:18 ` Danilo Krummrich
2025-08-25 18:18 ` [PATCH 2/2] samples: rust: add a USB driver sample Daniel Almeida
2025-09-06 11:14 ` Greg Kroah-Hartman
2025-09-06 12:04 ` Daniel Almeida
2025-09-06 12:10 ` Greg Kroah-Hartman
2025-09-06 12:41 ` Daniel Almeida
2025-09-06 13:07 ` Greg Kroah-Hartman
2025-09-06 14:49 ` Alan Stern
2025-09-06 14:56 ` Daniel Almeida
2025-09-06 13:22 ` Danilo Krummrich
2025-09-06 14:50 ` Daniel Almeida
2025-09-06 15:22 ` Danilo Krummrich
2025-09-06 15:46 ` Daniel Almeida
2025-09-06 15:48 ` Danilo Krummrich
2025-09-09 11:19 ` Simon Neuenhausen
2025-09-09 12:12 ` Daniel Almeida
2025-09-09 13:25 ` Greg Kroah-Hartman
2025-09-09 12:14 ` Greg Kroah-Hartman
2025-09-09 13:05 ` Simon Neuenhausen
2025-08-25 20:32 ` [PATCH 0/2] rust: usb: add initial USB abstractions Greg Kroah-Hartman
2025-09-23 12:05 ` Greg Kroah-Hartman [this message]
2025-09-23 12:29 ` Alice Ryhl
2025-09-23 12:31 ` Greg Kroah-Hartman
2025-09-23 12:34 ` Daniel Almeida
2025-09-23 12:41 ` Greg Kroah-Hartman
2025-09-23 12:55 ` Miguel Ojeda
2025-09-23 12:56 ` Miguel Ojeda
2025-09-23 13:24 ` Daniel Almeida
2025-09-23 21:29 ` Miguel Ojeda
2025-09-25 12:52 ` Greg Kroah-Hartman
2025-09-25 12:58 ` Daniel Almeida
2025-09-25 13:29 ` Danilo Krummrich
2025-09-25 17:38 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025092338-elbow-dash-373d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).