rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joel Fernandes <joelagnelf@nvidia.com>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	dri-devel@lists.freedesktop.org, dakr@kernel.org,
	Alistair Popple <apopple@nvidia.com>,
	Miguel Ojeda <ojeda@kernel.org>,
	Alex Gaynor <alex.gaynor@gmail.com>,
	Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
	bjorn3_gh@protonmail.com, Benno Lossin <lossin@kernel.org>,
	Andreas Hindborg <a.hindborg@kernel.org>,
	Alice Ryhl <aliceryhl@google.com>,
	Trevor Gross <tmgross@umich.edu>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	John Hubbard <jhubbard@nvidia.com>, Timur Tabi <ttabi@nvidia.com>,
	joel@joelfernandes.org, Elle Rhumsaa <elle@weathered-steel.dev>,
	Yury Norov <yury.norov@gmail.com>,
	Daniel Almeida <daniel.almeida@collabora.com>,
	nouveau@lists.freedesktop.org
Subject: Re: [PATCH v4 6/6] rust: bitfield: Use 'as' operator for setter type conversion
Date: Tue, 30 Sep 2025 08:03:54 -0400	[thread overview]
Message-ID: <20250930120354.GA3415500@joelbox2> (raw)
In-Reply-To: <DD5D59FH4JTT.2G5WEXF3RBCQJ@nvidia.com>

On Mon, Sep 29, 2025 at 11:44:56PM +0900, Alexandre Courbot wrote:
> On Mon Sep 29, 2025 at 10:59 PM JST, Miguel Ojeda wrote:
> > On Sat, Sep 20, 2025 at 8:23 PM Joel Fernandes <joelagnelf@nvidia.com> wrote:
> >>
> >> The bitfield macro's setter currently uses the From trait for type
> >> conversion, which is overly restrictive and prevents use cases such as
> >> narrowing conversions (e.g., u32 storage size to u8 field size) which
> >> aren't supported by From.
> >
> > Being restrictive is a good thing
> 
> On that note, I have been wondering whether we should not push the
> restriction up to having bounded primitive types with only a set number
> of bits valid, e.g. `bound_u8::<2>` is guaranteed to only contain values
> in the range `0..=3`.
> 
> Getters and setters would use these types depending on the number of
> bits of the field, meaning that a caller would have to validate the
> value they want to write if it does not implement e.g.
> `Into<bound_u8<2>>`.
> 
> A bit radical maybe, but correcness ensues. :)

In my v5, I will be rejecting setter inputs that are out of range. Do we have a
usecase where we want the inputs to exceed the bit width range? If not, let
us keep the API simple. I should probably post v5 today so we have a full
discussion on the same and get alignment from everyone.

Thanks

  parent reply	other threads:[~2025-09-30 12:04 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-20 18:22 [PATCH v4 0/6] Introduce bitfield and move register macro to rust/kernel/ Joel Fernandes
2025-09-20 18:22 ` [PATCH v4 1/6] nova-core: bitfield: Move bitfield-specific code from register! into new macro Joel Fernandes
2025-09-21  9:36   ` Greg KH
2025-09-21  9:59     ` Miguel Ojeda
2025-09-21 11:23       ` Greg KH
2025-09-21 12:33     ` Benno Lossin
2025-09-21 12:45       ` Greg KH
2025-09-21 13:47         ` Danilo Krummrich
2025-09-23  6:38           ` Behme Dirk (XC-CP/ESD1)
2025-09-24 10:52           ` Greg KH
2025-09-24 11:28             ` Danilo Krummrich
2025-09-24 12:04               ` Greg KH
2025-09-24 14:38             ` Yury Norov
2025-09-24 15:53               ` Danilo Krummrich
2025-09-24 17:46               ` Joel Fernandes
2025-09-24 20:01                 ` Elle Rhumsaa
2025-09-25  7:05                   ` Joel Fernandes
2025-09-23 22:24         ` Joel Fernandes
2025-09-24 10:40           ` Greg KH
2025-09-29 19:26             ` Joel Fernandes
2025-09-29 19:37               ` Greg KH
2025-09-29 19:45                 ` Joel Fernandes
2025-09-29 20:25               ` Danilo Krummrich
2025-09-21 13:49     ` Danilo Krummrich
2025-09-29  6:16   ` Alexandre Courbot
2025-09-29 19:36     ` Joel Fernandes
2025-09-20 18:22 ` [PATCH v4 2/6] nova-core: bitfield: Add support for different storage widths Joel Fernandes
2025-09-29  6:22   ` Alexandre Courbot
2025-09-29 19:47     ` Joel Fernandes
2025-09-20 18:22 ` [PATCH v4 3/6] nova-core: bitfield: Add support for custom visiblity Joel Fernandes
2025-09-29  6:28   ` Alexandre Courbot
2025-09-29 20:20     ` Joel Fernandes
2025-09-20 18:22 ` [PATCH v4 4/6] rust: Move register and bitfield macros out of Nova Joel Fernandes
2025-09-29  6:30   ` Alexandre Courbot
2025-09-20 18:22 ` [PATCH v4 5/6] rust: Add KUNIT tests for bitfield Joel Fernandes
2025-09-20 18:22 ` [PATCH v4 6/6] rust: bitfield: Use 'as' operator for setter type conversion Joel Fernandes
2025-09-29  6:47   ` Alexandre Courbot
2025-09-29 20:32     ` Joel Fernandes
2025-09-29 13:59   ` Miguel Ojeda
2025-09-29 14:44     ` Alexandre Courbot
2025-09-29 15:17       ` Miguel Ojeda
2025-09-30 12:03       ` Joel Fernandes [this message]
2025-09-29 15:26     ` Yury Norov
2025-09-29 20:46     ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250930120354.GA3415500@joelbox2 \
    --to=joelagnelf@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=elle@weathered-steel.dev \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    --cc=tzimmermann@suse.de \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).