Re: [PATCH v3 2/2] rust: drop `error::to_result` and utilize `ToResult`

["Onur Özkan" <work@onurozkan.dev>]

On Mon, 13 Oct 2025 19:04:09 +0200
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:

> On Mon, Oct 13, 2025 at 2:43 PM Onur Özkan <work@onurozkan.dev> wrote:
> >
> >  29 files changed, 253 insertions(+), 210 deletions(-)
> 
> Something like this will be hard to merge if we wait for all
> Acked-bys. It is best to do the migration over time and split it per
> subsystem.

Sure. To do that, I need to keep the current `error::to_result`
untouched. I guess that would be fine.

> Also, you should Cc all the relevant maintainers/reviewers -- you are
> touching quite a few subsystems. :)
> 

Right, sorry.

> > I haven't included all the improvements made possible by the new
> > design since that could conflict with other ongoing patches [2].
> > Once this patch is approved and applied, I am planning to follow up
> > with creating a "good first issue" on [3] for those additional
> > changes.
> 
> I would suggest including a few examples of the improvements in an RFC
> patch on top. In other words, we need to show the improvements (or at
> least some key examples) to justify a change, rather than doing it
> later.
> 
> For instance, with the changes in this patch, I see a lot of `Ok(())`
> added because now one needs to discard the value, which isn't great...
> It indicates that the common case may not be keeping the value, and
> thus we may want two APIs for this.
> 
> Thus, similarly, we may be able to spot a similar pattern in those
> examples too.
> 

Thank you for your feedback Miguel. I will wait sometime to collect more
feedback and then I will prepare an RFC based on all the input. I would
feel more confident sending the RFC after receiving more feedback from
more Rust kernel developers.

-Onur

> Thanks!
> 
> Cheers,
> Miguel