From: Bjorn Helgaas <helgaas@kernel.org>
To: Danilo Krummrich <dakr@kernel.org>
Cc: bhelgaas@google.com, kwilczynski@kernel.org, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
rust-for-linux@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] rust: pci: move I/O infrastructure to separate file
Date: Thu, 16 Oct 2025 10:52:15 -0500 [thread overview]
Message-ID: <20251016155215.GA985778@bhelgaas> (raw)
In-Reply-To: <DDJR102F5NFB.1X5IVJQ6FK3CD@kernel.org>
On Thu, Oct 16, 2025 at 02:34:57PM +0200, Danilo Krummrich wrote:
> On Thu Oct 16, 2025 at 12:58 AM CEST, Bjorn Helgaas wrote:
> > On Wed, Oct 15, 2025 at 08:14:30PM +0200, Danilo Krummrich wrote:
> >> Move the PCI I/O infrastructure to a separate sub-module in order to
> >> keep things organized.
> >
> >> +++ b/rust/kernel/pci/io.rs
> >
> >> +/// A PCI BAR to perform I/O-Operations on.
> >> ...
> >> +/// memory mapped PCI bar and its size.
> >> ...
> >> + /// `ioptr` must be a valid pointer to the memory mapped PCI bar number `num`.
> >
> > I know this is just a move, but "BAR" vs "bar" usage is inconsistent.
> > I think "BAR" is clearer in comments.
>
> Yes, I agree.
>
> >> + /// Mapps an entire PCI-BAR after performing a region-request on it. I/O operation bound checks
> >> ...
> >> + /// Mapps an entire PCI-BAR after performing a region-request on it.
> >
> > Similarly, s/Mapps/Maps/ and s/PCI-BAR/PCI BAR/
>
> Thanks for catching those!
>
> I think we should fix those in a follow-up patch. Even for trivial things, I
> prefer not to fix them with a code move.
Makes sense, thanks!
next prev parent reply other threads:[~2025-10-16 15:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 18:14 [PATCH 0/3] Rust PCI housekeeping Danilo Krummrich
2025-10-15 18:14 ` [PATCH 1/3] rust: pci: implement TryInto<IrqRequest<'a>> for IrqVector<'a> Danilo Krummrich
2025-10-16 15:01 ` Alice Ryhl
2025-10-16 17:04 ` Danilo Krummrich
2025-10-16 22:24 ` Joel Fernandes
2025-10-16 22:57 ` Danilo Krummrich
2025-10-16 23:02 ` Joel Fernandes
2025-10-15 18:14 ` [PATCH 2/3] rust: pci: move I/O infrastructure to separate file Danilo Krummrich
2025-10-15 22:58 ` Bjorn Helgaas
2025-10-16 12:34 ` Danilo Krummrich
2025-10-16 15:52 ` Bjorn Helgaas [this message]
2025-10-16 18:54 ` Miguel Ojeda
2025-10-15 18:14 ` [PATCH 3/3] rust: pci: move IRQ " Danilo Krummrich
2025-10-15 23:02 ` Bjorn Helgaas
2025-10-20 11:39 ` [PATCH 0/3] Rust PCI housekeeping Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251016155215.GA985778@bhelgaas \
--to=helgaas@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).