rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rust: usb: fix formatting
@ 2025-10-16 23:13 Miguel Ojeda
  2025-10-17  5:42 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 5+ messages in thread
From: Miguel Ojeda @ 2025-10-16 23:13 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Miguel Ojeda, Alex Gaynor
  Cc: linux-usb, Boqun Feng, Gary Guo, Björn Roy Baron,
	Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
	Danilo Krummrich, rust-for-linux, linux-kernel, patches

We do our best to keep the repository `rustfmt`-clean, thus run the tool
to fix the formatting issue.

Link: https://docs.kernel.org/rust/coding-guidelines.html#style-formatting
Link: https://rust-for-linux.com/contributing#submit-checklist-addendum
Fixes: 9a55e0079258 ("Revert "USB: disable rust bindings from the build for now"")
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
Greg: I am sending the `rustfmt` series to Linus to see if he is OK with
getting the tree back into a clean state:

    https://lore.kernel.org/rust-for-linux/20251010174351.948650-1-ojeda@kernel.org/

And I noticed that in linux-next this is wrongly formatted (i.e. bad
sorting).

Please feel free to just fix the original commit if you rebase, of
course. I am sending this as a patch in case it helps.

Thanks!

 rust/kernel/lib.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
index 9cf4ca0ae7a1..cd191686fef6 100644
--- a/rust/kernel/lib.rs
+++ b/rust/kernel/lib.rs
@@ -138,9 +138,9 @@
 pub mod tracepoint;
 pub mod transmute;
 pub mod types;
+pub mod uaccess;
 #[cfg(CONFIG_USB = "y")]
 pub mod usb;
-pub mod uaccess;
 pub mod workqueue;
 pub mod xarray;


base-commit: 2433b84761658ef123ae683508bc461b07c5b0f0
--
2.51.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] rust: usb: fix formatting
  2025-10-16 23:13 [PATCH] rust: usb: fix formatting Miguel Ojeda
@ 2025-10-17  5:42 ` Greg Kroah-Hartman
  2025-10-19 18:59   ` Miguel Ojeda
  0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2025-10-17  5:42 UTC (permalink / raw)
  To: Miguel Ojeda
  Cc: Alex Gaynor, linux-usb, Boqun Feng, Gary Guo,
	Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
	Trevor Gross, Danilo Krummrich, rust-for-linux, linux-kernel,
	patches

On Fri, Oct 17, 2025 at 01:13:50AM +0200, Miguel Ojeda wrote:
> We do our best to keep the repository `rustfmt`-clean, thus run the tool
> to fix the formatting issue.
> 
> Link: https://docs.kernel.org/rust/coding-guidelines.html#style-formatting
> Link: https://rust-for-linux.com/contributing#submit-checklist-addendum
> Fixes: 9a55e0079258 ("Revert "USB: disable rust bindings from the build for now"")
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
> Greg: I am sending the `rustfmt` series to Linus to see if he is OK with
> getting the tree back into a clean state:
> 
>     https://lore.kernel.org/rust-for-linux/20251010174351.948650-1-ojeda@kernel.org/
> 
> And I noticed that in linux-next this is wrongly formatted (i.e. bad
> sorting).
> 
> Please feel free to just fix the original commit if you rebase, of
> course. I am sending this as a patch in case it helps.

I don't rebase my public trees, so I'll queue this up after your changes
land.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rust: usb: fix formatting
  2025-10-17  5:42 ` Greg Kroah-Hartman
@ 2025-10-19 18:59   ` Miguel Ojeda
  2025-10-27 15:03     ` Miguel Ojeda
  0 siblings, 1 reply; 5+ messages in thread
From: Miguel Ojeda @ 2025-10-19 18:59 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Miguel Ojeda, Alex Gaynor, linux-usb, Boqun Feng, Gary Guo,
	Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
	Trevor Gross, Danilo Krummrich, rust-for-linux, linux-kernel,
	patches

On Fri, Oct 17, 2025 at 7:42 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> I don't rebase my public trees, so I'll queue this up after your changes
> land.

They landed in mainline, so Linus' tree is again `rustfmt`-clean.

Thanks!

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rust: usb: fix formatting
  2025-10-19 18:59   ` Miguel Ojeda
@ 2025-10-27 15:03     ` Miguel Ojeda
  2025-10-28  9:04       ` Greg Kroah-Hartman
  0 siblings, 1 reply; 5+ messages in thread
From: Miguel Ojeda @ 2025-10-27 15:03 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Miguel Ojeda, Alex Gaynor, linux-usb, Boqun Feng, Gary Guo,
	Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
	Trevor Gross, Danilo Krummrich, rust-for-linux, linux-kernel,
	patches

On Sun, Oct 19, 2025 at 8:59 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> They landed in mainline, so Linus' tree is again `rustfmt`-clean.

Pinging about this one so that it is not forgotten. It is the only
missing thing so that linux-next is clean again like Linus'.

Thanks!

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rust: usb: fix formatting
  2025-10-27 15:03     ` Miguel Ojeda
@ 2025-10-28  9:04       ` Greg Kroah-Hartman
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2025-10-28  9:04 UTC (permalink / raw)
  To: Miguel Ojeda
  Cc: Miguel Ojeda, Alex Gaynor, linux-usb, Boqun Feng, Gary Guo,
	Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
	Trevor Gross, Danilo Krummrich, rust-for-linux, linux-kernel,
	patches

On Mon, Oct 27, 2025 at 04:03:37PM +0100, Miguel Ojeda wrote:
> On Sun, Oct 19, 2025 at 8:59 PM Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
> >
> > They landed in mainline, so Linus' tree is again `rustfmt`-clean.
> 
> Pinging about this one so that it is not forgotten. It is the only
> missing thing so that linux-next is clean again like Linus'.

Just now applied, sorry for the delay.

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-10-28  9:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-16 23:13 [PATCH] rust: usb: fix formatting Miguel Ojeda
2025-10-17  5:42 ` Greg Kroah-Hartman
2025-10-19 18:59   ` Miguel Ojeda
2025-10-27 15:03     ` Miguel Ojeda
2025-10-28  9:04       ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).