From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86CD02F618D for ; Mon, 20 Oct 2025 09:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760952956; cv=none; b=kHlnXSCrcKxRtxczYjRra/0odbdyQxf74MydGA57QtKA3vVav8ClehPpSejNKgJs9saBMUycL0EcPcdNasLV85qhW2AGgdSKm3WqH7UtpLcHUTVkTWv+eo/ZYqo8TxJ0kxEt4JkRB5G4p13az026/+iDJTAWbTD+OAwonMrR9cg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760952956; c=relaxed/simple; bh=Re+DOU6/e6dkcK3rl4TDT3ox52jxcfPQEvS5zL7tp/g=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Gay7I+j/640UK8c4NBCAO3dDc/0S4Zn8KKWE80AWTDu9h71TsKjfsIJk1whvgyRLPE4pAsNCguVoahPMYcoQ03yzpRXZvXdEozlN1GNf09EKzccRLZuULIa/AfHj+HtjAySuunH0JWfvf6z4jNGxKPXuugJa28NmwrImxKR9pro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=1RUFl2LW; arc=none smtp.client-ip=209.85.221.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="1RUFl2LW" Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-42700160169so2189215f8f.1 for ; Mon, 20 Oct 2025 02:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760952953; x=1761557753; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=M4tqO9Ss7dvk0HhlC8ItWFcBE+vqGHgkt9qscACZJ4U=; b=1RUFl2LWMYmE0wZ7SZRuwEEQkImEJTM/VTw9bsGEhkblqTUgPHPnf4W46mqSkmfNMw GvrwVA2X6PLl0Cm6eP+J1TuoRC1x7J/tjlQDvu9n4sqYe9E+6tj3ONopelDCWlbUY2d/ Lg3XsxX69Eiay3qcA3Id4aOS+YQr3PN4hnPXsfFM6ZzSLpuPUkG/YHTIYB4cXkongzuQ GBVIXU6mEuVRoEGqQdVETYB1BF3YEzE9znm9WGwtkT+RHfeoylG+Ev5M40cot5HW1AVI dnYVHOsSMICSdvLcemgumkWMglHL9naXxH1HGFzPL8Qh3ssB1XuR8tbqH8JDqjfkHoc/ eKGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760952953; x=1761557753; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M4tqO9Ss7dvk0HhlC8ItWFcBE+vqGHgkt9qscACZJ4U=; b=as3TqhD9akSGgqrUdKGsJEt8glTIR0jFBOx+Dj1h633kjlvlCsP14hxMvJDcxImyUY 1FvhB6GhI0IiTYf8P41wWSTbGd0NiFhikOdN5zHgwmJKfjthw8B9kn5u8KAf5EtMr4m2 bObhRkvK10ruWnK109s/dHJlLsl6B9ZXYrIjnHEpk3kPdE4JpWMmh1sLRhJG4qW4JZFU 3ypt8m1W4SzbBAnnHiK6kDfLvYtGYx7V+626BaGxfp6XiNbbXOPCmQJWBoT5xU747EmS de950iQCsABLYEDiP/eyJHinEMxlkaFMTYaAhNmBjWgFEAd8dhbvB4B/KJIfdPwXneUz 1T+g== X-Forwarded-Encrypted: i=1; AJvYcCW/sXWdkeZ8bnWAhUr4KEbcK9fX2lBoym5vG31X/cxjJSv8HrW2QmRvedMRmY3+fU6W1Lhmp+eVVeDEfE9H8A==@vger.kernel.org X-Gm-Message-State: AOJu0YztjGkRp1zZNkjaaRdjRTugU2tPsv3YtWIGhFMafOZpTMRvbtG2 qqmqlaX6v0TkAEi9JpHWKC3yrfqcrsapz8UZ3DLcNn2ghzf03CduCMReL6NMQ98bZ4YZSOWyh1H ZdFgt7b6iCtxjuJDpCQ== X-Google-Smtp-Source: AGHT+IEPdMgaAsWVjr61PyUGcldq0t0ZV5oF0MkmxsMnMiNypMU138b1txPZ8fl/PFCxXF3KGb7789Q8USnSNmM= X-Received: from wrbea3.prod.google.com ([2002:a05:6000:ec3:b0:426:da8f:f403]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:26c4:b0:427:202:d4d2 with SMTP id ffacd0b85a97d-42704db5b02mr8051029f8f.58.1760952952791; Mon, 20 Oct 2025 02:35:52 -0700 (PDT) Date: Mon, 20 Oct 2025 09:35:35 +0000 In-Reply-To: <20251020-clk-send-sync-v2-0-44ab533ae084@google.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251020-clk-send-sync-v2-0-44ab533ae084@google.com> X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=1503; i=aliceryhl@google.com; h=from:subject:message-id; bh=Re+DOU6/e6dkcK3rl4TDT3ox52jxcfPQEvS5zL7tp/g=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBo9gJ07vy/mXgVpdOzBOWq5qGFjx03OJ2lFgfAi n22Xp8hhmyJAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCaPYCdAAKCRAEWL7uWMY5 Rij2EACyfhsJPjQ4ytTfDpEjKd1ocl5UxJUPZpGWrQOsDzjPSSTHDC9vOEsFkkzpAyXeU17d0Qs m/3yYJmuQSOsCPb8cV3ltxv4qU8Z75tF/b6lst22W3fK5G8lqSiGblXNW1gx4TgZ757iFAXCvWF ciPm3m6C8M8SIqAa99IIaE8oEUPZBCAnisRRPVJ77Me8S7cNE3xSHr79A1sN6s2yxNWmOjKZ7Yb GJu5Wh2dWMZBp3N+Uz9XC69a3s4rBRyJ2yRvh8PVAQ4tAkjq4yq5yOIQUl3LJ+O7bnJbeclMfQ0 lRB3CR8c7lEba8t4rg6naXb/oFC6W46wlVoT9T04sPOqEMUXQZQbe+eTMUlwCWDoPrJjp/v07IF zjql0Hsf3HgAq6UAKoiFs1PdrvxC638uoLpVT7guRvlca/JbxR/Syjttxb8NfJzMAwGpNpb7mgG 1A3UL9bH0iyXJNzd1JhXR9kv2MQK8XnOczxR9/Lnu+ZsDk2DQeWHAQSAtChVD4gObn3L5KX3R62 ZMeTuFI0nUJRPevoZ5q5D1lNZveSmGuiGAkuk7tDZaaHkeUiEzroKk2k8FugE5A2g2YnpgzH0gA jpgdtAV6a85Ru+ZL2g5oGmNYPDwBIrUMS+5LLf82YGg3oRm3qK2YeKhYjVgX60UorqxiABR+V9T CQ9akw67fcYzwXw== X-Mailer: b4 0.14.2 Message-ID: <20251020-clk-send-sync-v2-2-44ab533ae084@google.com> Subject: [PATCH v2 2/2] tyr: remove impl Send/Sync for TyrData From: Alice Ryhl To: Michael Turquette , Stephen Boyd Cc: Viresh Kumar , Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?q?Bj=C3=B6rn_Roy_Baron?=" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Daniel Almeida , linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alice Ryhl Content-Type: text/plain; charset="utf-8" Now that clk implements Send and Sync, we no longer need to manually implement these traits for TyrData. Thus remove the implementations. The comment also mentions the regulator. However, the regulator had the traits added in commit 9a200cbdb543 ("rust: regulator: implement Send and Sync for Regulator"), which is already in mainline. Signed-off-by: Alice Ryhl --- drivers/gpu/drm/tyr/driver.rs | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/tyr/driver.rs b/drivers/gpu/drm/tyr/driver.rs index d5625dd1e41c8406494b267d4ac560c442a8012c..574b85bbc497f8d1053d16a11f77ecbe2c87bfb2 100644 --- a/drivers/gpu/drm/tyr/driver.rs +++ b/drivers/gpu/drm/tyr/driver.rs @@ -53,18 +53,6 @@ pub(crate) struct TyrData { pub(crate) gpu_info: GpuInfo, } -// Both `Clk` and `Regulator` do not implement `Send` or `Sync`, but they -// should. There are patches on the mailing list to address this, but they have -// not landed yet. -// -// For now, add this workaround so that this patch compiles with the promise -// that it will be removed in a future patch. -// -// SAFETY: This will be removed in a future patch. -unsafe impl Send for TyrData {} -// SAFETY: This will be removed in a future patch. -unsafe impl Sync for TyrData {} - fn issue_soft_reset(dev: &Device, iomem: &Devres) -> Result { regs::GPU_CMD.write(dev, iomem, regs::GPU_CMD_SOFT_RESET)?; -- 2.51.0.915.g61a8936c21-goog