From: FUJITA Tomonori <fujita.tomonori@gmail.com>
To: dakr@kernel.org, aliceryhl@google.com,
daniel.almeida@collabora.com, a.hindborg@kernel.org,
alex.gaynor@gmail.com, ojeda@kernel.org
Cc: anna-maria@linutronix.de, bjorn3_gh@protonmail.com,
boqun.feng@gmail.com, frederic@kernel.org, gary@garyguo.net,
jstultz@google.com, linux-kernel@vger.kernel.org,
lossin@kernel.org, lyude@redhat.com,
rust-for-linux@vger.kernel.org, sboyd@kernel.org,
tglx@linutronix.de, tmgross@umich.edu
Subject: [PATCH v2 1/2] rust: add udelay() function
Date: Tue, 21 Oct 2025 16:11:45 +0900 [thread overview]
Message-ID: <20251021071146.2357069-2-fujita.tomonori@gmail.com> (raw)
In-Reply-To: <20251021071146.2357069-1-fujita.tomonori@gmail.com>
Add udelay() function, inserts a delay based on microseconds with busy
waiting, in preparation for supporting read_poll_count_atomic().
Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
---
rust/helpers/time.c | 5 +++++
rust/kernel/time/delay.rs | 37 +++++++++++++++++++++++++++++++++++++
2 files changed, 42 insertions(+)
diff --git a/rust/helpers/time.c b/rust/helpers/time.c
index a318e9fa4408..67a36ccc3ec4 100644
--- a/rust/helpers/time.c
+++ b/rust/helpers/time.c
@@ -33,3 +33,8 @@ s64 rust_helper_ktime_to_ms(const ktime_t kt)
{
return ktime_to_ms(kt);
}
+
+void rust_helper_udelay(unsigned long usec)
+{
+ udelay(usec);
+}
diff --git a/rust/kernel/time/delay.rs b/rust/kernel/time/delay.rs
index eb8838da62bc..fb7c15dfe186 100644
--- a/rust/kernel/time/delay.rs
+++ b/rust/kernel/time/delay.rs
@@ -47,3 +47,40 @@ pub fn fsleep(delta: Delta) {
bindings::fsleep(delta.as_micros_ceil() as c_ulong)
}
}
+
+/// Inserts a delay based on microseconds with busy waiting.
+///
+/// Equivalent to the C side [`udelay()`], which delays in microseconds.
+///
+/// `delta` must be within `[0, `MAX_UDELAY_MS`]` in milliseconds;
+/// otherwise, it is erroneous behavior. That is, it is considered a bug to
+/// call this function with an out-of-range value, in which case the function
+/// will insert a delay for at least the maximum value in the range and
+/// may warn in the future.
+///
+/// The behavior above differs from the C side [`udelay()`] for which out-of-range
+/// values could lead to an overflow and unexpected behavior.
+///
+/// [`udelay()`]: https://docs.kernel.org/timers/delay_sleep_functions.html#c.udelay
+pub fn udelay(delta: Delta) {
+ const MAX_UDELAY_DELTA: Delta = Delta::from_millis(bindings::MAX_UDELAY_MS as i64);
+
+ let delta = if (Delta::ZERO..=MAX_UDELAY_DELTA).contains(&delta) {
+ delta
+ } else {
+ // TODO: Add WARN_ONCE() when it's supported.
+ MAX_UDELAY_DELTA
+ };
+
+ // SAFETY: It is always safe to call `udelay()` with any duration.
+ // Note that the kernel is compiled with `-fno-strict-overflow`
+ // so any out-of-range value could lead to unexpected behavior
+ // but won't lead to undefined behavior.
+ unsafe {
+ // Convert the duration to microseconds and round up to preserve
+ // the guarantee; `udelay()` inserts a delay for at least
+ // the provided duration, but that it may delay for longer
+ // under some circumstances.
+ bindings::udelay(delta.as_micros_ceil() as c_ulong)
+ }
+}
--
2.43.0
next prev parent reply other threads:[~2025-10-21 9:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 7:11 [PATCH v2 0/2] Add read_poll_count_atomic support FUJITA Tomonori
2025-10-21 7:11 ` FUJITA Tomonori [this message]
2025-10-21 12:08 ` [PATCH v2 1/2] rust: add udelay() function Danilo Krummrich
2025-10-21 14:39 ` Miguel Ojeda
2025-10-21 14:46 ` Danilo Krummrich
2025-10-21 14:58 ` Miguel Ojeda
2025-10-21 15:09 ` Danilo Krummrich
2025-10-21 15:13 ` Miguel Ojeda
2025-10-21 15:20 ` Danilo Krummrich
2025-10-22 10:32 ` FUJITA Tomonori
2025-10-22 14:11 ` Alice Ryhl
2025-10-23 5:19 ` FUJITA Tomonori
2025-10-24 8:23 ` Andreas Hindborg
2025-10-24 8:20 ` Andreas Hindborg
2025-10-24 9:27 ` Alice Ryhl
2025-10-24 19:05 ` Miguel Ojeda
2025-10-26 13:11 ` FUJITA Tomonori
2025-10-26 14:49 ` Miguel Ojeda
2025-10-21 7:11 ` [PATCH v2 2/2] rust: Add read_poll_count_atomic function FUJITA Tomonori
2025-10-21 12:35 ` Danilo Krummrich
2025-10-21 14:05 ` Alice Ryhl
2025-10-21 16:02 ` Danilo Krummrich
2025-10-22 11:27 ` FUJITA Tomonori
2025-10-24 8:25 ` Andreas Hindborg
2025-10-24 9:19 ` Alice Ryhl
2025-10-23 5:24 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021071146.2357069-2-fujita.tomonori@gmail.com \
--to=fujita.tomonori@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=frederic@kernel.org \
--cc=gary@garyguo.net \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).