From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010006.outbound.protection.outlook.com [52.101.201.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C43921CC44; Mon, 27 Oct 2025 21:21:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.6 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761600100; cv=fail; b=QQLCIOUWBQz0HsJp6FEhcy+kECcL6PZhghoUQl8GVGI9zQJAmzRlKaT5LYDztHegYYcFhg9uYEH6txqZGyX6KUJNwmTYLLMij33Jso02dQ3dA57xK1tXmKfFwLqDGNAV3skLC167ecLtR+TrI0Xt5tw8UzmccYqcoRV1OH9ec5U= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761600100; c=relaxed/simple; bh=FdocgQcK0oP3JkW9OX/b6rMk4ggdN+zJS1yUNw15wPE=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=qw2pIr5mnSPlGyTB1LFri9r2iQ2pthwW5bgXvAoqNM4vZrBY5H+Rku80x5d3wOQCdAuTaiAQ6iJout6gLZOWgwUwFRLjH0FJV1EEZmFxx/3PX5/0aZY5fxpyoZqDOQsDWvjy7+IVQz1HkrCfS5H8obeFNBoWx3wxdXnLap37BT0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=XrhGCqed; arc=fail smtp.client-ip=52.101.201.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="XrhGCqed" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RuczjaGexyBuW373vbQkO9+9gJ291/dSvQeJ+nYErQq41w7M5gBXKrPUFvPN90zwho/D82mSHLykattE8xUmaAhRA29JrBj5eBQsV/SA28MsusYwQu3x0omCHH9LGQJdt4bUFCUf4vLFg1aby2QLzcHWlFY5kPADoK1vg0pwlKDsPgP52HhqMNxtEJZWQVjTislM4ehaLlS+r99wkTySBl/+r09Nkj2A491XId4Moe4EQJ/J9oiy61txSrUo4AaasOdv1u69xQqb+Q+XrLVcjaJ0lIGsjCrki4T2x75vErBBheLHMowQdExpjrbD9H0y8tIK9LjvsECI2N6GQ21C6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7+aMftYLa5WfPYLN83Ny9RbTKHYS1glYOQl7bWX9ExU=; b=lNYdqhkGvqwihos6tV6CX9xKDsOqpIl318gCC7BV3IOveFnEyoaGfJxLWujRp/9YPRF40nsMY2GaEhY8uMUFpe2Z4pZ/9kbb0JVaDTmq5AT4Gfe1mQGlCZMIx9CmQgEUo/51tcUnQfw8GUEaMZoEpaEZ/7X7L/NPM4grLnXEmejYFEej42YtueUb1o4c4UyIOwxxI7/66CN88J1aKl57T7OW/RSA26/OmgMiexQVs1GWCX1eWeo1ioKEYAu2NQFnXzBTFIBFkSg6yK7sWvRWir+LivVEdPdNQdi2bQpOgS07VXIyzhjw0R+adn9uBOZwTKO1A0jOyHd4bftRU3adEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7+aMftYLa5WfPYLN83Ny9RbTKHYS1glYOQl7bWX9ExU=; b=XrhGCqedGjnGkT7fcFiZaMQVmgw0zyo5BvaRe3Qx+80Qz6ruAIGfjYB/32n3sZVhm+QMmJzbmCXZMH8oLLcXOpB/Mjp1MiRCem9jZolDmJpj2IrEma5/ntRJFPLu2b14buKs3zHjtuZc7cwuAydqVtvt3sNWIoGYfaNnOEiI9arvb9vUw5EthyP49QxIXHdP7ZiP48ulsXQLUDX+l78GRQhwO3qcZirVNDc2ZTldo78OOO2MRSTnNFaFNBmQBjXBhCOXbp++y8D86WAutE31ln68Nx2XO0hcVmyu9GQMgvCxwcnPGGj+ch7Y9tPn7CvDtF9SGnMT3bKHYF39vr0NtQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from SN7PR12MB8059.namprd12.prod.outlook.com (2603:10b6:806:32b::7) by DS0PR12MB8480.namprd12.prod.outlook.com (2603:10b6:8:159::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9253.18; Mon, 27 Oct 2025 21:21:34 +0000 Received: from SN7PR12MB8059.namprd12.prod.outlook.com ([fe80::4ee2:654e:1fe8:4b91]) by SN7PR12MB8059.namprd12.prod.outlook.com ([fe80::4ee2:654e:1fe8:4b91%2]) with mapi id 15.20.9228.015; Mon, 27 Oct 2025 21:21:34 +0000 Date: Mon, 27 Oct 2025 17:21:33 -0400 From: Joel Fernandes To: John Hubbard Cc: Danilo Krummrich , Alexandre Courbot , Timur Tabi , Alistair Popple , Edwin Peer , Zhi Wang , David Airlie , Simona Vetter , Bjorn Helgaas , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, LKML Subject: Re: [PATCH 2/2] gpu: nova: add boot42 support for next-gen GPUs Message-ID: <20251027212133.GA298309@joelbox2> References: <20251025001459.491983-1-jhubbard@nvidia.com> <20251025001459.491983-3-jhubbard@nvidia.com> <50acc826-dbe7-42bf-9645-ad5aa47a3d17@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50acc826-dbe7-42bf-9645-ad5aa47a3d17@nvidia.com> X-ClientProxiedBy: MN2PR11CA0007.namprd11.prod.outlook.com (2603:10b6:208:23b::12) To SN7PR12MB8059.namprd12.prod.outlook.com (2603:10b6:806:32b::7) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR12MB8059:EE_|DS0PR12MB8480:EE_ X-MS-Office365-Filtering-Correlation-Id: a05ac88b-543e-48aa-8285-08de159ece5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7Eri5EpXHCKVfWvIO5potjTSbLtSsO5XQbrAAVLUIRTEUtyHn4m5YrDpfG1S?= =?us-ascii?Q?tJPi/5lQVRS2E2t4sB8HaDFZfdTLoEMdeK8oZvxn1fKfphabSMcloD0r8Xi9?= =?us-ascii?Q?XnvbtTorpv/nj4MeyIVu3R7VlJdz8VgAUKt+nutunVz3eRfbHBcWcbaQCFis?= =?us-ascii?Q?ZnIRkYr2duEz+pIGGpNLqaZtJZrkxFT8eCPiXluCEZ1y4uT6fiHfDbQtNPtj?= =?us-ascii?Q?rYUIFjSJvkSyJuZFW4IPXrovoKUx2y45QgRosUsaJ29f/udjQXPkf/QhG2je?= =?us-ascii?Q?3CQ4UWtA3DAFR/gfa4AvjsX6ncP22c1y5lH0Nwd9XOooq01sOsXL2VIwR4mG?= =?us-ascii?Q?DLlKx5Wh0x6pI5zhdDWVe99LCwTnT5uCpACuAKllOFCXpsMSLS/aG5+k9d3v?= =?us-ascii?Q?fR82QwnIAswow6LR+MsYsu2OzpjbzxBoTb2iPJg8wg6wacCAD0XeORaXHHKd?= =?us-ascii?Q?fZrgu+9wIHmhtpYbpoaCavH0gijMPpGuuc0e6GFCLIgcBBfUAVjGs3xZjRw+?= =?us-ascii?Q?tNf7eWj4yu6hAwfs6TdNqcNrgKAnL1yMjxrFtmSg4t0k8jt6uHv9ZsdNWIMw?= =?us-ascii?Q?BiZkktLcugOEpBPJpRVHkxG70iSPz6NhUAN5MV+MBFxzRr0ecL18+mlG0BwU?= =?us-ascii?Q?3MMU2fTgWlZwYokaZLLeNLxDg6Dzlo6PZQiSXwCJ3ayRAcCUYnRgsyZ5v/c2?= =?us-ascii?Q?wpYpor1iT3yXtc7OKTmB02nc8ZXZ95zOoAhLs/Mim4foVLvIaexJmO81Yp0d?= =?us-ascii?Q?C0Bex3EiZp/ewfS9cWjkLc1lxdCZSwsIW37ipxu/9e6RD5T7HDxlLBYZl4MN?= =?us-ascii?Q?2B1rSB/j2OznMb9tm9JICGLCPilIgwHvjIrbk14mU6mud3io2i6PMDycahaU?= =?us-ascii?Q?2WdP0HS8U6WSL51IHRhyvgXyWsz//ZSzDOjhGKUXwvMd8f2ZDek+7LqAllAr?= =?us-ascii?Q?vfB1oLtEGD2n6DIwQKeksz7m8QuSc1T/osMlOT39oyD0cxl2zQK8UQ5GbYdm?= =?us-ascii?Q?CP6cZT2q15WrB80h9MSy4ha/1cmmdD3sjIlCXE7/hgk7Bhry3gOLNwrEBBlW?= =?us-ascii?Q?n38nLYtMUilde64XssW5ZbqN/e//6eIwcgEOwJQxqb7RPPLbpPWMDWKsG0Pt?= =?us-ascii?Q?JJshY4GJPVE+zaF+p4mneaR4uH6gK+SatxtVowG3MNEvoAKHFW7x5p7ykISE?= =?us-ascii?Q?75WmkMRezk5p8vKTzrl91fnfALZp4VJ13tO1yLTFA+sXmM8FElY2VCfqytRb?= =?us-ascii?Q?BwNdzlpoMLCMHTCjbD9coFzfG7LdT/n8DgTn1T2egNSxUAZVDHwstzsQsVc2?= =?us-ascii?Q?EFUG2/Mvlua20qo02ZsH7RslfzC9CbdyVKqeNIyWGiMrMZDr60OwY+gKFPaD?= =?us-ascii?Q?dqRnAh69ZmujaWjkZegWhktXBqPbB7hjBp+1oWO7iLtPxF+23T3DeMWzYoad?= =?us-ascii?Q?rp6MHxy4ce7b6jD5fiqmdyR8F3DrUjcf?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR12MB8059.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3I/eCiURSjxw2jMb1fR2tU3NpQ7Me/413cUplmCpUCkaCzUDM9cz0bLaRItt?= =?us-ascii?Q?ZIc+Pl3oFmop+6mu4TrNZz7YFqycIcH4R67MrDiTmzjt1Vu5GQAqH70ALHoH?= =?us-ascii?Q?gZ6kTRWm0O/2+7snIK89Kl4I3hthhgAWZlYZKgg8CIGSpZFY+ZRBRJLIJveK?= =?us-ascii?Q?aGbwI6Ul5UG42qddf9jLRR5IUAba0NX8m1OcSysKTsvBTfv7SX8uKR2gw2Om?= =?us-ascii?Q?tFhPe0Yjc45GOO/zFoA30w/BdVfOWvvkcXq0RzBtpVeUAErRw9nlPzD2OxlJ?= =?us-ascii?Q?SSgu5CaHwmSpbMef4y25KBWB2QOmGRt/XOrqYmNpsCPqeQI+jvDBAql0qot4?= =?us-ascii?Q?rgiQy4+gjNHU5KJiWEPdaVMbvPXPKfWj9CuBzTxvOp0NPpCe/Xdat9218IS7?= =?us-ascii?Q?otIbgr4f9XX5+3TNfTnJ/gYS/tazQkLCyfSMDBB7HfjXUcD4EmBGMLdtGfPq?= =?us-ascii?Q?WbjCwSrX20iAN7oa87Nt2F68w1GCpiYvWLWuhTNgkBC4NQcV+YDmzVMfpfKB?= =?us-ascii?Q?0/xYiDK3KJhPA5kBgz+HXy3OmzGYGJ7kSDnuHsAAvPxlWq6m1t6nR7aZNl3v?= =?us-ascii?Q?8PfgpiliVsGUL2AFIliKm/mQIIekyoudwZr/11Soa0QneqrZ1oFEmtI7wlfL?= =?us-ascii?Q?31lJbnViRsKXKjL1XpTt5lxgTpcEcBu+Xv0aX6E6K5uYmRJ6vH2l08EpY7BZ?= =?us-ascii?Q?QmFsCThedjocnqYha1AcjEmOYjCmHnTHNxSZyGTaJI2zMut78d4I7QrCJRa4?= =?us-ascii?Q?02mhI0hK/pTF2tmeqzVc0uMvn0XrWUWBtpN6/6QEQSC/U/fekOGtYotHtB6o?= =?us-ascii?Q?nIbDkzQblX0rlAN0P9Jdm7tv/lS4Ye9L98+omANhmniQ7+St+55i1Bbq5ZPf?= =?us-ascii?Q?6ITVQH0KAiIlSJY/oRdzWAWT2lQQNGI64Zuen3zehIPfZeEEC4sdyXbagMHO?= =?us-ascii?Q?cDgH/v16IiCB7KuVd1wODnbcsPjCLsXnCAy9Z3SrZREBaquDXrQubJB7pKW7?= =?us-ascii?Q?OuBm9OLCB06rRKkLiBKclt0J6p2BZmtDjfOUlin1y6uFp8htJFGQAUhjKrDh?= =?us-ascii?Q?t2a5caMmcFn8GxuQ84097u55AUzbm3FtOJfQiZz9wo6RrOJ7/tiE2pT2wMbO?= =?us-ascii?Q?IbXeY4lHwQUjVIUjcF7dkocdIozqaXaMyadVuO6No4NMOb7QjUTYeh2TWmIA?= =?us-ascii?Q?XJ5Vj6FelejDEQLAXtCpczJchFxoe0Q+xwmOzUgitwKKoDvFFeTvtggWk7lv?= =?us-ascii?Q?YEWVNB3dyRs8u87sGXAd7Pnv4jSYhNNJDnshqLY/d7qHsGDtElWTDvRgedPG?= =?us-ascii?Q?e4DAN66Gvn972AIPQgKyQAhXazes8d/wNOSHqjNKeBrsdOfmOac1qw+dQSif?= =?us-ascii?Q?COoD0xPu5kpol9bZN3zDaSiffVCOFxCaBf7Z9TneYysvs2KuuSe0fJ5i/BOS?= =?us-ascii?Q?O6dO0oxp702vtk2OWnV7QtJZgjwfOQYRFdczsHGAKBUp3Muh5dMSReM+MP+g?= =?us-ascii?Q?Gr4Yqk7XGqiLiIJlNlucd4B0Ysg5NJmwaS3pFr4W0sParfMfRtqsh/9TCJ+X?= =?us-ascii?Q?Cryv/kyxtrKYIEBCmSUl90XnV7fwrkSbpHB7U8VH?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a05ac88b-543e-48aa-8285-08de159ece5c X-MS-Exchange-CrossTenant-AuthSource: SN7PR12MB8059.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2025 21:21:34.6301 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0PQYqiJQrbN229u/cl7yNN7FCokrBSNmFfS4SO2kvmOrIwOY0MD+d1p6ldEenXqBmMEl9DLsTbSVM3EYJH4jsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8480 On Sat, Oct 25, 2025 at 10:32:35AM -0700, John Hubbard wrote: > On 10/25/25 3:01 AM, Danilo Krummrich wrote: > > On Sat Oct 25, 2025 at 2:14 AM CEST, John Hubbard wrote: > ...> Why open code all of the above in the struct Gpu constructor? This > could all > > happen within Spec::new(). > > > > OK, yes, that does help avoid cluttering up Gpu::new(). +1. Also, it bloats up the dev_info! print in Gpu::new() to those. Spec can encapsulate the boot0 vs boot42 code, and any further changes. But otherwise, the boot0 vs boot42 code in the patchset look good to me. thanks, - Joel