From: Zhi Wang <zhiw@nvidia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: <rust-for-linux@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <dakr@kernel.org>,
<aliceryhl@google.com>, <bhelgaas@google.com>,
<kwilczynski@kernel.org>, <ojeda@kernel.org>,
<alex.gaynor@gmail.com>, <boqun.feng@gmail.com>,
<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
<lossin@kernel.org>, <a.hindborg@kernel.org>, <tmgross@umich.edu>,
<markus.probst@posteo.de>, <helgaas@kernel.org>,
<cjia@nvidia.com>, <smitra@nvidia.com>, <ankita@nvidia.com>,
<aniketa@nvidia.com>, <kwankhede@nvidia.com>,
<targupta@nvidia.com>, <acourbot@nvidia.com>,
<joelagnelf@nvidia.com>, <jhubbard@nvidia.com>,
<zhiwang@kernel.org>
Subject: Re: [PATCH v5 2/7] rust: devres: style for imports
Date: Thu, 6 Nov 2025 17:10:26 +0200 [thread overview]
Message-ID: <20251106171021.3e724b36.zhiw@nvidia.com> (raw)
In-Reply-To: <CANiq72kE9QFdAP2cTjBaxwsQ_H=BmMyabY9vSWUdfj0Ai0QZCA@mail.gmail.com>
On Thu, 6 Nov 2025 14:34:25 +0100
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> On Thu, Nov 6, 2025 at 11:28 AM Zhi Wang <zhiw@nvidia.com> wrote:
> >
> > +/// device::{Bound, Device},
>
> Is this one converted?
>
> > + /// # use kernel::{
> > + /// device::Core,
>
> This hides only the first line, which will look quite confusing when
> rendered -- please double-check with the `rustdoc` target.
>
Thanks for the pointer. Let me take a look and fix it in the next
re-spin.
> Thanks!
>
> Cheers,
> Miguel
next prev parent reply other threads:[~2025-11-06 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 10:27 [PATCH v5 0/7] rust: pci: add config space read/write support Zhi Wang
2025-11-06 10:27 ` [PATCH v5 1/7] samples: rust: rust_driver_pci: use "kernel vertical" style for imports Zhi Wang
2025-11-06 10:27 ` [PATCH v5 2/7] rust: devres: " Zhi Wang
2025-11-06 13:34 ` Miguel Ojeda
2025-11-06 15:10 ` Zhi Wang [this message]
2025-11-06 10:27 ` [PATCH v5 3/7] rust: io: " Zhi Wang
2025-11-06 10:27 ` [PATCH v5 4/7] rust: io: factor common I/O helpers into Io trait Zhi Wang
2025-11-06 10:27 ` [PATCH v5 5/7] rust: io: factor out MMIO read/write macros Zhi Wang
2025-11-06 10:27 ` [PATCH v5 6/7] rust: pci: add config space read/write support Zhi Wang
2025-11-06 16:30 ` Danilo Krummrich
2025-11-06 17:43 ` Zhi Wang
2025-11-06 10:27 ` [PATCH v5 7/7] sample: rust: pci: add tests for config space routines Zhi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106171021.3e724b36.zhiw@nvidia.com \
--to=zhiw@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=cjia@nvidia.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=helgaas@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=kwankhede@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=smitra@nvidia.com \
--cc=targupta@nvidia.com \
--cc=tmgross@umich.edu \
--cc=zhiwang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).