From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A5C2310631 for ; Mon, 10 Nov 2025 13:06:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762779978; cv=none; b=mLHKHfxjeCK2Ib7FQhFEF5sybCsnSfSyG+14jTUa2f8ck9VuAe6Wr6qjyARZ+yTri1R0ikOS5zD4pb3lwcKigvFczBKkKXS0VeDEvREsOQz1RecqiCOuMaBxcbnZDotgupmlj/zWIO/yce/dcJt0T/L04QlFD1SWMj4Il+yQCKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762779978; c=relaxed/simple; bh=Lz6COCva7yG6KNSx8r9nfcyJx0BW/9KhmoJVhFJNDyY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ZnHvDObwekLFXinI8Dq3rsKQ0iMpLIMaqxEBybdQAAlKtT9j8iy4FLV84CHcMGULzF/vndUxTzgf+s5uk64y4c6VpviLL0DKwh7ZBBn18pbFXSjRs9cvGYCsUf8mxdgIvYIEIqgOtIjByAGfZQ0sokXRz9Bc9Kp4owBJ4ftnnxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=M0/81zFE; arc=none smtp.client-ip=209.85.221.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="M0/81zFE" Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-42b2f79759bso1409676f8f.2 for ; Mon, 10 Nov 2025 05:06:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1762779974; x=1763384774; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=gS41oALaXXy1Rj0bz/L9Rj/ludgCw5mZxJ04H0Sb1qA=; b=M0/81zFE9ssfRwqurPqbPl09AHHAA4cLIzFfRNlrm9H5iSfNS/Rj7Y0sgX9VlyQmmB X2ICLRdw+SAPOduTKvunhktGkALIMYPbViQkn89i0BGIfIKxC9Uf3V5/A0Tzu/Lr3UfN /e3V9E8r+KcXji9JdiDvMxn+J/Vl2tRZInPoeF+y0n/YLluPgVap3fiFvOrWE3wJyMfZ 93G4u1zSsIamyWWIPue/CI6AdLI0Hfuw+r32ZkZen5SyhtCWQcmmyyPq7aN0xirsTw7c C5nW921Es3tltu3lyCVTEw+YTd9EXQ3GmBTCxx9oDj3kB1+n1E46vYV6P3s5OyGfwkmE dTnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762779974; x=1763384774; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gS41oALaXXy1Rj0bz/L9Rj/ludgCw5mZxJ04H0Sb1qA=; b=U2QDLl9VTdgRxCI/GjJaCxSO+asUlc+iwCloEGzsDqh3woHkfvLnb0lMo+RIn6VYnG tWTR4O2aJsef5R/z09u1lybECUftH9NcKhDRzpoyVONnCIeYDBg6ipgpdLR6KIywIB4M h8afVEW+uyU9Z/O/vjWliitxwX8HDtZvp6f9m0hH4+7tEF2t9kyf/cBGQMOoQsKiQ4sN gFhSuD6eKIVoKQj46cqzMDI4LQ3OZIMD3TL94PYN4BKyaYE2UMUzvMeZGABpJeUNFjsV orxsx2Mw/8ciXMsZd8zk8QKZtUmPVpzl5a31jjDmuFnUHooMvHs6bKahjDGHmGYed6RJ 2YhA== X-Forwarded-Encrypted: i=1; AJvYcCUjXbmEy5lwNY8ct1OgG9bW2SM2L9Gqv4SFJOzHhrUREnla8aNsLJHvkcnHeUKbFqc0zP4Ko74yKMfolvMPvQ==@vger.kernel.org X-Gm-Message-State: AOJu0YxUAjOgI/KF43mKlTkcUPcqE9NJFZrPIbmJcOEGQbY2+lZIFx8u /q1gpzagZAJtedPqyDNRzfbDS3F1d9yWeXFXdYeh48r444yADCWcIgjsLmrj4Y2KiEMJ/X+XlQ0 gz5wCjSAZmsmmMX2x2Q== X-Google-Smtp-Source: AGHT+IGlOVyTmUXKrCuFsOI6dOMwcSdmtb1mLdvS6be1D0Wm7u7bVMnUILhedvTgwRdfrttqFRSVLcINP+0G8zw= X-Received: from wroz11.prod.google.com ([2002:adf:f1cb:0:b0:429:bb75:80ae]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:18a3:b0:429:8b47:2f35 with SMTP id ffacd0b85a97d-42b2dc23fafmr7775853f8f.26.1762779974157; Mon, 10 Nov 2025 05:06:14 -0800 (PST) Date: Mon, 10 Nov 2025 13:05:54 +0000 In-Reply-To: <20251110-binder-bitmap-v4-0-5ed8a7fab1b9@google.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251110-binder-bitmap-v4-0-5ed8a7fab1b9@google.com> X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=2618; i=aliceryhl@google.com; h=from:subject:message-id; bh=Lz6COCva7yG6KNSx8r9nfcyJx0BW/9KhmoJVhFJNDyY=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBpEeND3kEbJSfW34TbElEzLRGE+NXAamJaABVG7 P46pIIJws2JAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCaRHjQwAKCRAEWL7uWMY5 Rso9EACKo86FEsGZCtPzS9tIoQ7FfSam1lLZIBWn86nSeWY+SWQNSlGpatXzASBOU2bK00hyOmt mbdowJtTebDhaZiFbmposRFoKSSg88tWDSZ9qfoQdyKzfxutcRHrZqaHUDad4pNcLhOi9SLSkb3 4cdWprRWaLwVVl+YERHb0rCXbAIqECR39aPwJzdORYetKhzUEBLXaeFRNBfzSWFL8ElWQcGuvVf 8pqS/C+aBhFsigs5xsaGXD6yBIhd1lIhm2RUBj+tt3MCZg+IdJHSMQcJGu1Oz/mfcnIVknnbftg f3r2oSvtV/1uCrPNnsXg7kRClqnVSFPpTqvdiMfK3vBe51Hw5tuTvWsOXmflvzmJeGt0y7WiGkc /aa060ckj+ngLAL+UQpFU+YCOzqARJWogWsZnNbbs6JhXyD2VHtHcKZj04++u2fr1c3LNUp6xVG VQRucQz/E+m9c4amfrB5QqWe0KkWoohHWikjrPWxNc1K8fPjO2i0mQR9HKuCF1anOPrBbxMXXON TWzy2aALpkj2LyalLESW4PFwUP8a+BtWNqIhHKyv31kTzle87G34ccX46uh2PqTD/XmandoO6Ds LVtQav4B92m2FZyczcEduwCZ5QCCsNfQbdNoFoO/9sAml0Yw9Wy1tQTn37Uv8/V+h9wp/YzXL3D gDPoC9/EOtSj3xA== X-Mailer: b4 0.14.2 Message-ID: <20251110-binder-bitmap-v4-1-5ed8a7fab1b9@google.com> Subject: [PATCH v4 1/6] rust: bitmap: add MAX_LEN and NO_ALLOC_MAX_LEN constants From: Alice Ryhl To: Greg Kroah-Hartman , Yury Norov Cc: "=?utf-8?q?Arve_Hj=C3=B8nnev=C3=A5g?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Burak Emir , Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?q?Bj=C3=B6rn_Roy_Baron?=" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alice Ryhl Content-Type: text/plain; charset="utf-8" To avoid hard-coding these values in drivers, define constants for them that drivers can reference. Acked-by: Danilo Krummrich Reviewed-by: Burak Emir Signed-off-by: Alice Ryhl --- rust/kernel/bitmap.rs | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/rust/kernel/bitmap.rs b/rust/kernel/bitmap.rs index aa8fc7bf06fc99865ae755d8694e4bec3dc8e7f0..15fa23b45054b9272415fcc000e3e3b52c74d7c1 100644 --- a/rust/kernel/bitmap.rs +++ b/rust/kernel/bitmap.rs @@ -149,14 +149,14 @@ macro_rules! bitmap_assert_return { /// /// # Invariants /// -/// * `nbits` is `<= i32::MAX` and never changes. +/// * `nbits` is `<= MAX_LEN`. /// * if `nbits <= bindings::BITS_PER_LONG`, then `repr` is a `usize`. /// * otherwise, `repr` holds a non-null pointer to an initialized /// array of `unsigned long` that is large enough to hold `nbits` bits. pub struct BitmapVec { /// Representation of bitmap. repr: BitmapRepr, - /// Length of this bitmap. Must be `<= i32::MAX`. + /// Length of this bitmap. Must be `<= MAX_LEN`. nbits: usize, } @@ -226,10 +226,16 @@ fn drop(&mut self) { } impl BitmapVec { + /// The maximum possible length of a `BitmapVec`. + pub const MAX_LEN: usize = i32::MAX as usize; + + /// The maximum length that avoids allocating. + pub const NO_ALLOC_MAX_LEN: usize = BITS_PER_LONG; + /// Constructs a new [`BitmapVec`]. /// /// Fails with [`AllocError`] when the [`BitmapVec`] could not be allocated. This - /// includes the case when `nbits` is greater than `i32::MAX`. + /// includes the case when `nbits` is greater than `MAX_LEN`. #[inline] pub fn new(nbits: usize, flags: Flags) -> Result { if nbits <= BITS_PER_LONG { @@ -238,11 +244,11 @@ pub fn new(nbits: usize, flags: Flags) -> Result { nbits, }); } - if nbits > i32::MAX.try_into().unwrap() { + if nbits > Self::MAX_LEN { return Err(AllocError); } let nbits_u32 = u32::try_from(nbits).unwrap(); - // SAFETY: `BITS_PER_LONG < nbits` and `nbits <= i32::MAX`. + // SAFETY: `BITS_PER_LONG < nbits` and `nbits <= MAX_LEN`. let ptr = unsafe { bindings::bitmap_zalloc(nbits_u32, flags.as_raw()) }; let ptr = NonNull::new(ptr).ok_or(AllocError)?; // INVARIANT: `ptr` returned by C `bitmap_zalloc` and `nbits` checked. -- 2.51.2.1041.gc1ab5b90ca-goog