rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Onur Özkan" <work@onurozkan.dev>
To: rust-for-linux@vger.kernel.org
Cc: lossin@kernel.org, lyude@redhat.com, ojeda@kernel.org,
	alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
	a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
	dakr@kernel.org, peterz@infradead.org, mingo@redhat.com,
	will@kernel.org, longman@redhat.com, felipe_life@live.com,
	daniel@sedlak.dev, bjorn3_gh@protonmail.com,
	daniel.almeida@collabora.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/6] rust: add `ww_mutex` support
Date: Mon, 10 Nov 2025 08:28:14 +0300	[thread overview]
Message-ID: <20251110082814.428ead91@nimda.home> (raw)
In-Reply-To: <20251101161056.22408-1-work@onurozkan.dev>

On Sat,  1 Nov 2025 19:10:50 +0300
Onur Özkan <work@onurozkan.dev> wrote:

> Changes in v7:
>   - Split Class and AcquireCtx into separate modules.
>   - Removed "Ww" prefixes from type names.
>   - Renamed exec.rs -> lock_set.rs and ExecContext -> LockSet.
>   - Removed transmute logic from LockSet (formerly ExecContext).
>   - Improved various doc-comments.
>   - Marked certain AcquireCtx functions as unsafe.
>   - Added from_raw constructors for Mutex, MutexGuard, AcquireCtx
>     and Class.
>   - LockSet::cleanup_on_deadlock no longer triggers reallocations when
>     reinitializing AcquireCtx.
>   - Incorporated various minor improvements suggested on the v6
> series.
> 
> Changes in v6:
>   - Added `unpinned_new` constructor for `WwClass` and updated
>     global macros.
>   - Changed all tests (and docs) to use Arc/KBox instead of
>     `stack_pin_init` for `WwMutex` and `WwAcquireCtx`.
>   - Added `LockKind` and `lock_common` helper to unify locking logic.
>   - Added context-based and context-free locking functions for
> `WwMutex`.
>   - Added `ww_mutex/exec` module, a high-level API with auto `EDEADLK`
>     handling mechanism.
> 
> Changes in v5:
>   - Addressed documentation review notes.
>   - Removed `unwrap()`s in examples and KUnit tests.
> 
> Onur Özkan (6):
>   rust: add C wrappers for ww_mutex inline functions
>   rust: implement `Class` for ww_class support
>   rust: error: add EDEADLK
>   rust: ww_mutex: add Mutex, AcquireCtx and MutexGuard
>   rust: ww_mutex: implement LockSet
>   rust: add test coverage for ww_mutex implementation
> 
>  MAINTAINERS                                   |   1 +
>  rust/helpers/helpers.c                        |   1 +
>  rust/helpers/ww_mutex.c                       |  39 ++
>  rust/kernel/error.rs                          |   1 +
>  rust/kernel/sync/lock.rs                      |   1 +
>  rust/kernel/sync/lock/ww_mutex.rs             | 440
> ++++++++++++++++++ rust/kernel/sync/lock/ww_mutex/acquire_ctx.rs |
> 211 +++++++++ rust/kernel/sync/lock/ww_mutex/class.rs       | 156
> +++++++ rust/kernel/sync/lock/ww_mutex/lock_set.rs    | 410
> ++++++++++++++++ 9 files changed, 1260 insertions(+)
>  create mode 100644 rust/helpers/ww_mutex.c
>  create mode 100644 rust/kernel/sync/lock/ww_mutex.rs
>  create mode 100644 rust/kernel/sync/lock/ww_mutex/acquire_ctx.rs
>  create mode 100644 rust/kernel/sync/lock/ww_mutex/class.rs
>  create mode 100644 rust/kernel/sync/lock/ww_mutex/lock_set.rs
> 

I forgot to include the Zulip discussion link [1], which I believe
would be quite useful. I am adding this as a self-review note to make
sure I include it in the next version.

[1]:
https://rust-for-linux.zulipchat.com/#narrow/stream/x/topic/x/near/547854930


Regards,
Onur

      parent reply	other threads:[~2025-11-10  5:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-01 16:10 [PATCH v7 0/6] rust: add `ww_mutex` support Onur Özkan
2025-11-01 16:10 ` [PATCH v7 1/6] rust: add C wrappers for ww_mutex inline functions Onur Özkan
2025-11-21 19:08   ` Lyude Paul
2025-11-01 16:10 ` [PATCH v7 2/6] rust: implement `Class` for ww_class support Onur Özkan
2025-11-21 19:15   ` Lyude Paul
2025-11-01 16:10 ` [PATCH v7 3/6] rust: error: add EDEADLK Onur Özkan
2025-11-21 19:49   ` Lyude Paul
2025-11-01 16:10 ` [PATCH v7 4/6] rust: ww_mutex: add Mutex, AcquireCtx and MutexGuard Onur Özkan
2025-11-21 21:00   ` Lyude Paul
2025-11-01 16:10 ` [PATCH v7 5/6] rust: ww_mutex: implement LockSet Onur Özkan
2025-11-21 22:34   ` Lyude Paul
2025-11-01 16:10 ` [PATCH v7 6/6] rust: add test coverage for ww_mutex implementation Onur Özkan
2025-11-10  5:28 ` Onur Özkan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251110082814.428ead91@nimda.home \
    --to=work@onurozkan.dev \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=daniel@sedlak.dev \
    --cc=felipe_life@live.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=mingo@redhat.com \
    --cc=ojeda@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).