From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 738B0301701; Mon, 10 Nov 2025 09:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762768333; cv=none; b=J4iYR2P+UIbZLLA5Xs1FtrxL9Uq50kKNCNFL0Y9eArNp3uD1NJv67hPeaZaj+HxAHnngtqHrxtz5vpR3BiE7yzkeyDbANHbKYI2Jt44bPGFMg4oU6cJotMZytwmdA1LXtFNss4AhL7xDDHa5SQO1PH3OPkN3nQ1nai3jvX3Jork= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762768333; c=relaxed/simple; bh=o3btvzeHxMVgM0hJBQCMjEDCxNjsxB0EcAR+QZ0CiSM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gIEO96psPeGxbOHyfNI9VXL9oD0rujIQCcOA3dd8KS1D3gzsRpD1TqrMHPAzp2vTeUrCbug4LpWgyoa0qqX6FEa1ogW4IZf6RIGQKelEvsO6qQ8K3BoZZkRjtJsWMtUf7MFuYZf0OWeiPVaQMvaG6Y3FLYv6jLgvDjx17bbcI5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XZN1A7XW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XZN1A7XW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B9DFC4CEFB; Mon, 10 Nov 2025 09:52:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762768330; bh=o3btvzeHxMVgM0hJBQCMjEDCxNjsxB0EcAR+QZ0CiSM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XZN1A7XWFj23G7vnIdrtcEZkjpE6UwpoBu24VYxZPUUYhw4UEkTzMxqHa02hLDSxG vQ3MBQItq3irA2UMEmeIBgRX5iiQzTRKqdW++6jFFoHoXNuGhvtuPNcBwbEqFCeoHs ssL01MrWxHMBcxfz06XQwxXsH9Htv47x4hfU5PrgyLTTYg1iWlXZrNo7sgfwKBYM5U qeTMWUneP9UiwhNlcRk4cFR5mDi+hJm4l2IhailTUf7MRtl5jUbeKR5/KZGhEbjCmJ gnwrpKaCcWuKObrJcuKhqO+fRsKgKZnk1kK2fFxedcPaSgVuPbn58LRQmAbwHSCY9T Z4D0Ufzu48w7g== From: Miguel Ojeda To: Miguel Ojeda , Alex Gaynor , Nathan Chancellor , Nicolas Schier Cc: Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev Subject: [PATCH 16/18] rust: syn: remove `unicode-ident` dependency Date: Mon, 10 Nov 2025 10:50:21 +0100 Message-ID: <20251110095025.1475896-17-ojeda@kernel.org> In-Reply-To: <20251110095025.1475896-1-ojeda@kernel.org> References: <20251110095025.1475896-1-ojeda@kernel.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The `syn` crate depends on the `unicode-ident` crate to determine whether characters have the XID_Start or XID_Continue properties according to Unicode Standard Annex #31. However, we only need ASCII identifiers in the kernel, thus we can simplify the check and remove completely that dependency. Signed-off-by: Miguel Ojeda --- rust/syn/ident.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/syn/ident.rs b/rust/syn/ident.rs index 2c4b56505bec..03ccebf9c022 100644 --- a/rust/syn/ident.rs +++ b/rust/syn/ident.rs @@ -39,11 +39,11 @@ fn from(token: Token![_]) -> Ident { pub(crate) fn xid_ok(symbol: &str) -> bool { let mut chars = symbol.chars(); let first = chars.next().unwrap(); - if !(first == '_' || unicode_ident::is_xid_start(first)) { + if !(first == '_' || first.is_ascii_alphabetic()) { return false; } for ch in chars { - if !unicode_ident::is_xid_continue(ch) { + if !(ch == '_' || ch.is_ascii_alphanumeric()) { return false; } } -- 2.51.2