From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33B34257851; Wed, 12 Nov 2025 11:03:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762945382; cv=none; b=Wc6fPZqqjMJ7c6rsThcAwr8dBLXHt4WLG3M7BVzrdoLgW4Cznsd0gZCALHoeifr0cZz6rxTy1WSoyv2qk6CNyDNyhi+uX/7fRtI4cb1c7t/1o2oyW6shzsT5PKEGJBQ2XxVMmigp01MzDpMouyvN4cn+ZAPEQHxrThlnBBwm/7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762945382; c=relaxed/simple; bh=/u5MnjnF3/Bu8KkRAgxPegIr1lenIvjObOB7SUzMzFo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jMVwE9XTRKMRsP52+K/HzlJ9CwIjPT9Wz85Iy9GnI/5xgtbR7D6jIhu4u4ZE74yXQ3reD+SBzs2YKj1uLoUiRYz42jNiOrv7daECZGWMmpgmTGCCUp1COGiO7yQoXm8+1egpZfSZ/9pHefygYk0pKDpksAk0p+8HhuZmQfCJdH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2j4SKZeb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2j4SKZeb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77639C16AAE; Wed, 12 Nov 2025 11:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1762945381; bh=/u5MnjnF3/Bu8KkRAgxPegIr1lenIvjObOB7SUzMzFo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2j4SKZebb1k3Ets95RWpyujnTQgY4mn24TzJuDb5sk4zBq0BYOsV7g88Q9L/muWLQ urqWLyLq1/JtUIsCirsnvbAe1UC6LrK+mUE5XRW6MSK4zj0JCz6JhyQIFpm1fMGEfG YtMqRamUQrYD6ydGiWzSXEm/QklV3+la/7nzEWRg= Date: Wed, 12 Nov 2025 06:03:00 -0500 From: Greg Kroah-Hartman To: Miguel Ojeda Cc: Alice Ryhl , Carlos Llamas , Miguel Ojeda , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 0/3] rust_binder: fix unsoundness due to combining List::remove with mem:take Message-ID: <2025111251-discern-secluded-4cfb@gregkh> References: <20251111-binder-fix-list-remove-v1-0-8ed14a0da63d@google.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Nov 12, 2025 at 11:22:25AM +0100, Miguel Ojeda wrote: > On Tue, Nov 11, 2025 at 3:23 PM Alice Ryhl wrote: > > > > rust_binder: fix race condition on death_list > > rust_binder: avoid mem::take on delivered_deaths > > rust: list: add warning to List::remove docs about mem::take > > Greg et al.: please let me know if you are not taking the last one > together with the fixes (so that I pick it up). Otherwise, if you do: > > Acked-by: Miguel Ojeda I'll take all of these, thanks for the ack! greg k-h