From: Joel Fernandes <joelagnelf@nvidia.com>
To: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Danilo Krummrich <dakr@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>
Cc: Alistair Popple <apopple@nvidia.com>,
Miguel Ojeda <ojeda@kernel.org>,
Alex Gaynor <alex.gaynor@gmail.com>,
Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
bjorn3_gh@protonmail.com, Benno Lossin <lossin@kernel.org>,
Andreas Hindborg <a.hindborg@kernel.org>,
Alice Ryhl <aliceryhl@google.com>,
Trevor Gross <tmgross@umich.edu>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
John Hubbard <jhubbard@nvidia.com>, Timur Tabi <ttabi@nvidia.com>,
joel@joelfernandes.org,
Daniel Almeida <daniel.almeida@collabora.com>,
nouveau@lists.freedesktop.org, Lyude Paul <lyude@redhat.com>,
Joel Fernandes <joelagnelf@nvidia.com>
Subject: [PATCH v4 12/13] gpu: nova-core: gsp: Wait for gsp initialization to complete
Date: Wed, 12 Nov 2025 20:41:18 -0500 [thread overview]
Message-ID: <20251113014119.1286886-13-joelagnelf@nvidia.com> (raw)
In-Reply-To: <20251113014119.1286886-1-joelagnelf@nvidia.com>
From: Alistair Popple <apopple@nvidia.com>
This adds the GSP init done command to wait for GSP initialization
to complete. Once this command has been received the GSP is fully
operational and will respond properly to normal RPC commands.
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Alistair Popple <apopple@nvidia.com>
Co-developed-by: Joel Fernandes <joelagnelf@nvidia.com>
Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
---
drivers/gpu/nova-core/gsp/boot.rs | 2 ++
drivers/gpu/nova-core/gsp/commands.rs | 48 +++++++++++++++++++++++++--
2 files changed, 47 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/boot.rs
index e9be10374c51..c0afafbf35f6 100644
--- a/drivers/gpu/nova-core/gsp/boot.rs
+++ b/drivers/gpu/nova-core/gsp/boot.rs
@@ -236,6 +236,8 @@ pub(crate) fn boot(
};
GspSequencer::run(&mut self.cmdq, seq_params, Delta::from_secs(10))?;
+ commands::gsp_init_done(&mut self.cmdq, Delta::from_secs(10))?;
+
Ok(())
}
}
diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-core/gsp/commands.rs
index d5be3bf10684..07abfb54f9d7 100644
--- a/drivers/gpu/nova-core/gsp/commands.rs
+++ b/drivers/gpu/nova-core/gsp/commands.rs
@@ -1,17 +1,28 @@
// SPDX-License-Identifier: GPL-2.0
-use core::convert::Infallible;
+use core::{
+ array,
+ convert::Infallible, //
+};
use kernel::{
device,
pci,
prelude::*,
- transmute::AsBytes, //
+ time::Delta,
+ transmute::{
+ AsBytes,
+ FromBytes, //
+ }, //
};
use crate::{
gsp::{
- cmdq::CommandToGsp,
+ cmdq::{
+ Cmdq,
+ CommandToGsp,
+ MessageFromGsp, //
+ },
fw::{
commands::*,
MsgFunction, //
@@ -20,6 +31,37 @@
sbuffer::SBufferIter,
};
+/// Message type for GSP initialization done notification.
+struct GspInitDone {}
+
+// SAFETY: `GspInitDone` is a zero-sized type with no bytes, therefore it
+// trivially has no uninitialized bytes.
+unsafe impl FromBytes for GspInitDone {}
+
+impl MessageFromGsp for GspInitDone {
+ const FUNCTION: MsgFunction = MsgFunction::GspInitDone;
+ type InitError = Infallible;
+ type Message = GspInitDone;
+
+ fn read(
+ _msg: &Self::Message,
+ _sbuffer: &mut SBufferIter<array::IntoIter<&[u8], 2>>,
+ ) -> Result<Self, Self::InitError> {
+ Ok(GspInitDone {})
+ }
+}
+
+/// Waits for GSP initialization to complete.
+pub(crate) fn gsp_init_done(cmdq: &mut Cmdq, timeout: Delta) -> Result {
+ loop {
+ match cmdq.receive_msg::<GspInitDone>(timeout) {
+ Ok(_) => break Ok(()),
+ Err(ERANGE) => continue,
+ Err(e) => break Err(e),
+ }
+ }
+}
+
/// The `GspSetSystemInfo` command.
pub(crate) struct SetSystemInfo<'a> {
pdev: &'a pci::Device<device::Bound>,
--
2.34.1
next prev parent reply other threads:[~2025-11-13 1:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 1:41 [PATCH v4 00/13] nova-core: Complete GSP boot and begin RPC communication Joel Fernandes
2025-11-13 1:41 ` [PATCH v4 01/13] gpu: nova-core: falcon: Move waiting until halted to a helper Joel Fernandes
2025-11-13 1:41 ` [PATCH v4 02/13] gpu: nova-core: falcon: Move start functionality into separate helper Joel Fernandes
2025-11-13 1:41 ` [PATCH v4 03/13] gpu: nova-core: falcon: Move mbox functionalities into helper Joel Fernandes
2025-11-13 1:41 ` [PATCH v4 04/13] gpu: nova-core: falcon: Move dma_reset functionality " Joel Fernandes
2025-11-13 1:41 ` [PATCH v4 05/13] gpu: nova-core: gsp: Add support for checking if GSP reloaded Joel Fernandes
2025-11-13 1:41 ` [PATCH v4 06/13] gpu: nova-core: Add bindings required by GSP sequencer Joel Fernandes
2025-11-13 1:41 ` [PATCH v4 07/13] gpu: nova-core: Implement the " Joel Fernandes
2025-11-13 1:41 ` [PATCH v4 08/13] gpu: nova-core: sequencer: Add register opcodes Joel Fernandes
2025-11-13 1:41 ` [PATCH v4 09/13] gpu: nova-core: sequencer: Add delay opcode support Joel Fernandes
2025-11-13 1:41 ` [PATCH v4 10/13] gpu: nova-core: sequencer: Implement basic core operations Joel Fernandes
2025-11-13 1:41 ` [PATCH v4 11/13] gpu: nova-core: sequencer: Implement core resume operation Joel Fernandes
2025-11-13 1:41 ` Joel Fernandes [this message]
2025-11-13 1:41 ` [PATCH v4 13/13] gpu: nova-core: gsp: Retrieve GSP static info to gather GPU information Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113014119.1286886-13-joelagnelf@nvidia.com \
--to=joelagnelf@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).