From: Giuliano Procida <gprocida@google.com>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: "Sami Tolvanen" <samitolvanen@google.com>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@lists.linux.dev, stable@vger.kernel.org,
"Haiyue Wang" <haiyuewa@163.com>
Subject: Re: [PATCH v2] gendwarfksyms: Skip files with no exports
Date: Tue, 18 Nov 2025 14:57:36 +0000 [thread overview]
Message-ID: <20251118145741.1042013-1-gprocida@google.com> (raw)
In-Reply-To: <20251110131913.1789896-1-ojeda@kernel.org>
Hi.
> Thus do the last one: don't attempt to process files if we have no symbol
> versions to calculate.
This results in the -T foo option being ignored in the case there were
no symbols. I think it would be better, consistent with the
documentation and expectations, for the file to be produced empty.
This means that just the for loop should be skipped, say by adding the
condition there with &&.
If you disagree, then please update the documentation to match the new
behaviour.
Regards,
Giuliano.
next prev parent reply other threads:[~2025-11-18 14:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 13:19 [PATCH v2] gendwarfksyms: Skip files with no exports Miguel Ojeda
2025-11-10 14:23 ` Haiyue Wang
2025-11-10 14:57 ` Alice Ryhl
2025-11-10 16:48 ` Miguel Ojeda
2025-11-11 15:05 ` Alice Ryhl
2025-11-11 13:54 ` Miguel Ojeda
2025-11-11 13:58 ` Miguel Ojeda
2025-11-11 15:24 ` Sedat Dilek
2025-11-11 19:45 ` Miguel Ojeda
2025-11-17 5:28 ` Sedat Dilek
2025-11-17 7:04 ` Miguel Ojeda
2025-11-11 19:44 ` Miguel Ojeda
2025-11-18 14:57 ` Giuliano Procida [this message]
2025-11-18 16:20 ` Miguel Ojeda
2025-11-18 16:26 ` Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118145741.1042013-1-gprocida@google.com \
--to=gprocida@google.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=haiyuewa@163.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=stable@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).