rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
	"Linux Doc Mailing List" <linux-doc@vger.kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Benno Lossin" <lossin@kernel.org>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Gary Guo" <gary@garyguo.net>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 1/1] docs: makefile: move rustdoc check to the build wrapper
Date: Tue, 18 Nov 2025 20:11:52 +0100	[thread overview]
Message-ID: <20251118201152.038e2749@foz.lan> (raw)
In-Reply-To: <87seeb47pk.fsf@trenco.lwn.net>

Em Tue, 18 Nov 2025 09:38:15 -0700
Jonathan Corbet <corbet@lwn.net> escreveu:

> Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:
> 
> > On Mon, Nov 17, 2025 at 10:20:46AM +0100, Miguel Ojeda wrote:  
> >> On Mon, Nov 17, 2025 at 10:13 AM Mauro Carvalho Chehab
> >> <mchehab+huawei@kernel.org> wrote:  
> >> >
> >> > The makefile logic to detect if rust is enabled is not working
> >> > the way it was expected. Move it to be inside the wrapper
> >> > script.  
> >> 
> >> Hmm... Could the commit explain a bit why this didn't work and why now it does?  
> >
> > I don't know exactly why this was not working.  
> 
> I would feel a lot better if we knew what the real problem is before
> applying fixes for it.  Otherwise something seems certain to come and
> bite us at some point.

Me too, but the bug is very annoying ;-)

I'll try to seek for some time to better understand it, maybe
next week.

Thanks,
Mauro

  reply	other threads:[~2025-11-18 19:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1763370163.git.mchehab+huawei@kernel.org>
2025-11-17  9:12 ` [PATCH 1/1] docs: makefile: move rustdoc check to the build wrapper Mauro Carvalho Chehab
2025-11-17  9:20   ` Miguel Ojeda
2025-11-17 11:04     ` Mauro Carvalho Chehab
2025-11-18 16:38       ` Jonathan Corbet
2025-11-18 19:11         ` Mauro Carvalho Chehab [this message]
2025-11-18 20:32           ` Mauro Carvalho Chehab
2025-11-18 21:34             ` Miguel Ojeda
2025-11-18 21:40           ` Miguel Ojeda
2025-11-20 20:13             ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251118201152.038e2749@foz.lan \
    --to=mchehab+huawei@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=corbet@lwn.net \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).