From: Byungchul Park <byungchul@sk.com>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: Guangbo Cui <2407018371@qq.com>,
Liam.Howlett@oracle.com, amir73il@gmail.com,
andi.shyti@kernel.org, andrii@kernel.org, bsegall@google.com,
gregkh@linuxfoundation.org, linaro-mm-sig@lists.linaro.org,
link@vivo.com, linux-kernel@vger.kernel.org,
mark.rutland@arm.com, masahiroy@kernel.org,
mathieu.desnoyers@efficios.com, matthew.brost@intel.com,
max.byungchul.park@gmail.com, mcgrof@kernel.org,
melissa.srw@gmail.com, mgorman@suse.de, mhocko@kernel.org,
minchan@kernel.org, oleg@redhat.com, paulmck@kernel.org,
penberg@kernel.org, peterz@infradead.org, petr.pavlu@suse.com,
torvalds@linux-foundation.org, vincent.guittot@linaro.org,
will@kernel.org, yeoreum.yun@arm.com, ysk@kzalloc.com,
rust-for-linux@vger.kernel.org, ojeda@kernel.org,
gary@garyguo.net, lossin@kernel.org, a.hindborg@kernel.org,
aliceryhl@google.com, dakr@kernel.org, alex.gaynor@gmail.com,
bjorn3_gh@protonmail.com, kernel_team@skhynix.com
Subject: Re: [PATCH] rust: bindings: add `rust_helper_wait_for_completion` helper function
Date: Wed, 19 Nov 2025 18:38:29 +0900 [thread overview]
Message-ID: <20251119093829.GA20446@system.software.com> (raw)
In-Reply-To: <aN62F8t493R7UmCT@tardis.local>
On Thu, Oct 02, 2025 at 10:27:51AM -0700, Boqun Feng wrote:
> On Thu, Oct 02, 2025 at 10:06:17AM +0000, Guangbo Cui wrote:
> > > -extern void wait_for_completion(struct completion *);
> > > -extern void wait_for_completion_io(struct completion *);
> > > -extern int wait_for_completion_interruptible(struct completion *x);
> > > -extern int wait_for_completion_killable(struct completion *x);
> > > -extern int wait_for_completion_state(struct completion *x, unsigned int state);
> > > -extern unsigned long wait_for_completion_timeout(struct completion *x,
> > > +extern void __wait_for_completion(struct completion *);
> > > +extern void __wait_for_completion_io(struct completion *);
> > > +extern int __wait_for_completion_interruptible(struct completion *x);
> > > +extern int __wait_for_completion_killable(struct completion *x);
> > > +extern int __wait_for_completion_state(struct completion *x, unsigned int state);
> > > +extern unsigned long __wait_for_completion_timeout(struct completion *x,
> > > unsigned long timeout);
> > > -extern unsigned long wait_for_completion_io_timeout(struct completion *x,
> > > +extern unsigned long __wait_for_completion_io_timeout(struct completion *x,
> > > unsigned long timeout);
> > > -extern long wait_for_completion_interruptible_timeout(
> > > +extern long __wait_for_completion_interruptible_timeout(
> > > struct completion *x, unsigned long timeout);
> > > -extern long wait_for_completion_killable_timeout(
> > > +extern long __wait_for_completion_killable_timeout(
> > > struct completion *x, unsigned long timeout);
> > > extern bool try_wait_for_completion(struct completion *x);
> > > extern bool completion_done(struct completion *x);
> > > @@ -139,4 +134,79 @@ extern void complete(struct completion *);
> > > extern void complete_on_current_cpu(struct completion *x);
> > > extern void complete_all(struct completion *);
> > >
> > > +#define wait_for_completion(x) \
> > > +({ \
> > > + sdt_might_sleep_start_timeout(NULL, -1L); \
> > > + __wait_for_completion(x); \
> > > + sdt_might_sleep_end(); \
> > > +})
> >
> > The DEPT patch series changed `wait_for_completion` into a macro.
> > Because bindgen cannot handle function-like macros, this caused
> > Rust build errors. Add a helper function to fix it.
> >
> > ```
> > error[E0425]: cannot find function `wait_for_completion` in crate `bindings`
> > --> rust/kernel/sync/completion.rs:110:28
> > |
> > 110 | unsafe { bindings::wait_for_completion(self.as_raw()) };
> > | ^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `__wait_for_completion`
> > |
> > ::: /root/linux/rust/bindings/bindings_generated.rs:33440:5
> > |
> > 33440 | pub fn __wait_for_completion(arg1: *mut completion);
> > | ---------------------------------------------------- similarly named function `__wait_for_completion` defined here
> >
> > error: aborting due to 1 previous error
> >
> > For more information about this error, try `rustc --explain E0425`.
> > ```
> >
>
> I think Danilo already made it clear, please fold this the existing
> patch. Moreover, since this patchset doesn't adjust init_completion()
> from the Rust side, the result is Rust code will also use the same dept
> key for completion, which has to be fixed if dept wants to be in-tree.
Right. The same key in Rust may generate false positives. However, for
now, I will keep the current code until finding ways to assign
appropriate keys in Rust. Thanks anyway.
Byungchul
> Regards,
> Boqun
>
> > Signed-off-by: Guangbo Cui <2407018371@qq.com>
> > ---
> > rust/helpers/completion.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/rust/helpers/completion.c b/rust/helpers/completion.c
> > index b2443262a2ae..5bae5e749def 100644
> > --- a/rust/helpers/completion.c
> > +++ b/rust/helpers/completion.c
> > @@ -6,3 +6,8 @@ void rust_helper_init_completion(struct completion *x)
> > {
> > init_completion(x);
> > }
> > +
> > +void rust_helper_wait_for_completion(struct completion *x)
> > +{
> > + wait_for_completion(x);
> > +}
> > --
> > 2.43.0
> >
prev parent reply other threads:[~2025-11-19 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251002081247.51255-37-byungchul@sk.com>
2025-10-02 10:06 ` [PATCH] rust: bindings: add `rust_helper_wait_for_completion` helper function Guangbo Cui
2025-10-02 10:27 ` Danilo Krummrich
2025-11-13 1:21 ` Byungchul Park
2025-10-02 10:39 ` Miguel Ojeda
2025-10-02 16:52 ` Guangbo Cui
2025-10-02 17:27 ` Boqun Feng
2025-11-13 1:20 ` Byungchul Park
2025-11-13 2:02 ` Byungchul Park
2025-11-19 9:38 ` Byungchul Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119093829.GA20446@system.software.com \
--to=byungchul@sk.com \
--cc=2407018371@qq.com \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=amir73il@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=andrii@kernel.org \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=bsegall@google.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel_team@skhynix.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=link@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=matthew.brost@intel.com \
--cc=max.byungchul.park@gmail.com \
--cc=mcgrof@kernel.org \
--cc=melissa.srw@gmail.com \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=ojeda@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=petr.pavlu@suse.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
--cc=yeoreum.yun@arm.com \
--cc=ysk@kzalloc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).