From: "Onur Özkan" <work@onurozkan.dev>
To: Lyude Paul <lyude@redhat.com>
Cc: rust-for-linux@vger.kernel.org, lossin@kernel.org,
ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com,
gary@garyguo.net, a.hindborg@kernel.org, aliceryhl@google.com,
tmgross@umich.edu, dakr@kernel.org, peterz@infradead.org,
mingo@redhat.com, will@kernel.org, longman@redhat.com,
felipe_life@live.com, daniel@sedlak.dev,
bjorn3_gh@protonmail.com, daniel.almeida@collabora.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/6] rust: implement `Class` for ww_class support
Date: Thu, 27 Nov 2025 11:57:35 +0300 [thread overview]
Message-ID: <20251127115735.52946137@nimda.home> (raw)
In-Reply-To: <eb0a838221064b02cd4f341e9201cc2cf31be8e2.camel@redhat.com>
On Fri, 21 Nov 2025 14:15:00 -0500
Lyude Paul <lyude@redhat.com> wrote:
> This should be is_wait_die.into() like you did in the code below.
Can't call into() in const function.
> With that:
>
> Reviewed-by: Lyude Paul <lyude@redhat.com>
>
> On Sat, 2025-11-01 at 19:10 +0300, Onur Özkan wrote:
> > +impl Class {
> > + /// Creates an unpinned [`Class`].
> > + ///
> > + /// # Safety
> > + ///
> > + /// Caller must guarantee that the returned value is not moved
> > after creation.
> > + pub const unsafe fn unpinned_new(name: &'static CStr,
> > is_wait_die: bool) -> Self {
> > + Class {
> > + inner: Opaque::new(bindings::ww_class {
> > + stamp: bindings::atomic_long_t { counter: 0 },
> > + acquire_name: name.as_char_ptr(),
> > + mutex_name: name.as_char_ptr(),
> > + is_wait_die: is_wait_die as u32,
>
-Onur
next prev parent reply other threads:[~2025-11-27 9:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-01 16:10 [PATCH v7 0/6] rust: add `ww_mutex` support Onur Özkan
2025-11-01 16:10 ` [PATCH v7 1/6] rust: add C wrappers for ww_mutex inline functions Onur Özkan
2025-11-21 19:08 ` Lyude Paul
2025-11-25 15:53 ` Daniel Almeida
2025-11-01 16:10 ` [PATCH v7 2/6] rust: implement `Class` for ww_class support Onur Özkan
2025-11-21 19:15 ` Lyude Paul
2025-11-27 8:57 ` Onur Özkan [this message]
2025-11-25 16:12 ` Daniel Almeida
2025-11-01 16:10 ` [PATCH v7 3/6] rust: error: add EDEADLK Onur Özkan
2025-11-21 19:49 ` Lyude Paul
2025-11-25 16:13 ` Daniel Almeida
2025-11-01 16:10 ` [PATCH v7 4/6] rust: ww_mutex: add Mutex, AcquireCtx and MutexGuard Onur Özkan
2025-11-21 21:00 ` Lyude Paul
2025-11-27 9:24 ` Onur Özkan
2025-11-28 11:37 ` Onur Özkan
2025-11-25 18:32 ` Daniel Almeida
2025-11-25 18:59 ` Onur Özkan
2025-11-01 16:10 ` [PATCH v7 5/6] rust: ww_mutex: implement LockSet Onur Özkan
2025-11-21 22:34 ` Lyude Paul
2025-11-24 15:49 ` Onur Özkan
2025-11-25 19:01 ` Daniel Almeida
2025-11-25 20:08 ` Onur Özkan
2025-11-25 21:35 ` Lyude Paul
2025-11-25 21:47 ` Daniel Almeida
2025-11-25 22:14 ` Lyude Paul
2025-11-27 10:16 ` Onur Özkan
2025-11-27 13:46 ` Daniel Almeida
2025-11-01 16:10 ` [PATCH v7 6/6] rust: add test coverage for ww_mutex implementation Onur Özkan
2025-11-10 5:28 ` [PATCH v7 0/6] rust: add `ww_mutex` support Onur Özkan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127115735.52946137@nimda.home \
--to=work@onurozkan.dev \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=daniel@sedlak.dev \
--cc=felipe_life@live.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=mingo@redhat.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).