From: Asuna Yang <spriteovo@gmail.com>
To: "Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nsc@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jason Montleon" <jmontleo@redhat.com>,
"Han Gao" <rabenda.cn@gmail.com>,
"Conor Dooley" <conor@kernel.org>,
"Vivian Wang" <wangruikang@iscas.ac.cn>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, llvm@lists.linux.dev,
linux-riscv@lists.infradead.org, linux-doc@vger.kernel.org,
Asuna Yang <SpriteOvO@gmail.com>,
Asuna Yang <spriteovo@gmail.com>
Subject: [PATCH v5 2/4] rust: generate a fatal error if BINDGEN_TARGET is undefined
Date: Thu, 04 Dec 2025 08:54:52 +0100 [thread overview]
Message-ID: <20251204-gcc-rust-v5-v5-2-2d4f20d86c24@gmail.com> (raw)
In-Reply-To: <20251204-gcc-rust-v5-v5-0-2d4f20d86c24@gmail.com>
From: Asuna Yang <spriteovo@gmail.com>
Generate a friendly fatal error if the target triplet is undefined for
bindgen, rather than having the compiler generate obscure error messages
during the build stage.
This piece of code is copied from `scripts/Makefile.clang`.
Before this commit, error messages might look like:
error: unknown argument: '-mno-riscv-attribute'
error: unsupported argument 'medany' to option '-mcmodel=' for target
'unknown'
error: unsupported option '-march=' for target ''
error: unsupported option '-mno-save-restore' for target ''
error: unknown target triple 'unknown'
panicked at bindgen/ir/context.rs:562:15:
libclang error; possible causes include:
- Invalid flag syntax
- Unrecognized flags
- Invalid flag arguments
- File I/O errors
- Host vs. target architecture mismatch
Acked-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Asuna Yang <SpriteOvO@gmail.com>
---
scripts/Makefile.rust | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/Makefile.rust b/scripts/Makefile.rust
index 5c12b4b8c8b6..b219244cd051 100644
--- a/scripts/Makefile.rust
+++ b/scripts/Makefile.rust
@@ -6,4 +6,8 @@ BINDGEN_TARGET_loongarch := loongarch64-linux-gnusf
BINDGEN_TARGET_um := $(BINDGEN_TARGET_$(SUBARCH))
BINDGEN_TARGET := $(BINDGEN_TARGET_$(SRCARCH))
+ifeq ($(BINDGEN_TARGET),)
+$(error add '--target=' option to scripts/Makefile.rust)
+else
export BINDGEN_TARGET
+endif
--
2.51.1
next prev parent reply other threads:[~2025-12-04 7:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 7:54 [PATCH v5 0/4] EDITME: RISC-V: re-enable gcc + rust builds Asuna Yang
2025-12-04 7:54 ` [PATCH v5 1/4] rust: export BINDGEN_TARGET from a separate Makefile Asuna Yang
2025-12-04 7:54 ` Asuna Yang [this message]
2025-12-04 12:41 ` [PATCH v5 2/4] rust: generate a fatal error if BINDGEN_TARGET is undefined Asuna Yang
2025-12-04 7:54 ` [PATCH v5 3/4] rust: add a Kconfig function to test for support of bindgen options Asuna Yang
2025-12-04 9:06 ` Vivian Wang
2025-12-04 12:33 ` Asuna Yang
2025-12-06 18:16 ` Vivian Wang
2025-12-06 23:41 ` Asuna Yang
2025-12-04 7:54 ` [PATCH v5 4/4] RISC-V: handle extension configs for bindgen, re-enable gcc + rust builds Asuna Yang
2025-12-04 8:26 ` [PATCH v5 0/4] EDITME: RISC-V: " Asuna Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204-gcc-rust-v5-v5-2-2d4f20d86c24@gmail.com \
--to=spriteovo@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex@ghiti.fr \
--cc=aliceryhl@google.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=jmontleo@redhat.com \
--cc=justinstitt@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=lossin@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nsc@kernel.org \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rabenda.cn@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).