* [PATCH] rust: sync: atomic: Fix fmt warning [not found] <202512110753.8B3YlvtX-lkp@intel.com> @ 2025-12-11 21:31 ` Boqun Feng 2025-12-11 23:16 ` Miguel Ojeda 0 siblings, 1 reply; 3+ messages in thread From: Boqun Feng @ 2025-12-11 21:31 UTC (permalink / raw) To: Peter Zijlstra, Ingo Molnar, Thomas Gleixner Cc: Will Deacon, Boqun Feng, Mark Rutland, Gary Guo, Miguel Ojeda, Alex Gaynor, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich, Greg Kroah-Hartman, linux-kernel, rust-for-linux, oe-kbuild-all, x86, kernel test robot Commit 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)") introduced an import ordering that rustfmt disagrees with. Hence fix it. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/lkml/202512110753.8B3YlvtX-lkp@intel.com/ Fixes: 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)") Signed-off-by: Boqun Feng <boqun.feng@gmail.com> --- Hi Ingo & Peter, Looks like I missed one rustfmt issue in the commit 14e9a18b07ec in tip/locking/core, here is the fix. Feel free to fold it if you want. Apologies for not catching this earlier. rust/kernel/sync/atomic.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/sync/atomic.rs b/rust/kernel/sync/atomic.rs index 3afc376be42d..c07a53f8360b 100644 --- a/rust/kernel/sync/atomic.rs +++ b/rust/kernel/sync/atomic.rs @@ -21,8 +21,8 @@ mod predefine; pub use internal::AtomicImpl; -pub use ordering::{Acquire, Full, Relaxed, Release}; pub(crate) use internal::{AtomicArithmeticOps, AtomicBasicOps, AtomicExchangeOps}; +pub use ordering::{Acquire, Full, Relaxed, Release}; use crate::build_error; use internal::AtomicRepr; -- 2.51.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: sync: atomic: Fix fmt warning 2025-12-11 21:31 ` [PATCH] rust: sync: atomic: Fix fmt warning Boqun Feng @ 2025-12-11 23:16 ` Miguel Ojeda 2025-12-11 23:29 ` Boqun Feng 0 siblings, 1 reply; 3+ messages in thread From: Miguel Ojeda @ 2025-12-11 23:16 UTC (permalink / raw) To: Boqun Feng Cc: Peter Zijlstra, Ingo Molnar, Thomas Gleixner, Will Deacon, Mark Rutland, Gary Guo, Miguel Ojeda, Alex Gaynor, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich, Greg Kroah-Hartman, linux-kernel, rust-for-linux, oe-kbuild-all, x86, kernel test robot On Thu, Dec 11, 2025 at 10:31 PM Boqun Feng <boqun.feng@gmail.com> wrote: > > Commit 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)") > introduced an import ordering that rustfmt disagrees with. Hence fix it. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/lkml/202512110753.8B3YlvtX-lkp@intel.com/ > Fixes: 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)") > Signed-off-by: Boqun Feng <boqun.feng@gmail.com> > --- > Hi Ingo & Peter, > > Looks like I missed one rustfmt issue in the commit 14e9a18b07ec in > tip/locking/core, here is the fix. Feel free to fold it if you want. > Apologies for not catching this earlier. Linus picked 309e49039f12 ("rust: sync: atomic: separate import "blocks"") in mainline a few days ago (but the solution I did was to add a newline to separate the import "blocks" with different visibility instead). Cheers, Miguel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: sync: atomic: Fix fmt warning 2025-12-11 23:16 ` Miguel Ojeda @ 2025-12-11 23:29 ` Boqun Feng 0 siblings, 0 replies; 3+ messages in thread From: Boqun Feng @ 2025-12-11 23:29 UTC (permalink / raw) To: Miguel Ojeda Cc: Peter Zijlstra, Ingo Molnar, Thomas Gleixner, Will Deacon, Mark Rutland, Gary Guo, Miguel Ojeda, Alex Gaynor, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich, Greg Kroah-Hartman, linux-kernel, rust-for-linux, oe-kbuild-all, x86, kernel test robot On Fri, Dec 12, 2025 at 12:16:45AM +0100, Miguel Ojeda wrote: > On Thu, Dec 11, 2025 at 10:31 PM Boqun Feng <boqun.feng@gmail.com> wrote: > > > > Commit 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)") > > introduced an import ordering that rustfmt disagrees with. Hence fix it. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/lkml/202512110753.8B3YlvtX-lkp@intel.com/ > > Fixes: 14e9a18b07ec ("rust: sync: atomic: Make Atomic*Ops pub(crate)") > > Signed-off-by: Boqun Feng <boqun.feng@gmail.com> > > --- > > Hi Ingo & Peter, > > > > Looks like I missed one rustfmt issue in the commit 14e9a18b07ec in > > tip/locking/core, here is the fix. Feel free to fold it if you want. > > Apologies for not catching this earlier. > > Linus picked 309e49039f12 ("rust: sync: atomic: separate import > "blocks"") in mainline a few days ago (but the solution I did was to > add a newline to separate the import "blocks" with different > visibility instead). > I see, I must miss that. Hence I'm happy to drop this patch ;-) Thank you! Regards, Boqun > Cheers, > Miguel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-11 23:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202512110753.8B3YlvtX-lkp@intel.com>
2025-12-11 21:31 ` [PATCH] rust: sync: atomic: Fix fmt warning Boqun Feng
2025-12-11 23:16 ` Miguel Ojeda
2025-12-11 23:29 ` Boqun Feng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).