rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: FUJITA Tomonori <fujita.tomonori@gmail.com>
To: ojeda@kernel.org, a.hindborg@kernel.org
Cc: aliceryhl@google.com, bjorn3_gh@protonmail.com,
	boqun.feng@gmail.com, dakr@kernel.org, gary@garyguo.net,
	lossin@kernel.org, tmgross@umich.edu,
	rust-for-linux@vger.kernel.org
Subject: [PATCH v1 1/3] rust: sync: set_once: Add fast-path check to avoid expensive cmpxchg
Date: Fri, 12 Dec 2025 08:09:17 +0900	[thread overview]
Message-ID: <20251211230919.1303926-1-fujita.tomonori@gmail.com> (raw)

Check if already initialized before calling cmpxchg in populate().

When SetOnce is already populated, this avoids the expensive LOCK
CMPXCHG operation and uses a simple load instead.

The Relaxed load is safe here because it's only a hint; the subsequent
cmpxchg provides the actual synchronization. Even if we read a stale
value (0), the cmpxchg will correctly fail.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
---
 rust/kernel/sync/set_once.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/rust/kernel/sync/set_once.rs b/rust/kernel/sync/set_once.rs
index bdba601807d8..889d37dfd17f 100644
--- a/rust/kernel/sync/set_once.rs
+++ b/rust/kernel/sync/set_once.rs
@@ -80,6 +80,10 @@ pub fn as_ref(&self) -> Option<&T> {
     ///
     /// Returns `true` if the [`SetOnce`] was successfully populated.
     pub fn populate(&self, value: T) -> bool {
+        // Avoid expensive cmpxchg if already initialized.
+        if self.init.load(Relaxed) != 0 {
+            return false;
+        }
         // INVARIANT: If the swap succeeds:
         //  - We increase `init`.
         //  - We write the valid value `1` to `init`.

base-commit: d358e5254674b70f34c847715ca509e46eb81e6f
-- 
2.43.0


             reply	other threads:[~2025-12-11 23:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-11 23:09 FUJITA Tomonori [this message]
2025-12-11 23:09 ` [PATCH v1 2/3] rust: sync: set_once: Implement Send and Sync FUJITA Tomonori
2025-12-12  0:34   ` Gary Guo
2025-12-12  2:07     ` FUJITA Tomonori
2025-12-11 23:09 ` [PATCH v1 3/3] rust: sync: set_once: fix doc section heading FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251211230919.1303926-1-fujita.tomonori@gmail.com \
    --to=fujita.tomonori@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).