From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010063.outbound.protection.outlook.com [52.101.85.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B34AA257459 for ; Sat, 3 Jan 2026 05:00:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.63 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767416403; cv=fail; b=glvbSyg1FjJgLualplkzm0JIkniJYMYZQgjWAMUoQOiPiZzZVcwsA6VoWvfnNhHq6Cl3YKd6s9jqCwj2T7g56QDahWHZRll21Y/LdvIEnM1EHqOq7wgteEvq5kM/0QIZUHTs1UPA00AemaVEzANAKx3olO9LXWRROmwMj+BfTUI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767416403; c=relaxed/simple; bh=hkd6T/N7qYrUVG7lZZyXuuU8HKxi4OI1vqSxKyk/Wgg=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=V90ZPF0kO3ZiKLeeT5XOzH3HMU8Llp9W7N+O/6N+711QfwY5zuc2EwDfraDVceEMEUCDqseXjYDsb/PgGuryEAguu0e+MqqB6ksjyzy7swBZUiXCoq35wgomyqlePr9XjP1nnoFEaKzPh1KID9KbZt8kvTsh9F8Azg4xelFbLQU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Dw24v31I; arc=fail smtp.client-ip=52.101.85.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Dw24v31I" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I69i334+Sb3IK3wPikTCnPYQVva7XGr8wXzDuk6SWlPmapK4JWOyHXRbIfayATcGFBXJTc4nxpLMIjJTuhO72AypdDKrcXjLSXWSMY3kFVrgPzLMYoR9BX4sjNEfU3hyQkJq4kTIUdK7+44woCXRRU9Sa5MU+58zYHcGAYo0gXNLf1/yTl4AtWQFguV+ECiBxMWyTcpafhSpTrIdDatxXovhLjSzrgQXuhytBPscFfTcRrwv+bomwZiVXTjDcbfNoFjidntQr5hpP7hU1hOmXiJDHrql1/wZO9UIoAY7RgZIsZ/keMI3EgNAHqGbYfUm9w1hbHmGdsiTxC4srRwh5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5jF3FWsb0wBTDatJ2Q6r7XpVY7o3Alj4ghGZG0HNzSk=; b=RjfQekGdJUh87Tw6yZicgt52Z1q4I7cc023/rMTpqYtvG+PIEycN1ztKcEpZUl84NqXmHcpY21CDEqWnn/cmvw/v9kQQPDgFQam9sEaW46GKp6xgn9+rnms/aWLzZLNYXRH32+1HtE6WAXn23l312BjSjP8LskvVhy0A2mDgALIpiFdrgLrk3+T9DV0EZ8bke927GTHzUpDovutr5oOOGvDF7alDJZs/vRLYnjPbXOUF/Abw78fF/OndO//YhGNi9VTcZLr/Aa4UO/JBLN2w5PtBIbbHx6Oycppm/b+sqUABq8kXjiN0JgkO6J7MxjEPqcRnsvcHMxwmRf+FfTgPqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5jF3FWsb0wBTDatJ2Q6r7XpVY7o3Alj4ghGZG0HNzSk=; b=Dw24v31Iyyg+LuyHQbpafR19KNQklf1T/khfkXezd6QTjHRGlu3T8FGowsdB4+SRYXPUScsBg0nh5fKYuiiXDN5oKnDy9VOvT84iJZVnu6xoSZ/mY503KGsK1kf+qjI2LhI3g4+6ku/jP6j2O/4VvAVyzic2wrGeRMajEaw5IhhmbGX2zZ8/QnBBuhDNHFm0qLrLe1EO6yW0EqPN+jKH47FYUr1V8ZSJhrPqQjetUpj6O4Sa0sHYuGScE2qO0FkA2XnAPUAqPY+pELbAkqGS1FdLMpFvN44rJBANCQPYBbjeCpiUiuHwZrLYmpTx+TCDnlq0ov77JIgcLyDgd6hrLw== Received: from SA1PR04CA0023.namprd04.prod.outlook.com (2603:10b6:806:2ce::27) by DS0PR12MB6439.namprd12.prod.outlook.com (2603:10b6:8:c9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9478.4; Sat, 3 Jan 2026 04:59:58 +0000 Received: from SN1PEPF00026367.namprd02.prod.outlook.com (2603:10b6:806:2ce:cafe::8b) by SA1PR04CA0023.outlook.office365.com (2603:10b6:806:2ce::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9478.4 via Frontend Transport; Sat, 3 Jan 2026 04:59:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF00026367.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.1 via Frontend Transport; Sat, 3 Jan 2026 04:59:58 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Fri, 2 Jan 2026 20:59:50 -0800 Received: from ubuntu (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Fri, 2 Jan 2026 20:59:48 -0800 From: Timur Tabi To: Danilo Krummrich , Alexandre Courbot , Joel Fernandes , John Hubbard , , Subject: [PATCH v5 05/11] gpu: nova-core: add NV_PFALCON_FALCON_DMATRFCMD::with_falcon_mem() Date: Fri, 2 Jan 2026 22:59:28 -0600 Message-ID: <20260103045934.64521-6-ttabi@nvidia.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260103045934.64521-1-ttabi@nvidia.com> References: <20260103045934.64521-1-ttabi@nvidia.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF00026367:EE_|DS0PR12MB6439:EE_ X-MS-Office365-Filtering-Correlation-Id: 6dc44a11-81e2-42aa-29d1-08de4a84f1b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lOKdq6DNQsieKCSwFT1rvSDmkqnEVbegd9x6NDJQlsUT34c4OSR4xUcu5BrP?= =?us-ascii?Q?dvKTq+4L5TouVrAirW6fPMJ0nnMhSAc24Z9NOPXVUgQ8gVPIMGcefMb1LhF0?= =?us-ascii?Q?3uMqGwHN3OvTeNzGP9Y1RbFbzUy1WOdhpYxOLqjfMdKLDc5skU5jmXwBnWx4?= =?us-ascii?Q?iEpBCD947vT7zXgysAQoZ39UEmPMOhNggzRRR4GDunrupLZkVh12E3aiM4Im?= =?us-ascii?Q?1q2StzFSw6PDwqzEnrKw3tnwj0HRurk6ZDJxSPP40sExf3Ys3mtC+UkV5pIC?= =?us-ascii?Q?38epsd2R19w1y7UxGPb2QmUED4zErTsYqAFC96T12AoHlqqgrgkDvWV160jz?= =?us-ascii?Q?KhLpNt5NKT0vXclS9B3z9jyA9ADpFpWjZ7dkx5rmhB8IYto3YarKioW480jW?= =?us-ascii?Q?Ev4E8TXyq6WaOl12eupxo6UkLW/PAlW2XH75m3EPXb0ZXRL2RrkAsZ+rrakk?= =?us-ascii?Q?NE/A3Fcxj4qUtEy2ds2/0qhILLI9F9ouNXbMD6IU7EWZtibuSA1ZWxHDRKbA?= =?us-ascii?Q?D167V3XhsT9IQWXPBRHRQDqTk605X/NtZ/v41JAl/oBLN2vFJ9J9MHIl72vV?= =?us-ascii?Q?pPEtM5x+iZm2JOw6OVC3fTStqg7Pf1F5UtelvZUOIkdWOWmgKPrrKq9wthKi?= =?us-ascii?Q?c4BHHo4aWzzAmqdkSRQhhXzMkBsZbrVPQv2SUVg5VnAr0OK26tTStZgrwBcz?= =?us-ascii?Q?vJedOUdqO4I9PqyhptDfhDonVMVWuhgCzm1ugx/PEfTM60s/uTWSWNfhtQYU?= =?us-ascii?Q?+qRCChHdBaAjC0AK6T1kERsMH7tpSWSRkm43x4hu8vdrOcFGfSxRw50kLMSg?= =?us-ascii?Q?1T3mmmtCbsvdWdpI5uAuSv2I6scJQm5B3bXJi/NwdJRpoHcI+eI8P8VTpQlE?= =?us-ascii?Q?SY6WTjRml+aThvLniO3T6O0gM/iUu3atXy73bfLvOTcW+6WCGXyanM9VMo0N?= =?us-ascii?Q?4uS2d54o8zPvdZL8uau6pWZ0dzu9gpwBhiDsKfG+Lsc8Feh1FRskMxWBn/v5?= =?us-ascii?Q?br6AkgKvI3t9MMyLE+qSpQsGHrcqCxx/uFE0Ie15prYCg9UgDDaEwKdLjURA?= =?us-ascii?Q?yrKc26Clo1YVtCEn7PPXtXpb+vFv5Wkwh44hb/jER18SRicKuN1NKqV++swj?= =?us-ascii?Q?S70x0OYVdFn5rgkQyM9JZsJp1Oig2wuE0ZCeXISfkjhFuVRsqGi3lAXqm4WV?= =?us-ascii?Q?5eVJWALh48Yr7m2m9bMHjEwsqH0L6p1yFCK42qCJ2Fgw8mGe2aN8dfGQdCjF?= =?us-ascii?Q?z+abY/mOZAQcZr41vM7eq62SmT1ohM7CzmHWzjUmTeBXjtb+w/JqAK+CjJkO?= =?us-ascii?Q?U3zMqfJjM9LRiz5c91z9bo5xYXBYu08md3DQUsCvWyz4owAe9gOAxKydgdZl?= =?us-ascii?Q?904c2JeDc0XyqH4/i6lJJcN16ffXittilJJJp+y97MkCuW1qSqegTPj3eKjE?= =?us-ascii?Q?n0/p7uz+GRubj8c6kLQaW8GHDgGTp0CtnRlqFjgMqcVeV5u1jMT0EGV6mQC5?= =?us-ascii?Q?AIOuzMpxq/sUN6QDN8OOurbAPThLWY6veF3mN0ZDyzclxanlOO9Ot55o5tev?= =?us-ascii?Q?TsoF74TqEENVjZS29UQ=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2026 04:59:58.3382 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6dc44a11-81e2-42aa-29d1-08de4a84f1b8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF00026367.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6439 The with_falcon_mem() method initializes the 'imem' and 'sec' fields of the NV_PFALCON_FALCON_DMATRFCMD register based on the value of the FalconMem type. Signed-off-by: Timur Tabi Reviewed-by: John Hubbard --- drivers/gpu/nova-core/falcon.rs | 14 +++----------- drivers/gpu/nova-core/regs.rs | 9 +++++++++ 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/nova-core/falcon.rs b/drivers/gpu/nova-core/falcon.rs index 974abc2de649..fd972ec19a67 100644 --- a/drivers/gpu/nova-core/falcon.rs +++ b/drivers/gpu/nova-core/falcon.rs @@ -454,7 +454,6 @@ fn dma_wr>( fw: &F, target_mem: FalconMem, load_offsets: FalconLoadTarget, - sec: bool, ) -> Result { const DMA_LEN: u32 = 256; @@ -516,8 +515,7 @@ fn dma_wr>( let cmd = regs::NV_PFALCON_FALCON_DMATRFCMD::default() .set_size(DmaTrfCmdSize::Size256B) - .set_imem(target_mem != FalconMem::Dmem) - .set_sec(if sec { 1 } else { 0 }); + .with_falcon_mem(target_mem); for pos in (0..num_transfers).map(|i| i * DMA_LEN) { // Perform a transfer of size `DMA_LEN`. @@ -558,14 +556,8 @@ pub(crate) fn dma_load>(&self, bar: &Bar0, fw: &F) .set_mem_type(FalconFbifMemType::Physical) }); - self.dma_wr( - bar, - fw, - FalconMem::ImemSecure, - fw.imem_sec_load_params(), - true, - )?; - self.dma_wr(bar, fw, FalconMem::Dmem, fw.dmem_load_params(), true)?; + self.dma_wr(bar, fw, FalconMem::ImemSecure, fw.imem_sec_load_params())?; + self.dma_wr(bar, fw, FalconMem::Dmem, fw.dmem_load_params())?; self.hal.program_brom(self, bar, &fw.brom_params())?; diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs index 82cc6c0790e5..b8ddfe2e5ae7 100644 --- a/drivers/gpu/nova-core/regs.rs +++ b/drivers/gpu/nova-core/regs.rs @@ -16,6 +16,7 @@ FalconCoreRevSubversion, FalconFbifMemType, FalconFbifTarget, + FalconMem, FalconModSelAlgo, FalconSecurityModel, PFalcon2Base, @@ -325,6 +326,14 @@ pub(crate) fn mem_scrubbing_done(self) -> bool { 16:16 set_dmtag as u8; }); +impl NV_PFALCON_FALCON_DMATRFCMD { + /// Programs the `imem` and `sec` fields for the given FalconMem + pub(crate) fn with_falcon_mem(self, mem: FalconMem) -> Self { + self.set_imem(mem != FalconMem::Dmem) + .set_sec(if mem == FalconMem::ImemSecure { 1 } else { 0 }) + } +} + register!(NV_PFALCON_FALCON_DMATRFFBOFFS @ PFalconBase[0x0000011c] { 31:0 offs as u32; }); -- 2.51.0