Re: [PATCH v5 11/11] gpu: nova-core: add PIO support for loading firmware images

[kernel test robot <lkp@intel.com>]

Hi Timur,

kernel test robot noticed the following build errors:

[auto build test ERROR on 7acc70476f14661149774ab88d3fe23d83ba4249]

url:    https://github.com/intel-lab-lkp/linux/commits/Timur-Tabi/gpu-nova-core-rename-Imem-to-ImemSecure/20260103-130228
base:   7acc70476f14661149774ab88d3fe23d83ba4249
patch link:    https://lore.kernel.org/r/20260103045934.64521-12-ttabi%40nvidia.com
patch subject: [PATCH v5 11/11] gpu: nova-core: add PIO support for loading firmware images
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20260103/202601031330.EOufCyjz-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260103/202601031330.EOufCyjz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601031330.EOufCyjz-lkp@intel.com/

All errors (new ones prefixed by >>):

   PATH=/opt/cross/clang-20/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
   INFO PATH=/opt/cross/rustc-1.88.0-bindgen-0.72.1/cargo/bin:/opt/cross/clang-20/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
   /usr/bin/timeout -k 100 12h /usr/bin/make KCFLAGS= -fno-crash-diagnostics -Wno-error=return-type -Wreturn-type -funsigned-char -Wundef W=1 --keep-going LLVM=1 -j32 -C source O=/kbuild/obj/consumer/x86_64-rhel-9.4-rust ARCH=x86_64 SHELL=/bin/bash rustfmtcheck
   make: Entering directory '/kbuild/src/consumer'
   make[1]: Entering directory '/kbuild/obj/consumer/x86_64-rhel-9.4-rust'
>> Diff in drivers/gpu/nova-core/falcon/hal/ga102.rs:13:
    use crate::{
        driver::Bar0,
        falcon::{
   +        hal::LoadMethod,
            Falcon,
            FalconBromParams,
            FalconEngine,
   Diff in drivers/gpu/nova-core/falcon/hal/ga102.rs:19:
            FalconModSelAlgo,
   -        hal::LoadMethod,
            PeregrineCoreSelect, //
        },
        regs,
>> Diff in drivers/gpu/nova-core/falcon/hal/tu102.rs:12:
    use crate::{
        driver::Bar0,
        falcon::{
   +        hal::LoadMethod, //
            Falcon,
            FalconBromParams,
            FalconEngine,
   Diff in drivers/gpu/nova-core/falcon/hal/tu102.rs:18:
   -        hal::LoadMethod, //
        },
        regs, //
    };
   Diff in drivers/gpu/nova-core/falcon.rs:674:
    
        /// Perform a DMA load into `IMEM` and `DMEM` of `fw`, and prepare the falcon to run it.
        pub(crate) fn dma_load<F: FalconFirmware<Target = E>>(&self, bar: &Bar0, fw: &F) -> Result {
   -
            // The Non-Secure section only exists on firmware used by Turing and GA100, and
            // those platforms do not use DMA.
            if fw.imem_ns_load_params().is_some() {
>> Diff in drivers/gpu/nova-core/firmware/fwsec.rs:516:
            // console error message on other platforms, only try to load it if it's
            // supposed to be there.
            let gbl_fw = if chipset < Chipset::GA102 {
   -            Some(super::request_firmware(dev, chipset, "gen_bootloader", FIRMWARE_VERSION)?)
   +            Some(super::request_firmware(
   +                dev,
   +                chipset,
   +                "gen_bootloader",
   +                FIRMWARE_VERSION,
   +            )?)
            } else {
                None
            };
>> Diff in drivers/gpu/nova-core/firmware/fwsec.rs:516:
            // console error message on other platforms, only try to load it if it's
            // supposed to be there.
            let gbl_fw = if chipset < Chipset::GA102 {
   -            Some(super::request_firmware(dev, chipset, "gen_bootloader", FIRMWARE_VERSION)?)
   +            Some(super::request_firmware(
   +                dev,
   +                chipset,
   +                "gen_bootloader",
   +                FIRMWARE_VERSION,
   +            )?)
            } else {
                None
            };
>> Diff in drivers/gpu/nova-core/falcon/hal/ga102.rs:13:
    use crate::{
        driver::Bar0,
        falcon::{
   +        hal::LoadMethod,
            Falcon,
            FalconBromParams,
            FalconEngine,
   Diff in drivers/gpu/nova-core/falcon/hal/ga102.rs:19:
            FalconModSelAlgo,
   -        hal::LoadMethod,
            PeregrineCoreSelect, //
        },
        regs,
>> Diff in drivers/gpu/nova-core/falcon/hal/tu102.rs:12:
    use crate::{
        driver::Bar0,
        falcon::{
   +        hal::LoadMethod, //
            Falcon,
            FalconBromParams,
            FalconEngine,
   Diff in drivers/gpu/nova-core/falcon/hal/tu102.rs:18:
   -        hal::LoadMethod, //
        },
        regs, //
    };
   Diff in drivers/gpu/nova-core/falcon.rs:674:
    
        /// Perform a DMA load into `IMEM` and `DMEM` of `fw`, and prepare the falcon to run it.
        pub(crate) fn dma_load<F: FalconFirmware<Target = E>>(&self, bar: &Bar0, fw: &F) -> Result {
   -
            // The Non-Secure section only exists on firmware used by Turing and GA100, and
            // those platforms do not use DMA.
            if fw.imem_ns_load_params().is_some() {
>> Diff in drivers/gpu/nova-core/firmware/fwsec.rs:516:
            // console error message on other platforms, only try to load it if it's
            // supposed to be there.
            let gbl_fw = if chipset < Chipset::GA102 {
   -            Some(super::request_firmware(dev, chipset, "gen_bootloader", FIRMWARE_VERSION)?)
   +            Some(super::request_firmware(
   +                dev,
   +                chipset,
   +                "gen_bootloader",
   +                FIRMWARE_VERSION,
   +            )?)
            } else {
                None
            };
>> Diff in drivers/gpu/nova-core/falcon/hal/ga102.rs:13:
    use crate::{
        driver::Bar0,
        falcon::{
   +        hal::LoadMethod,
            Falcon,
            FalconBromParams,
            FalconEngine,
   Diff in drivers/gpu/nova-core/falcon/hal/ga102.rs:19:
            FalconModSelAlgo,
   -        hal::LoadMethod,
            PeregrineCoreSelect, //
        },
        regs,
>> Diff in drivers/gpu/nova-core/falcon/hal/tu102.rs:12:
    use crate::{
        driver::Bar0,
        falcon::{
   +        hal::LoadMethod, //
            Falcon,
            FalconBromParams,
            FalconEngine,
   Diff in drivers/gpu/nova-core/falcon/hal/tu102.rs:18:
   -        hal::LoadMethod, //
        },
        regs, //
    };
>> Diff in drivers/gpu/nova-core/falcon/hal/ga102.rs:13:
    use crate::{
        driver::Bar0,
        falcon::{
   +        hal::LoadMethod,
            Falcon,
            FalconBromParams,
            FalconEngine,
   Diff in drivers/gpu/nova-core/falcon/hal/ga102.rs:19:
            FalconModSelAlgo,
   -        hal::LoadMethod,
            PeregrineCoreSelect, //
        },
        regs,
>> Diff in drivers/gpu/nova-core/falcon/hal/tu102.rs:12:
    use crate::{
        driver::Bar0,
        falcon::{
   +        hal::LoadMethod, //
            Falcon,
            FalconBromParams,
            FalconEngine,
   Diff in drivers/gpu/nova-core/falcon/hal/tu102.rs:18:
   -        hal::LoadMethod, //
        },
        regs, //
    };
   make[2]: *** [Makefile:1871: rustfmt] Error 123
   make[2]: Target 'rustfmtcheck' not remade because of errors.
   make[1]: Leaving directory '/kbuild/obj/consumer/x86_64-rhel-9.4-rust'
   make[1]: *** [Makefile:248: __sub-make] Error 2
   make[1]: Target 'rustfmtcheck' not remade because of errors.
   make: *** [Makefile:248: __sub-make] Error 2
   make: Target 'rustfmtcheck' not remade because of errors.
   make: Leaving directory '/kbuild/src/consumer'

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki