Re: [RFC PATCH v2 3/5] rust: add device wakeup capability support

[Greg KH <greg@kroah.com>]

On Wed, Jan 07, 2026 at 10:37:35PM +0800, Ke Sun wrote:
> Add Rust bindings and wrappers for device wakeup functionality,
> including devm_device_init_wakeup() and dev_pm_set_wake_irq().
> 
> Signed-off-by: Ke Sun <sunke@kylinos.cn>
> ---
>  rust/bindings/bindings_helper.h |  2 ++
>  rust/helpers/device.c           |  7 +++++++
>  rust/kernel/device.rs           | 17 ++++++++++++++++-
>  rust/kernel/irq/request.rs      |  7 +++++++
>  4 files changed, 32 insertions(+), 1 deletion(-)
> 
> diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
> index fa697287cf71b..d6c2b06ac4107 100644
> --- a/rust/bindings/bindings_helper.h
> +++ b/rust/bindings/bindings_helper.h
> @@ -88,6 +88,8 @@
>  #include <linux/workqueue.h>
>  #include <linux/xarray.h>
>  #include <trace/events/rust_sample.h>
> +#include <linux/pm_wakeup.h>
> +#include <linux/pm_wakeirq.h>

Aren't these sorted?

>  /*
>   * The driver-core Rust code needs to know about some C driver-core private
> diff --git a/rust/helpers/device.c b/rust/helpers/device.c
> index 9a4316bafedfb..cae26edd83696 100644
> --- a/rust/helpers/device.c
> +++ b/rust/helpers/device.c
> @@ -1,6 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0
>  
>  #include <linux/device.h>
> +#include <linux/pm_wakeup.h>
> +#include <linux/pm_wakeirq.h>

Why are both of these needed for just one function call?

thanks,

greg k-h